From 7ba0ab27a6d8fd86ff42f88ca7c54e15d8c147a1 Mon Sep 17 00:00:00 2001 From: Jonathan Wall Date: Fri, 15 Oct 2010 12:28:12 -0700 Subject: [PATCH 1/4] Changed the list of comments to html5. --HG-- branch : dev --- .../Views/ListOfComments.cshtml | 27 +++++++++++-------- .../Themes/TheThemeMachine/Styles/Site.css | 13 +++++---- 2 files changed, 22 insertions(+), 18 deletions(-) diff --git a/src/Orchard.Web/Modules/Orchard.Comments/Views/ListOfComments.cshtml b/src/Orchard.Web/Modules/Orchard.Comments/Views/ListOfComments.cshtml index 9de2d99ae..d1c566b6e 100644 --- a/src/Orchard.Web/Modules/Orchard.Comments/Views/ListOfComments.cshtml +++ b/src/Orchard.Web/Modules/Orchard.Comments/Views/ListOfComments.cshtml @@ -2,15 +2,20 @@ @using Orchard.Comments.Models; \ No newline at end of file + + diff --git a/src/Orchard.Web/Themes/TheThemeMachine/Styles/Site.css b/src/Orchard.Web/Themes/TheThemeMachine/Styles/Site.css index 2fb7161ea..7205f7c6c 100644 --- a/src/Orchard.Web/Themes/TheThemeMachine/Styles/Site.css +++ b/src/Orchard.Web/Themes/TheThemeMachine/Styles/Site.css @@ -408,27 +408,26 @@ button:focus, .button:focus { ul.comments, form.comment { margin:1.2em 0 1.2em 1.8em; + list-style: none; } -div.comment { - font-size:1.3em; - font-style:italic; - color:#484848; +article.comment h4 { + font-size:1.4em; } -div.comment a { +article.comment a { color:#484848; text-decoration:none; } -div.comment span.who { +article.comment span.who { font-weight:600; font-style:normal; text-transform:capitalize; color:#333; } -ul.comments li div.text { +article.comment p.text { margin:.6em 0 2.4em 0; } From 46c9dbfc554cc7d9a18429215fe20cfd2c6f5ae3 Mon Sep 17 00:00:00 2001 From: Jonathan Wall Date: Fri, 15 Oct 2010 13:24:26 -0700 Subject: [PATCH 2/4] Wrapped the comments form fields in an ordered list. --HG-- branch : dev --- .../Views/ListOfComments.cshtml | 2 +- .../Views/Parts/Comments.Comments.cshtml | 30 +++++++++++-------- .../Themes/TheThemeMachine/Styles/Site.css | 6 ++-- 3 files changed, 22 insertions(+), 16 deletions(-) diff --git a/src/Orchard.Web/Modules/Orchard.Comments/Views/ListOfComments.cshtml b/src/Orchard.Web/Modules/Orchard.Comments/Views/ListOfComments.cshtml index d1c566b6e..17bff6a75 100644 --- a/src/Orchard.Web/Modules/Orchard.Comments/Views/ListOfComments.cshtml +++ b/src/Orchard.Web/Modules/Orchard.Comments/Views/ListOfComments.cshtml @@ -9,7 +9,7 @@

@Html.LinkOrDefault(comment.Record.UserName, comment.Record.SiteName, new { rel = "nofollow" }) - said + said

diff --git a/src/Orchard.Web/Modules/Orchard.Comments/Views/Parts/Comments.Comments.cshtml b/src/Orchard.Web/Modules/Orchard.Comments/Views/Parts/Comments.Comments.cshtml index 887980133..2be3bafbb 100644 --- a/src/Orchard.Web/Modules/Orchard.Comments/Views/Parts/Comments.Comments.cshtml +++ b/src/Orchard.Web/Modules/Orchard.Comments/Views/Parts/Comments.Comments.cshtml @@ -19,37 +19,41 @@ else if(!Request.IsAuthenticated && !AuthorizedFor(Permissions.AddComment)) { } else { using (Html.BeginForm("Create", "Comment", new { area = "Orchard.Comments" }, FormMethod.Post, new { @class = "comment" })) { @Html.ValidationSummary() -

@T("Add a Comment")

- if (!Request.IsAuthenticated) { + if (!Request.IsAuthenticated) { +

@T("Add a Comment")

-
+
    +
  1. -
-
+ +
  • -
  • -
    + +
  • -
  • + +
    } else { @Html.Hidden("Name", WorkContext.CurrentUser.UserName ?? "") @Html.Hidden("Email", WorkContext.CurrentUser.Email ?? "") }
    -
    +
      +
    1. -
    -
    + +
  • @Html.Hidden("CommentedOn", (int)Model.ContentPart.ContentItem.Id) @Html.Hidden("ReturnUrl", Context.Request.ToUrlString()) @Html.AntiForgeryTokenOrchard() -
  • + +
    } -} \ No newline at end of file +} diff --git a/src/Orchard.Web/Themes/TheThemeMachine/Styles/Site.css b/src/Orchard.Web/Themes/TheThemeMachine/Styles/Site.css index 7205f7c6c..ea846c1ee 100644 --- a/src/Orchard.Web/Themes/TheThemeMachine/Styles/Site.css +++ b/src/Orchard.Web/Themes/TheThemeMachine/Styles/Site.css @@ -303,7 +303,6 @@ label.forcheckbox { margin:0 0 0 .4em; display:inline; } fieldset { padding:0em; margin: 0 0 0em 0; border: 0px solid #dbdbdb; } legend { font-weight: 600; font-size:1.2em; } - input[type="text"], #CommentText, #password, #confirmPassword { border:1px solid #999; display: block; @@ -320,11 +319,14 @@ form.search { width:17em; } -fieldset div {margin:1.6em 0 0 0} +fieldset ol {list-style-type:none;} + +fieldset ol li {margin:1.6em 0 0 0} legend { font-size: 1.4em; border:none; + border:1px solid #ff0000; } label { From 31968a8eaad5ea844d7e8aff72edc5430d2ba266 Mon Sep 17 00:00:00 2001 From: Jonathan Wall Date: Fri, 15 Oct 2010 13:26:18 -0700 Subject: [PATCH 3/4] Removed one test style. --HG-- branch : dev --- src/Orchard.Web/Themes/TheThemeMachine/Styles/Site.css | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Orchard.Web/Themes/TheThemeMachine/Styles/Site.css b/src/Orchard.Web/Themes/TheThemeMachine/Styles/Site.css index ea846c1ee..3ecadbd85 100644 --- a/src/Orchard.Web/Themes/TheThemeMachine/Styles/Site.css +++ b/src/Orchard.Web/Themes/TheThemeMachine/Styles/Site.css @@ -326,7 +326,6 @@ fieldset ol li {margin:1.6em 0 0 0} legend { font-size: 1.4em; border:none; - border:1px solid #ff0000; } label { From 5598623b0a61137fdcb5355c0652c8e5e7614633 Mon Sep 17 00:00:00 2001 From: Jonathan Wall Date: Fri, 15 Oct 2010 13:39:21 -0700 Subject: [PATCH 4/4] Fixed an issue with the legend not rendering. --HG-- branch : dev --- .../Orchard.Comments/Views/Parts/Comments.Comments.cshtml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Orchard.Web/Modules/Orchard.Comments/Views/Parts/Comments.Comments.cshtml b/src/Orchard.Web/Modules/Orchard.Comments/Views/Parts/Comments.Comments.cshtml index 2be3bafbb..a8a7206ab 100644 --- a/src/Orchard.Web/Modules/Orchard.Comments/Views/Parts/Comments.Comments.cshtml +++ b/src/Orchard.Web/Modules/Orchard.Comments/Views/Parts/Comments.Comments.cshtml @@ -20,8 +20,9 @@ else if(!Request.IsAuthenticated && !AuthorizedFor(Permissions.AddComment)) { using (Html.BeginForm("Create", "Comment", new { area = "Orchard.Comments" }, FormMethod.Post, new { @class = "comment" })) { @Html.ValidationSummary() if (!Request.IsAuthenticated) { -

    @T("Add a Comment")

    +
    + @T("Add a Comment")