lsm/Orchard
1
0
Fork 0
mirror of https://github.com/OrchardCMS/Orchard.git synced 2025-07-15 23:37:44 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Caching attribute regexes

Browse Source
This commit is contained in:
Benedek Farkas 2024-12-03 14:25:45 +01:00
parent bc753d2178
commit 03cef87ef3
1 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/Orchard.Web/Modules/Orchard.MediaProcessing/Filters/MediaProcessingHtmlFilter.cs
View File

@ -1,4 +1,5 @@
using System; using System;
using System.Collections.Concurrent;
using System.Collections.Generic; using System.Collections.Generic;
using System.IO; using System.IO;
using System.Text; using System.Text;
@ -23,6 +24,7 @@ namespace Orchard.MediaProcessing.Filters {
private MediaHtmlFilterSettingsPart _settingsPart; private MediaHtmlFilterSettingsPart _settingsPart;
private static readonly Regex _imageTagRegex = new Regex(@"<img\b[^>]*>", RegexOptions.IgnoreCase | RegexOptions.Compiled); private static readonly Regex _imageTagRegex = new Regex(@"<img\b[^>]*>", RegexOptions.IgnoreCase | RegexOptions.Compiled);
private static readonly ConcurrentDictionary<string, Regex> _attributeRegexes = new ConcurrentDictionary<string, Regex>();
private static readonly Dictionary<string, string> _validExtensions = new Dictionary<string, string> { private static readonly Dictionary<string, string> _validExtensions = new Dictionary<string, string> {
{ ".jpeg", "jpg" }, // For example: .jpeg supports compression (quality), format to 'jpg'. { ".jpeg", "jpg" }, // For example: .jpeg supports compression (quality), format to 'jpg'.
{ ".jpg", "jpg" }, { ".jpg", "jpg" },
@ -172,28 +174,29 @@ namespace Orchard.MediaProcessing.Filters {
} }
private string GetAttributeValue(string tag, string attributeName) { private string GetAttributeValue(string tag, string attributeName) {
var match = Regex.Match(tag, GetAttributeRegex(attributeName)); var match = GetAttributeRegex(attributeName).Match(tag);
return match.Success ? match.Groups[1].Value : null; return match.Success ? match.Groups[1].Value : null;
} }
private int GetAttributeValueInt(string tag, string attributeName) { private int GetAttributeValueInt(string tag, string attributeName) =>
var value = GetAttributeValue(tag, attributeName); int.TryParse(GetAttributeValue(tag, attributeName), out int result) ? result : 0;
return int.TryParse(value, out int result) ? result : 0;
}
private string SetAttributeValue(string tag, string attributeName, string value) { private string SetAttributeValue(string tag, string attributeName, string value) {
var attributeRegex = GetAttributeRegex(attributeName); var attributeRegex = GetAttributeRegex(attributeName);
var newAttribute = $"{attributeName}=\"{value}\"";
if (Regex.IsMatch(tag, attributeRegex)) { if (attributeRegex.IsMatch(tag)) {
return Regex.Replace(tag, attributeRegex, $"{attributeName}=\"{value}\""); return attributeRegex.Replace(tag, newAttribute);
} }
else { else {
return tag.Insert(tag.Length - 1, $" {attributeName}=\"{value}\""); return tag.Insert(tag.Length - 1, $" {newAttribute}");
} }
} }
private string GetAttributeRegex(string attributeName) => $@"\b{attributeName}\s*=\s*[""']?([^""'\s>]*)[""']?"; private Regex GetAttributeRegex(string attributeName) =>
_attributeRegexes.GetOrAdd(
attributeName,
name => new Regex($@"\b{name}\s*=\s*[""']?([^""'\s>]*)[""']?", RegexOptions.IgnoreCase | RegexOptions.Compiled));
} }
} }