lsm/Orchard
1
0
Fork 0
mirror of https://github.com/OrchardCMS/Orchard.git synced 2025-10-15 19:54:57 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

#20403: Custom forms performance fix. Form types should be fetched from available type definitions, not by scanning all content items.

Browse Source 
Work Item: 20403
This commit is contained in:
Piotr Szmyd
2014-01-06 19:12:44 +01:00
parent 87ccd59dc0
commit 068691af11
1 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Orchard.Web/Modules/Orchard.CustomForms/Permissions.cs
View File

@@ -15,25 +15,19 @@ namespace Orchard.CustomForms {
public static readonly Permission ManageForms = new Permission { Description = "Manage custom forms", Name = "ManageForms" };
private readonly IContentDefinitionManager _contentDefinitionManager;
private readonly IContentManager _contentManager;
public virtual Feature Feature { get; set; }
public Permissions(IContentDefinitionManager contentDefinitionManager, IContentManager contentManager) {
public Permissions(IContentDefinitionManager contentDefinitionManager) {
_contentDefinitionManager = contentDefinitionManager;
_contentManager = contentManager;
}
public IEnumerable<Permission> GetPermissions() {
// manage rights only for Creatable types
var formTypes = _contentManager.Query<CustomFormPart>().List().Select(x => x.ContentType).Distinct();
foreach (var contentType in formTypes) {
var typeDefinition = _contentDefinitionManager.GetTypeDefinition(contentType);
if(typeDefinition == null) {
continue;
}
var formTypeDefinitions = _contentDefinitionManager
.ListTypeDefinitions()
.Where(x => x.Parts.Any(xx => xx.PartDefinition.Name == typeof(CustomFormPart).Name));
foreach (var typeDefinition in formTypeDefinitions) {
yield return CreateSubmitPermission(typeDefinition);
}