From 16b2b375319b4ce36689fa54b33737c657f63c68 Mon Sep 17 00:00:00 2001 From: Louis DeJardin Date: Tue, 27 Jul 2010 15:42:29 -0700 Subject: [PATCH] Protect menu item comparer from null route values Prevents a null ysod in rare cases --HG-- branch : dev --- src/Orchard/UI/Navigation/MenuItemComparer.cs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/Orchard/UI/Navigation/MenuItemComparer.cs b/src/Orchard/UI/Navigation/MenuItemComparer.cs index 256596f1e..2b4ee728b 100644 --- a/src/Orchard/UI/Navigation/MenuItemComparer.cs +++ b/src/Orchard/UI/Navigation/MenuItemComparer.cs @@ -40,7 +40,12 @@ namespace Orchard.UI.Navigation { } if (obj.RouteValues != null) { foreach (var item in obj.RouteValues) { - hash ^= item.Key.GetHashCode() ^ item.Value.GetHashCode(); + if (item.Key != null) { + hash ^= item.Key.GetHashCode(); + } + if (item.Value != null) { + hash ^= item.Value.GetHashCode(); + } } } return hash;