lsm/Orchard
1
0
Fork 0
mirror of https://github.com/OrchardCMS/Orchard.git synced 2025-11-24 08:46:48 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Handle the case where a form sends more than one attempted value for a boolean (#8416)

Browse Source
This commit is contained in:
Matteo Piovanelli
2020-09-18 08:40:56 +02:00
committed by GitHub
parent f67e6b3695
commit 66a611fbf3
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Orchard/Mvc/ModelBinders/BooleanBinderProvider.cs
View File

@@ -1,6 +1,7 @@
using System;
using System.Collections.Generic;
using System.Web.Mvc;
using System.Linq;
namespace Orchard.Mvc.ModelBinders {
public class BooleanBinderProvider : IModelBinderProvider, IModelBinder {
@@ -17,7 +18,20 @@ namespace Orchard.Mvc.ModelBinders {
public object BindModel(ControllerContext controllerContext, ModelBindingContext bindingContext) {
var value = false;
try {
value = Convert.ToBoolean(bindingContext.ValueProvider.GetValue(bindingContext.ModelName).AttemptedValue);
var attemptedValues = bindingContext.ValueProvider
.GetValue(bindingContext.ModelName)
.AttemptedValue
// for bool, AttemptedValue may be "true,false" because in the form there may be
// a checkbox and an hidden input.
.Split(new char[] { ',' });
value = attemptedValues
.Select(v => Convert.ToBoolean(v))
// This Aggregate operation works because the "true" is normally only there when
// the checkbox was selected, while the false is always there thanks to the hidden
// input.
.Aggregate((a, b) => a || b);
// The steps above don't affect binding booleans from any where other than a form,
// because those won't give us here a list of possible values to aggregate.
} catch {
bindingContext.ModelState.AddModelError(bindingContext.ModelName, new FormatException());
}