From 7e6b70e7b81453106666c7a1b51e1db5370b9814 Mon Sep 17 00:00:00 2001 From: Ryan Kelso Date: Fri, 9 Oct 2015 14:23:30 -0400 Subject: [PATCH] Fixes Issue #5885 This should fix issue #5885, the DisplayAlias not having length validated. I arbitrarily set it to 1850 for the simple fact that, while the database can hold a 2048 character DisplayAlias, a URL should not be longer than ~2000 characters (per http://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers ). If the DisplayAlias is 2048, it's already over the limit and that's not the entire URL for the page, this gives some buffer room for domains. --- .../Modules/Orchard.Autoroute/Drivers/AutoroutePartDriver.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Orchard.Web/Modules/Orchard.Autoroute/Drivers/AutoroutePartDriver.cs b/src/Orchard.Web/Modules/Orchard.Autoroute/Drivers/AutoroutePartDriver.cs index a60447e97..88fee952d 100644 --- a/src/Orchard.Web/Modules/Orchard.Autoroute/Drivers/AutoroutePartDriver.cs +++ b/src/Orchard.Web/Modules/Orchard.Autoroute/Drivers/AutoroutePartDriver.cs @@ -144,6 +144,10 @@ namespace Orchard.Autoroute.Drivers { if (!_autorouteService.IsPathValid(part.DisplayAlias)) { updater.AddModelError("CurrentUrl", T("Please do not use any of the following characters in your permalink: \":\", \"?\", \"#\", \"[\", \"]\", \"@\", \"!\", \"$\", \"&\", \"'\", \"(\", \")\", \"*\", \"+\", \",\", \";\", \"=\", \", \"<\", \">\", \"\\\", \"|\", \"%\", \".\". No spaces are allowed (please use dashes or underscores instead).")); } + + if (part.DisplayAlias != null && part.DisplayAlias.Length > 1850){ + updater.AddModelError("CurrentUrl", T("Your Display Alias is too long. The Display Alias can only be up to 1,850 characters.")); + } // Mark the content item to be the homepage. Once this content isp ublished, the home alias will be updated to point to this content item. part.PromoteToHomePage = viewModel.PromoteToHomePage;