Renaming ShellTopologyDescriptor to ShellDescriptor

More accurate and terse
Associated tests, interface, component names changed to follow suit

--HG--
branch : dev
This commit is contained in:
Louis DeJardin
2010-04-19 13:51:15 -07:00
parent 7c793f4e0a
commit 8d78fee02b
9 changed files with 116 additions and 107 deletions

View File

@@ -11,9 +11,9 @@ using Orchard.Events;
namespace Orchard.Tests.Modules.Settings.Topology {
[TestFixture]
public class TopologyDescriptorManagerTests : DatabaseEnabledTestsBase {
public class ShellDescriptorManagerTests : DatabaseEnabledTestsBase {
public override void Register(ContainerBuilder builder) {
builder.RegisterType<TopologyDescriptorManager>().As<ITopologyDescriptorManager>();
builder.RegisterType<ShellDescriptorManager>().As<IShellDescriptorManager>();
builder.RegisterType<StubEventBus>().As<IEventBus>().SingleInstance();
}
@@ -40,104 +40,104 @@ namespace Orchard.Tests.Modules.Settings.Topology {
[Test]
public void TopologyShouldBeNullWhenItsNotInitialized() {
var manager = _container.Resolve<ITopologyDescriptorManager>();
var topology = manager.GetTopologyDescriptor();
var manager = _container.Resolve<IShellDescriptorManager>();
var topology = manager.GetShellDescriptor();
Assert.That(topology, Is.Null);
}
[Test]
public void PriorSerialNumberOfZeroIsAcceptableForInitialUpdateAndSerialNumberIsNonzeroAfterwards() {
var manager = _container.Resolve<ITopologyDescriptorManager>();
manager.UpdateTopologyDescriptor(
var manager = _container.Resolve<IShellDescriptorManager>();
manager.UpdateShellDescriptor(
0,
Enumerable.Empty<TopologyFeature>(),
Enumerable.Empty<TopologyParameter>());
Enumerable.Empty<ShellFeature>(),
Enumerable.Empty<ShellParameter>());
var topology = manager.GetTopologyDescriptor();
var topology = manager.GetShellDescriptor();
Assert.That(topology, Is.Not.Null);
Assert.That(topology.SerialNumber, Is.Not.EqualTo(0));
}
[Test]
public void NonZeroInitialUpdateThrowsInvalidOperationException() {
var manager = _container.Resolve<ITopologyDescriptorManager>();
Assert.Throws<InvalidOperationException>(() => manager.UpdateTopologyDescriptor(
var manager = _container.Resolve<IShellDescriptorManager>();
Assert.Throws<InvalidOperationException>(() => manager.UpdateShellDescriptor(
1,
Enumerable.Empty<TopologyFeature>(),
Enumerable.Empty<TopologyParameter>()));
Enumerable.Empty<ShellFeature>(),
Enumerable.Empty<ShellParameter>()));
}
[Test]
public void OnlyCorrectSerialNumberOnLaterUpdatesDoesNotThrowException() {
var manager = _container.Resolve<ITopologyDescriptorManager>();
manager.UpdateTopologyDescriptor(
var manager = _container.Resolve<IShellDescriptorManager>();
manager.UpdateShellDescriptor(
0,
Enumerable.Empty<TopologyFeature>(),
Enumerable.Empty<TopologyParameter>());
Enumerable.Empty<ShellFeature>(),
Enumerable.Empty<ShellParameter>());
var topology = manager.GetTopologyDescriptor();
var topology = manager.GetShellDescriptor();
Assert.That(topology.SerialNumber, Is.Not.EqualTo(0));
Assert.Throws<InvalidOperationException>(() => manager.UpdateTopologyDescriptor(
Assert.Throws<InvalidOperationException>(() => manager.UpdateShellDescriptor(
0,
Enumerable.Empty<TopologyFeature>(),
Enumerable.Empty<TopologyParameter>()));
Enumerable.Empty<ShellFeature>(),
Enumerable.Empty<ShellParameter>()));
Assert.Throws<InvalidOperationException>(() => manager.UpdateTopologyDescriptor(
Assert.Throws<InvalidOperationException>(() => manager.UpdateShellDescriptor(
topology.SerialNumber + 665321,
Enumerable.Empty<TopologyFeature>(),
Enumerable.Empty<TopologyParameter>()));
Enumerable.Empty<ShellFeature>(),
Enumerable.Empty<ShellParameter>()));
manager.UpdateTopologyDescriptor(
manager.UpdateShellDescriptor(
topology.SerialNumber,
Enumerable.Empty<TopologyFeature>(),
Enumerable.Empty<TopologyParameter>());
Enumerable.Empty<ShellFeature>(),
Enumerable.Empty<ShellParameter>());
var topology2 = manager.GetTopologyDescriptor();
var topology2 = manager.GetShellDescriptor();
Assert.That(topology2.SerialNumber, Is.Not.EqualTo(0));
Assert.That(topology2.SerialNumber, Is.Not.EqualTo(topology.SerialNumber));
Assert.Throws<InvalidOperationException>(() => manager.UpdateTopologyDescriptor(
Assert.Throws<InvalidOperationException>(() => manager.UpdateShellDescriptor(
0,
Enumerable.Empty<TopologyFeature>(),
Enumerable.Empty<TopologyParameter>()));
Enumerable.Empty<ShellFeature>(),
Enumerable.Empty<ShellParameter>()));
Assert.Throws<InvalidOperationException>(() => manager.UpdateTopologyDescriptor(
Assert.Throws<InvalidOperationException>(() => manager.UpdateShellDescriptor(
topology.SerialNumber,
Enumerable.Empty<TopologyFeature>(),
Enumerable.Empty<TopologyParameter>()));
Enumerable.Empty<ShellFeature>(),
Enumerable.Empty<ShellParameter>()));
manager.UpdateTopologyDescriptor(
manager.UpdateShellDescriptor(
topology2.SerialNumber,
Enumerable.Empty<TopologyFeature>(),
Enumerable.Empty<TopologyParameter>());
Enumerable.Empty<ShellFeature>(),
Enumerable.Empty<ShellParameter>());
Assert.Throws<InvalidOperationException>(() => manager.UpdateTopologyDescriptor(
Assert.Throws<InvalidOperationException>(() => manager.UpdateShellDescriptor(
topology2.SerialNumber,
Enumerable.Empty<TopologyFeature>(),
Enumerable.Empty<TopologyParameter>()));
Enumerable.Empty<ShellFeature>(),
Enumerable.Empty<ShellParameter>()));
}
[Test]
public void SuccessfulUpdateRaisesAnEvent() {
var manager = _container.Resolve<ITopologyDescriptorManager>();
var manager = _container.Resolve<IShellDescriptorManager>();
var eventBus = _container.Resolve<IEventBus>() as StubEventBus;
Assert.That(eventBus.LastMessageName, Is.Null);
Assert.Throws<InvalidOperationException>(() => manager.UpdateTopologyDescriptor(
Assert.Throws<InvalidOperationException>(() => manager.UpdateShellDescriptor(
5,
Enumerable.Empty<TopologyFeature>(),
Enumerable.Empty<TopologyParameter>()));
Enumerable.Empty<ShellFeature>(),
Enumerable.Empty<ShellParameter>()));
Assert.That(eventBus.LastMessageName, Is.Null);
manager.UpdateTopologyDescriptor(
manager.UpdateShellDescriptor(
0,
Enumerable.Empty<TopologyFeature>(),
Enumerable.Empty<TopologyParameter>());
Enumerable.Empty<ShellFeature>(),
Enumerable.Empty<ShellParameter>());
Assert.That(eventBus.LastMessageName, Is.EqualTo(typeof(ITopologyDescriptorManager).FullName + ".UpdateTopologyDescriptor"));
Assert.That(eventBus.LastMessageName, Is.EqualTo(typeof(IShellDescriptorManager).FullName + ".UpdateShellDescriptor"));
}
}
}