diff --git a/src/Orchard.Web/Core/Common/Permissions.cs b/src/Orchard.Web/Core/Common/Permissions.cs index 4a1e292ec..668125cd0 100644 --- a/src/Orchard.Web/Core/Common/Permissions.cs +++ b/src/Orchard.Web/Core/Common/Permissions.cs @@ -9,7 +9,7 @@ namespace Orchard.Core.Common { public virtual Feature Feature { get; set; } public IEnumerable GetPermissions() { - return new Permission[] { + return new[] { ChangeOwner, }; } diff --git a/src/Orchard.Web/Core/Settings/Permissions.cs b/src/Orchard.Web/Core/Settings/Permissions.cs index b96cf1c3c..f587f8748 100644 --- a/src/Orchard.Web/Core/Settings/Permissions.cs +++ b/src/Orchard.Web/Core/Settings/Permissions.cs @@ -10,7 +10,7 @@ namespace Orchard.Core.Settings { public virtual Feature Feature { get; set; } public IEnumerable GetPermissions() { - return new Permission[] { + return new[] { ManageSettings, ChangeSuperuser, }; diff --git a/src/Orchard.Web/Modules/Orchard.Blogs/Permissions.cs b/src/Orchard.Web/Modules/Orchard.Blogs/Permissions.cs index 02596612e..e2cadb39e 100644 --- a/src/Orchard.Web/Modules/Orchard.Blogs/Permissions.cs +++ b/src/Orchard.Web/Modules/Orchard.Blogs/Permissions.cs @@ -19,7 +19,7 @@ namespace Orchard.Blogs { public virtual Feature Feature { get; set; } public IEnumerable GetPermissions() { - return new Permission[] { + return new[] { ManageBlogs, EditBlogPost, EditOthersBlogPost, diff --git a/src/Orchard.Web/Modules/Orchard.Comments/Permissions.cs b/src/Orchard.Web/Modules/Orchard.Comments/Permissions.cs index d98e195dd..a5e49a36e 100644 --- a/src/Orchard.Web/Modules/Orchard.Comments/Permissions.cs +++ b/src/Orchard.Web/Modules/Orchard.Comments/Permissions.cs @@ -14,7 +14,7 @@ namespace Orchard.Comments { public virtual Feature Feature { get; set; } public IEnumerable GetPermissions() { - return new Permission[] { + return new[] { AddComment, EnableComment, CloseComment, diff --git a/src/Orchard.Web/Modules/Orchard.Experimental/Permissions.cs b/src/Orchard.Web/Modules/Orchard.Experimental/Permissions.cs index 652ea5c2c..4f7f6a694 100644 --- a/src/Orchard.Web/Modules/Orchard.Experimental/Permissions.cs +++ b/src/Orchard.Web/Modules/Orchard.Experimental/Permissions.cs @@ -10,7 +10,7 @@ namespace Orchard.Experimental { public virtual Feature Feature { get; set; } public IEnumerable GetPermissions() { - return new Permission[] { + return new[] { DebugShowAllMenuItems, }; } diff --git a/src/Orchard.Web/Modules/Orchard.Localization/Controllers/AdminController.cs b/src/Orchard.Web/Modules/Orchard.Localization/Controllers/AdminController.cs index 06cbe4f94..77c1a3ba1 100644 --- a/src/Orchard.Web/Modules/Orchard.Localization/Controllers/AdminController.cs +++ b/src/Orchard.Web/Modules/Orchard.Localization/Controllers/AdminController.cs @@ -99,7 +99,7 @@ namespace Orchard.Localization.Controllers { var model = new AddLocalizationViewModel(); TryUpdateModel(model); - ContentItem contentItemTranslation = null; + ContentItem contentItemTranslation; var existingTranslation = _localizationService.GetLocalizedContentItem(contentItem, model.SelectedCulture); if (existingTranslation != null) { // edit existing diff --git a/src/Orchard.Web/Modules/Orchard.Media/Permissions.cs b/src/Orchard.Web/Modules/Orchard.Media/Permissions.cs index 3ddfcbd6f..76fb3f4c7 100644 --- a/src/Orchard.Web/Modules/Orchard.Media/Permissions.cs +++ b/src/Orchard.Web/Modules/Orchard.Media/Permissions.cs @@ -10,7 +10,7 @@ namespace Orchard.Media { public virtual Feature Feature { get; set; } public IEnumerable GetPermissions() { - return new Permission[] { + return new[] { ManageMediaFiles, UploadMediaFiles, }; diff --git a/src/Orchard.Web/Modules/Orchard.Roles/Permissions.cs b/src/Orchard.Web/Modules/Orchard.Roles/Permissions.cs index 62a924415..d55947cac 100644 --- a/src/Orchard.Web/Modules/Orchard.Roles/Permissions.cs +++ b/src/Orchard.Web/Modules/Orchard.Roles/Permissions.cs @@ -12,7 +12,7 @@ namespace Orchard.Roles { public virtual Feature Feature { get; set; } public IEnumerable GetPermissions() { - return new Permission[] { + return new[] { ManageRoles, ApplyRoles, }; diff --git a/src/Orchard.Web/Modules/Orchard.Scripting/Compiler/Tokenizer.cs b/src/Orchard.Web/Modules/Orchard.Scripting/Compiler/Tokenizer.cs index 070d17136..c77c6e8c7 100644 --- a/src/Orchard.Web/Modules/Orchard.Scripting/Compiler/Tokenizer.cs +++ b/src/Orchard.Web/Modules/Orchard.Scripting/Compiler/Tokenizer.cs @@ -59,10 +59,10 @@ namespace Orchard.Scripting.Compiler { if (IsDigitCharacter(ch)) { return LexInteger(); } - else if (IsIdentifierCharacter(ch)) { + if (IsIdentifierCharacter(ch)) { return LexIdentifierOrKeyword(); } - else if (IsWhitespaceCharacter(ch)) { + if (IsWhitespaceCharacter(ch)) { NextCharacter(); continue; } @@ -163,18 +163,18 @@ namespace Orchard.Scripting.Compiler { } } - private bool IsWhitespaceCharacter(char character) { + private static bool IsWhitespaceCharacter(char character) { return char.IsWhiteSpace(character); } - private bool IsIdentifierCharacter(char ch) { + private static bool IsIdentifierCharacter(char ch) { return (ch >= 'a' && ch <= 'z') || (ch >= 'A' && ch <= 'Z') || (ch == '_'); } - private bool IsDigitCharacter(char ch) { + private static bool IsDigitCharacter(char ch) { return ch >= '0' && ch <= '9'; } @@ -193,7 +193,7 @@ namespace Orchard.Scripting.Compiler { return CreateToken(TokenKind.SingleQuotedStringLiteral, _stringBuilder.ToString()); } // backslash notation - else if (Character() == '\\') { + if (Character() == '\\') { NextCharacter(); if (Eof()) @@ -210,7 +210,7 @@ namespace Orchard.Scripting.Compiler { _stringBuilder.Append(Character()); } } - // Regular character in string + // Regular character in string else { _stringBuilder.Append(Character()); } @@ -232,7 +232,7 @@ namespace Orchard.Scripting.Compiler { return CreateToken(TokenKind.StringLiteral, _stringBuilder.ToString()); } // backslash notation - else if (Character() == '\\') { + if (Character() == '\\') { NextCharacter(); if (Eof()) @@ -240,7 +240,7 @@ namespace Orchard.Scripting.Compiler { _stringBuilder.Append(Character()); } - // Regular character in string + // Regular character in string else { _stringBuilder.Append(Character()); } diff --git a/src/Orchard.Web/Modules/Orchard.Tags/Permissions.cs b/src/Orchard.Web/Modules/Orchard.Tags/Permissions.cs index e603b4f7e..0c2a704de 100644 --- a/src/Orchard.Web/Modules/Orchard.Tags/Permissions.cs +++ b/src/Orchard.Web/Modules/Orchard.Tags/Permissions.cs @@ -11,7 +11,7 @@ namespace Orchard.Tags { public virtual Feature Feature { get; set; } public IEnumerable GetPermissions() { - return new Permission[] { + return new[] { ManageTags, CreateTag, ApplyTag, diff --git a/src/Orchard.Web/Modules/Orchard.Themes/Permissions.cs b/src/Orchard.Web/Modules/Orchard.Themes/Permissions.cs index 4a9f87209..867e0b7c5 100644 --- a/src/Orchard.Web/Modules/Orchard.Themes/Permissions.cs +++ b/src/Orchard.Web/Modules/Orchard.Themes/Permissions.cs @@ -10,7 +10,7 @@ namespace Orchard.Themes { public virtual Feature Feature { get; set; } public IEnumerable GetPermissions() { - return new Permission[] { + return new[] { ManageThemes, ApplyTheme, }; diff --git a/src/Orchard.Web/Modules/Orchard.Users/Commands/UserCommands.cs b/src/Orchard.Web/Modules/Orchard.Users/Commands/UserCommands.cs index e395c89fb..61103becc 100644 --- a/src/Orchard.Web/Modules/Orchard.Users/Commands/UserCommands.cs +++ b/src/Orchard.Web/Modules/Orchard.Users/Commands/UserCommands.cs @@ -1,5 +1,4 @@ using Orchard.Commands; -using Orchard.ContentManagement; using Orchard.Security; using Orchard.Users.Services; @@ -9,7 +8,6 @@ namespace Orchard.Users.Commands { private readonly IUserService _userService; public UserCommands( - IContentManager contentManager, IMembershipService membershipService, IUserService userService) { _membershipService = membershipService; @@ -43,8 +41,8 @@ namespace Orchard.Users.Commands { var user = _membershipService.CreateUser(new CreateUserParams(UserName, Password, Email, null, null, true)); if (user != null) return T("User created successfully").ToString(); - else - return T("The authentication provider returned an error").ToString(); + + return T("The authentication provider returned an error").ToString(); } int MinPasswordLength { diff --git a/src/Orchard.Web/Modules/Orchard.Users/Controllers/AccountController.cs b/src/Orchard.Web/Modules/Orchard.Users/Controllers/AccountController.cs index 5491cf92f..a638e1118 100644 --- a/src/Orchard.Web/Modules/Orchard.Users/Controllers/AccountController.cs +++ b/src/Orchard.Web/Modules/Orchard.Users/Controllers/AccountController.cs @@ -132,9 +132,8 @@ namespace Orchard.Users.Controllers { _authenticationService.SignIn(user, false /* createPersistentCookie */); return Redirect("~/"); } - else { - ModelState.AddModelError("_FORM", T(ErrorCodeToString(/*createStatus*/MembershipCreateStatus.ProviderError))); - } + + ModelState.AddModelError("_FORM", T(ErrorCodeToString(/*createStatus*/MembershipCreateStatus.ProviderError))); } // If we got this far, something failed, redisplay form @@ -196,11 +195,10 @@ namespace Orchard.Users.Controllers { _membershipService.SetPassword(validated, newPassword); return RedirectToAction("ChangePasswordSuccess"); } - else { - ModelState.AddModelError("_FORM", - T("The current password is incorrect or the new password is invalid.")); - return ChangePassword(); - } + + ModelState.AddModelError("_FORM", + T("The current password is incorrect or the new password is invalid.")); + return ChangePassword(); } catch { ModelState.AddModelError("_FORM", T("The current password is incorrect or the new password is invalid.")); diff --git a/src/Orchard.Web/Modules/Orchard.Users/Permissions.cs b/src/Orchard.Web/Modules/Orchard.Users/Permissions.cs index e3e3695f2..9b58052d2 100644 --- a/src/Orchard.Web/Modules/Orchard.Users/Permissions.cs +++ b/src/Orchard.Web/Modules/Orchard.Users/Permissions.cs @@ -11,7 +11,7 @@ namespace Orchard.Users { public virtual Feature Feature { get; set; } public IEnumerable GetPermissions() { - return new Permission[] { + return new[] { ManageUsers, }; } diff --git a/src/Orchard.Web/Modules/Orchard.Widgets/Permissions.cs b/src/Orchard.Web/Modules/Orchard.Widgets/Permissions.cs index 22ced69a4..949ef9ded 100644 --- a/src/Orchard.Web/Modules/Orchard.Widgets/Permissions.cs +++ b/src/Orchard.Web/Modules/Orchard.Widgets/Permissions.cs @@ -9,7 +9,7 @@ namespace Orchard.Widgets { public virtual Feature Feature { get; set; } public IEnumerable GetPermissions() { - return new Permission[] { + return new[] { ManageWidgets, }; } diff --git a/src/Orchard/Commands/DefaultCommandManager.cs b/src/Orchard/Commands/DefaultCommandManager.cs index 2bce1da1a..3720bce0b 100644 --- a/src/Orchard/Commands/DefaultCommandManager.cs +++ b/src/Orchard/Commands/DefaultCommandManager.cs @@ -33,10 +33,8 @@ namespace Orchard.Commands { throw new OrchardCoreException(T("Multiple commands found matching arguments \"{0}\". Commands available: {1}.", commandMatch, commandList)); } - else { - throw new OrchardCoreException(T("No command found matching arguments \"{0}\". Commands available: {1}.", - commandMatch, commandList)); - } + throw new OrchardCoreException(T("No command found matching arguments \"{0}\". Commands available: {1}.", + commandMatch, commandList)); } } diff --git a/src/Orchard/Data/Migration/DataMigrationManager.cs b/src/Orchard/Data/Migration/DataMigrationManager.cs index 8b9bbc410..7a53ed37a 100644 --- a/src/Orchard/Data/Migration/DataMigrationManager.cs +++ b/src/Orchard/Data/Migration/DataMigrationManager.cs @@ -166,7 +166,7 @@ namespace Orchard.Data.Migration { .ToList(); foreach (var migration in migrations.OfType()) { - migration.SchemaBuilder = new SchemaBuilder(_interpreter, migration.Feature.Descriptor.Id, (s) => s.Replace(".", "_") + "_"); + migration.SchemaBuilder = new SchemaBuilder(_interpreter, migration.Feature.Descriptor.Id, s => s.Replace(".", "_") + "_"); migration.ContentDefinitionManager = _contentDefinitionManager; } diff --git a/src/Orchard/Data/Migration/Generator/SchemaCommandGenerator.cs b/src/Orchard/Data/Migration/Generator/SchemaCommandGenerator.cs index 9c7d1447b..b3941bc0c 100644 --- a/src/Orchard/Data/Migration/Generator/SchemaCommandGenerator.cs +++ b/src/Orchard/Data/Migration/Generator/SchemaCommandGenerator.cs @@ -107,7 +107,7 @@ namespace Orchard.Data.Migration.Generator { if ( columnCopy.IsLengthDefined() - && new DbType[] { DbType.StringFixedLength, DbType.String, DbType.AnsiString, DbType.AnsiStringFixedLength }.Contains(sqlType.DbType) + && new[] { DbType.StringFixedLength, DbType.String, DbType.AnsiString, DbType.AnsiStringFixedLength }.Contains(sqlType.DbType) && columnCopy.Length != Column.DefaultLength) { action.WithLength(columnCopy.Length); } diff --git a/src/Orchard/Data/Migration/Schema/SchemaUtils.cs b/src/Orchard/Data/Migration/Schema/SchemaUtils.cs index e25ddd8a1..f9369b124 100644 --- a/src/Orchard/Data/Migration/Schema/SchemaUtils.cs +++ b/src/Orchard/Data/Migration/Schema/SchemaUtils.cs @@ -6,7 +6,7 @@ namespace Orchard.Data.Migration.Schema { [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Usage", "CA1806:DoNotIgnoreMethodResults", MessageId = "System.Enum.TryParse(System.String,System.Boolean,System.Data.DbType@)")] public static DbType ToDbType(Type type) { DbType dbType; - switch ( System.Type.GetTypeCode(type) ) { + switch ( Type.GetTypeCode(type) ) { case TypeCode.String: dbType = DbType.String; break; diff --git a/src/Orchard/Data/Providers/SqlServerDataServicesProvider.cs b/src/Orchard/Data/Providers/SqlServerDataServicesProvider.cs index 0f0d80b8b..acce27bd0 100644 --- a/src/Orchard/Data/Providers/SqlServerDataServicesProvider.cs +++ b/src/Orchard/Data/Providers/SqlServerDataServicesProvider.cs @@ -20,9 +20,7 @@ namespace Orchard.Data.Providers { if (string.IsNullOrEmpty(_connectionString)) { throw new NotImplementedException(); } - else { - persistence = persistence.ConnectionString(_connectionString); - } + persistence = persistence.ConnectionString(_connectionString); return persistence; } } diff --git a/src/Orchard/Localization/LocalizedString.cs b/src/Orchard/Localization/LocalizedString.cs index d103393e3..6b87057d3 100644 --- a/src/Orchard/Localization/LocalizedString.cs +++ b/src/Orchard/Localization/LocalizedString.cs @@ -22,8 +22,7 @@ namespace Orchard.Localization { public static LocalizedString TextOrDefault(string text, LocalizedString defaultValue) { if (string.IsNullOrEmpty(text)) return defaultValue; - else - return new LocalizedString(text); + return new LocalizedString(text); } public string Scope { diff --git a/src/Orchard/Mvc/Html/HtmlHelperExtensions.cs b/src/Orchard/Mvc/Html/HtmlHelperExtensions.cs index d1c9def0c..03f0750e6 100644 --- a/src/Orchard/Mvc/Html/HtmlHelperExtensions.cs +++ b/src/Orchard/Mvc/Html/HtmlHelperExtensions.cs @@ -295,7 +295,7 @@ namespace Orchard.Mvc.Html { try { return htmlHelper.AntiForgeryToken(siteSalt); } - catch(System.Web.Mvc.HttpAntiForgeryException) { + catch(HttpAntiForgeryException) { // Work-around an issue in MVC 2: If the browser sends a cookie that is not // coming from this server (this can happen if the user didn't close their browser // while the application server configuration changed), clear it up diff --git a/src/Orchard/Mvc/OrchardControllerFactory.cs b/src/Orchard/Mvc/OrchardControllerFactory.cs index c66ab2d7e..66342d054 100644 --- a/src/Orchard/Mvc/OrchardControllerFactory.cs +++ b/src/Orchard/Mvc/OrchardControllerFactory.cs @@ -45,7 +45,7 @@ namespace Orchard.Mvc { return null; } - protected override IController GetControllerInstance(RequestContext requestContext, System.Type controllerType) { + protected override IController GetControllerInstance(RequestContext requestContext, Type controllerType) { IController controller; var workContext = requestContext.GetWorkContext(); if (TryResolve(workContext, controllerType, out controller)) { diff --git a/src/Orchard/Security/StandardPermissions.cs b/src/Orchard/Security/StandardPermissions.cs index 2a9c2e77c..f4123fe6d 100644 --- a/src/Orchard/Security/StandardPermissions.cs +++ b/src/Orchard/Security/StandardPermissions.cs @@ -28,7 +28,7 @@ namespace Orchard.Security { } public IEnumerable GetPermissions() { - return new Permission[] { + return new[] { AccessAdminPanel, AccessFrontEnd, }; diff --git a/src/Orchard/WorkContextExtensions.cs b/src/Orchard/WorkContextExtensions.cs index 1c1b6d690..6ee6d9407 100644 --- a/src/Orchard/WorkContextExtensions.cs +++ b/src/Orchard/WorkContextExtensions.cs @@ -52,7 +52,7 @@ namespace Orchard { if (controllerContext == null) return null; - return WorkContextExtensions.GetWorkContext(controllerContext.RequestContext); + return GetWorkContext(controllerContext.RequestContext); } public static IWorkContextScope CreateWorkContextScope(this ILifetimeScope lifetimeScope, HttpContextBase httpContext) {