From d75c245c30c9b50c58b17371a1bb4ead80af5e4b Mon Sep 17 00:00:00 2001
From: Sebastien Ros <none@none>
Date: Wed, 24 Apr 2013 10:43:17 -0700
Subject: [PATCH] Preventing hints from being rendered if they are empty

--HG--
branch : 1.x
---
 .../Views/EditorTemplates/Fields.Common.Text.Edit.cshtml       | 2 ++
 .../Views/EditorTemplates/Fields/Boolean.Edit.cshtml           | 2 ++
 .../Views/EditorTemplates/Fields/DateTime.Edit.cshtml          | 2 ++
 .../Views/EditorTemplates/Fields/Enumeration.Edit.cshtml       | 2 ++
 .../Views/EditorTemplates/Fields/Input.Edit.cshtml             | 2 ++
 .../Views/EditorTemplates/Fields/Link.Edit.cshtml              | 3 ++-
 .../Views/EditorTemplates/Fields/MediaGallery.Edit.cshtml      | 2 ++
 .../Views/EditorTemplates/Fields/MediaPicker.Edit.cshtml       | 3 ++-
 .../Views/EditorTemplates/Fields/Numeric.Edit.cshtml           | 2 ++
 9 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/src/Orchard.Web/Core/Common/Views/EditorTemplates/Fields.Common.Text.Edit.cshtml b/src/Orchard.Web/Core/Common/Views/EditorTemplates/Fields.Common.Text.Edit.cshtml
index 992339558..d1a769a9f 100644
--- a/src/Orchard.Web/Core/Common/Views/EditorTemplates/Fields.Common.Text.Edit.cshtml
+++ b/src/Orchard.Web/Core/Common/Views/EditorTemplates/Fields.Common.Text.Edit.cshtml
@@ -9,5 +9,7 @@
     else {
         @Display.Body_Editor(Text: Model.Text, EditorFlavor: Model.Settings.Flavor)
     }
+    @if (HasText(Model.Settings.Hint)) {
     <span class="hint">@Model.Settings.Hint</span>
+    }
 </fieldset>
diff --git a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Boolean.Edit.cshtml b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Boolean.Edit.cshtml
index 5d213757e..197678026 100644
--- a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Boolean.Edit.cshtml
+++ b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Boolean.Edit.cshtml
@@ -40,5 +40,7 @@
            break;
     }
     @Html.ValidationMessageFor(m => m.Value)
+    @if (HasText(settings.Hint)) {
     <span class="hint">@settings.Hint</span>
+    }
 </fieldset>
diff --git a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/DateTime.Edit.cshtml b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/DateTime.Edit.cshtml
index 8f8fffb22..2fe0a5fb5 100644
--- a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/DateTime.Edit.cshtml
+++ b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/DateTime.Edit.cshtml
@@ -24,7 +24,9 @@
         }
         @if(Model.ShowDate) { <text>@Html.ValidationMessageFor(m=>m.Date)</text> } @if(Model.ShowTime) { <text>@Html.ValidationMessageFor(m=>m.Time)</text> }
     
+        @if (HasText(Model.Hint)) {
         <span class="hint">@Model.Hint</span>
+        }
     </fieldset>
 
 @using(Script.Foot()) {
diff --git a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Enumeration.Edit.cshtml b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Enumeration.Edit.cshtml
index a4aab0b47..b5fec779d 100644
--- a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Enumeration.Edit.cshtml
+++ b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Enumeration.Edit.cshtml
@@ -43,5 +43,7 @@
     }
     
     @Html.ValidationMessageFor(m => m.SelectedValues)
+    @if (HasText(settings.Hint)) {
     <span class="hint">@settings.Hint</span>
+    }
 </fieldset>
diff --git a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Input.Edit.cshtml b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Input.Edit.cshtml
index 5f0624dae..0ae156b4c 100644
--- a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Input.Edit.cshtml
+++ b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Input.Edit.cshtml
@@ -8,5 +8,7 @@
     <label for="@Html.FieldIdFor(m => m.Value)" @if(settings.Required) { <text>class="required"</text> }>@Model.DisplayName</label>
     <input type="@settings.Type.ToString().ToLower()" id="@Html.FieldIdFor(m => m.Value)" name="@Html.FieldNameFor(m => m.Value)"@if(!String.IsNullOrWhiteSpace(settings.Title)) {<text> title="@settings.Title"</text>} value="@Model.Value"@if(settings.Required) {<text> required="required"</text> }@if(settings.AutoFocus) {<text> autofocus="autofocus"</text> }@if(settings.AutoComplete) {<text> autocomplete="on"</text> }@if(!string.IsNullOrWhiteSpace(settings.Placeholder)) {<text> placeholder="@settings.Placeholder"</text>}@if(!string.IsNullOrEmpty(settings.Pattern)) {<text> pattern="@settings.Pattern"</text>}@if(!string.IsNullOrEmpty(settings.EditorCssClass)) {<text> class="@settings.EditorCssClass"</text>} else {<text> class="textMedium"</text>} @if(settings.MaxLength > 1) {<text> maxlength="@settings.MaxLength.ToString()"</text>} />
     @Html.ValidationMessageFor(m => m.Value)
+    @if (HasText(settings.Hint)) {
     <span class="hint">@settings.Hint</span>
+    }
 </fieldset>
diff --git a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Link.Edit.cshtml b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Link.Edit.cshtml
index cc6750fac..d57eef370 100644
--- a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Link.Edit.cshtml
+++ b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Link.Edit.cshtml
@@ -17,8 +17,9 @@
 }
 <fieldset>
     <label for="@Html.FieldIdFor(m => m.Value)">@Model.DisplayName</label>
+    @if (HasText(settings.Hint)) {
     <span class="hint">@settings.Hint</span>
-
+    }
     <div class="editor-label">
         <label for="@Html.FieldIdFor(m => m.Value)" @if(settings.Required) { <text>class="required"</text> }>@T("Url")</label>
     </div>
diff --git a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/MediaGallery.Edit.cshtml b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/MediaGallery.Edit.cshtml
index eed5f99d6..862369c9f 100644
--- a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/MediaGallery.Edit.cshtml
+++ b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/MediaGallery.Edit.cshtml
@@ -14,7 +14,9 @@
 
 <fieldset>
     <label @if(settings.Required) { <text>class="required"</text> }>@Model.Field.DisplayName</label>
+    @if (HasText(settings.Hint)) {
     <span class="hint">@settings.Hint</span>
+    }
 
     <div id="save-message-@descriminator" class="message message-Warning media-gallery-message">@T("You need to save your changes.")</div>
     <table id="media-gallery-@descriminator" class="items media-gallery" summary="@Model.Field.DisplayName">
diff --git a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/MediaPicker.Edit.cshtml b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/MediaPicker.Edit.cshtml
index 7cae15dd6..f0c8de8c5 100644
--- a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/MediaPicker.Edit.cshtml
+++ b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/MediaPicker.Edit.cshtml
@@ -15,8 +15,9 @@
         <span id="clear-@Html.FieldIdFor(m => m.Url)" class="button">@T("Clear")</span>    
     }
     
+    @if (HasText(settings.Hint)) {
     <span class="hint">@settings.Hint</span>
-
+    }
     @Html.HiddenFor(m => m.AlternateText)
     @Html.HiddenFor(m => m.Class)
     @Html.HiddenFor(m => m.Style)
diff --git a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Numeric.Edit.cshtml b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Numeric.Edit.cshtml
index d4e4247e8..f7c29c5d8 100644
--- a/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Numeric.Edit.cshtml
+++ b/src/Orchard.Web/Modules/Orchard.Fields/Views/EditorTemplates/Fields/Numeric.Edit.cshtml
@@ -6,5 +6,7 @@
     <label for="@Html.FieldIdFor(m => m.Value)" @if(Model.Settings.Required) { <text>class="required"</text> }>@Model.Field.DisplayName</label>
     @Html.TextBoxFor(m => m.Value, new { @class = "text-small", type = "text", min = (Model.Settings.Minimum.HasValue) ? Model.Settings.Minimum.Value : 0, max = (Model.Settings.Maximum.HasValue) ? Model.Settings.Maximum.Value : 1000000, step = Math.Pow(10, 0 - Model.Settings.Scale).ToString(CultureInfo.InvariantCulture) })
     @Html.ValidationMessageFor(m => m.Value)
+    @if (HasText(Model.Settings.Hint)) {
     <span class="hint">@Model.Settings.Hint</span>
+    }
 </fieldset>