From 696239fda813072184733407050d09fe90c34d1e Mon Sep 17 00:00:00 2001 From: jasperd Date: Mon, 25 Nov 2013 08:26:36 +0100 Subject: [PATCH 01/21] #17216: Theme codegen creates a Zones folder in the theme Work Item: 17216 --- .../Commands/CodeGenerationCommands.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Orchard.Web/Modules/Orchard.CodeGeneration/Commands/CodeGenerationCommands.cs b/src/Orchard.Web/Modules/Orchard.CodeGeneration/Commands/CodeGenerationCommands.cs index 4b819452d..dcbb9347c 100644 --- a/src/Orchard.Web/Modules/Orchard.CodeGeneration/Commands/CodeGenerationCommands.cs +++ b/src/Orchard.Web/Modules/Orchard.CodeGeneration/Commands/CodeGenerationCommands.cs @@ -19,11 +19,11 @@ namespace Orchard.CodeGeneration.Commands { private const string SolutionDirectoryModules = "E9C9F120-07BA-4DFB-B9C3-3AFB9D44C9D5"; private const string SolutionDirectoryThemes = "74492CBC-7201-417E-BC29-28B4C25A58B0"; - private static readonly string[] _themeDirectories = new [] { - "", "Content", "Styles", "Scripts", "Views", "Zones" + private static readonly string[] _themeDirectories = { + "", "Content", "Styles", "Scripts", "Views" }; - private static readonly string[] _moduleDirectories = new [] { - "", "Properties", "Controllers", "Views", "Models", "Scripts", "Styles" + private static readonly string[] _moduleDirectories = { + "", "Properties", "Controllers", "Views", "Models", "Scripts", "Styles" }; private const string ModuleName = "CodeGeneration"; From f033b78afe911671ee9eceb6670c1443ad2bd392 Mon Sep 17 00:00:00 2001 From: Tony Mackay Date: Fri, 22 Nov 2013 13:28:27 +0000 Subject: [PATCH 02/21] #20299: Fixed validation summary not being displayed Work Item: 20299 --- .../Orchard.Comments/Controllers/CommentController.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Orchard.Web/Modules/Orchard.Comments/Controllers/CommentController.cs b/src/Orchard.Web/Modules/Orchard.Comments/Controllers/CommentController.cs index 38c4fec44..56ff22f49 100644 --- a/src/Orchard.Web/Modules/Orchard.Comments/Controllers/CommentController.cs +++ b/src/Orchard.Web/Modules/Orchard.Comments/Controllers/CommentController.cs @@ -35,19 +35,19 @@ namespace Orchard.Comments.Controllers { var editorShape = Services.ContentManager.UpdateEditor(comment, this); - if (!ModelState.IsValidField("Author")) { + if (!ModelState.IsValidField("Comments.Author")) { Services.Notifier.Error(T("Name is mandatory and must have less than 255 chars")); } - if (!ModelState.IsValidField("Email")) { + if (!ModelState.IsValidField("Comments.Email")) { Services.Notifier.Error(T("Email is invalid or is longer than 255 chars")); } - if (!ModelState.IsValidField("Site")) { + if (!ModelState.IsValidField("Comments.Site")) { Services.Notifier.Error(T("Site url is invalid or is longer than 255 chars")); } - if (!ModelState.IsValidField("CommentText")) { + if (!ModelState.IsValidField("Comments.CommentText")) { Services.Notifier.Error(T("Comment is mandatory")); } From c418e098546a84d4354c28e51ebf8074c3272828 Mon Sep 17 00:00:00 2001 From: Jay Harris Date: Tue, 19 Nov 2013 19:13:18 -0500 Subject: [PATCH 03/21] Fix issue 20292. In Definition Template, checkboxes were improperly inverted between the edit and publish columns. Also, default permissions were improperly wired up between PublishOwn and View permissions. --- .../Drivers/ContentPermissionsPartDriver.cs | 2 +- .../ContentPermissionsPartViewModel.cshtml | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/Orchard.Web/Modules/Orchard.ContentPermissions/Drivers/ContentPermissionsPartDriver.cs b/src/Orchard.Web/Modules/Orchard.ContentPermissions/Drivers/ContentPermissionsPartDriver.cs index a294aef02..5e3fcf9af 100644 --- a/src/Orchard.Web/Modules/Orchard.ContentPermissions/Drivers/ContentPermissionsPartDriver.cs +++ b/src/Orchard.Web/Modules/Orchard.ContentPermissions/Drivers/ContentPermissionsPartDriver.cs @@ -177,7 +177,7 @@ namespace Orchard.ContentPermissions.Drivers { } if (!_authorizer.Authorize(Core.Contents.Permissions.PublishOwnContent, part.ContentItem)) { - part.PublishOwnContent = settings == null ? ContentPermissionsPartViewModel.SerializePermissions(allRoles.Select(x => new RoleEntry {Role = x, Checked = _authorizationService.TryCheckAccess(Core.Contents.Permissions.ViewContent, UserSimulation.Create(x), null)})) : settings.PublishOwn; + part.PublishOwnContent = settings == null ? ContentPermissionsPartViewModel.SerializePermissions(allRoles.Select(x => new RoleEntry {Role = x, Checked = _authorizationService.TryCheckAccess(Core.Contents.Permissions.PublishOwnContent, UserSimulation.Create(x), null)})) : settings.PublishOwn; } if (!_authorizer.Authorize(Core.Contents.Permissions.EditContent, part.ContentItem)) { diff --git a/src/Orchard.Web/Modules/Orchard.ContentPermissions/Views/DefinitionTemplates/ContentPermissionsPartViewModel.cshtml b/src/Orchard.Web/Modules/Orchard.ContentPermissions/Views/DefinitionTemplates/ContentPermissionsPartViewModel.cshtml index 889859042..396574d13 100644 --- a/src/Orchard.Web/Modules/Orchard.ContentPermissions/Views/DefinitionTemplates/ContentPermissionsPartViewModel.cshtml +++ b/src/Orchard.Web/Modules/Orchard.ContentPermissions/Views/DefinitionTemplates/ContentPermissionsPartViewModel.cshtml @@ -30,15 +30,15 @@ @Html.HiddenFor(m => m.PublishRoles[role.Index].Role) @Html.HiddenFor(m => m.EditRoles[role.Index].Role) @@ -74,15 +74,15 @@ @Html.HiddenFor(m => m.PublishOwnRoles[role.Index].Role) @Html.HiddenFor(m => m.EditOwnRoles[role.Index].Role) From d679231271bc612124720bfc713a9622917b9433 Mon Sep 17 00:00:00 2001 From: Jay Harris Date: Tue, 19 Nov 2013 19:17:50 -0500 Subject: [PATCH 04/21] #20292: Added Role field update for Definition Template Work Item: 20292 --- .../ContentPermissionsPartViewModel.cshtml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Orchard.Web/Modules/Orchard.ContentPermissions/Views/DefinitionTemplates/ContentPermissionsPartViewModel.cshtml b/src/Orchard.Web/Modules/Orchard.ContentPermissions/Views/DefinitionTemplates/ContentPermissionsPartViewModel.cshtml index 396574d13..b318e1c74 100644 --- a/src/Orchard.Web/Modules/Orchard.ContentPermissions/Views/DefinitionTemplates/ContentPermissionsPartViewModel.cshtml +++ b/src/Orchard.Web/Modules/Orchard.ContentPermissions/Views/DefinitionTemplates/ContentPermissionsPartViewModel.cshtml @@ -33,14 +33,14 @@ x.Role == role.Name && x.Default)) { checked="checked" } title="Default value"/> x.Role == role.Name && x.Checked)) { checked="checked" } name="@Html.FieldNameFor(m => m.EditRoles[role.Index].Checked)" id="@Html.FieldIdFor(m => m.EditRoles[role.Index].Checked)" @if (!Model.EditRoles[role.Index].Enabled) { disabled="disabled" }/> - @Html.HiddenFor(m => m.PublishRoles[role.Index].Role) + @Html.HiddenFor(m => m.EditRoles[role.Index].Role) - @Html.HiddenFor(m => m.EditRoles[role.Index].Role) + @Html.HiddenFor(m => m.PublishRoles[role.Index].Role) - @Html.HiddenFor(m => m.PublishOwnRoles[role.Index].Role) + @Html.HiddenFor(m => m.EditOwnRoles[role.Index].Role) - @Html.HiddenFor(m => m.EditOwnRoles[role.Index].Role) + @Html.HiddenFor(m => m.PublishOwnRoles[role.Index].Role)