diff --git a/src/Orchard.Core.Tests/Body/BodyPartTests.cs b/src/Orchard.Core.Tests/Body/BodyPartTests.cs index cd6b2dbac..a899d8246 100644 --- a/src/Orchard.Core.Tests/Body/BodyPartTests.cs +++ b/src/Orchard.Core.Tests/Body/BodyPartTests.cs @@ -38,7 +38,6 @@ namespace Orchard.Core.Tests.Body { builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); - builder.RegisterType().As(); builder.RegisterType().As(); diff --git a/src/Orchard.Core.Tests/Common/Providers/CommonPartProviderTests.cs b/src/Orchard.Core.Tests/Common/Providers/CommonPartProviderTests.cs index fa53d7439..bd345b672 100644 --- a/src/Orchard.Core.Tests/Common/Providers/CommonPartProviderTests.cs +++ b/src/Orchard.Core.Tests/Common/Providers/CommonPartProviderTests.cs @@ -47,7 +47,6 @@ namespace Orchard.Core.Tests.Common.Providers { builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); - builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterInstance(new Mock().Object); diff --git a/src/Orchard.Core.Tests/Orchard.Core.Tests.csproj b/src/Orchard.Core.Tests/Orchard.Core.Tests.csproj index e39523c1a..43e607a30 100644 --- a/src/Orchard.Core.Tests/Orchard.Core.Tests.csproj +++ b/src/Orchard.Core.Tests/Orchard.Core.Tests.csproj @@ -59,6 +59,7 @@ False ..\..\lib\autofac\Autofac.dll + False ..\..\lib\moq\Moq.dll diff --git a/src/Orchard.Core.Tests/Routable/Services/RoutableServiceTests.cs b/src/Orchard.Core.Tests/Routable/Services/RoutableServiceTests.cs index 3d02cc9af..ae9e5661b 100644 --- a/src/Orchard.Core.Tests/Routable/Services/RoutableServiceTests.cs +++ b/src/Orchard.Core.Tests/Routable/Services/RoutableServiceTests.cs @@ -53,7 +53,6 @@ namespace Orchard.Core.Tests.Routable.Services { builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); - builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterInstance(new UrlHelper(new RequestContext(new StubHttpContext("~/"), new RouteData()))).As(); diff --git a/src/Orchard.Core.Tests/Scheduling/ScheduledTaskExecutorTests.cs b/src/Orchard.Core.Tests/Scheduling/ScheduledTaskExecutorTests.cs index 7281bf014..1dae6ce97 100644 --- a/src/Orchard.Core.Tests/Scheduling/ScheduledTaskExecutorTests.cs +++ b/src/Orchard.Core.Tests/Scheduling/ScheduledTaskExecutorTests.cs @@ -37,7 +37,6 @@ namespace Orchard.Core.Tests.Scheduling { builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); - builder.RegisterType().As(); builder.RegisterInstance(new Mock().Object); builder.RegisterInstance(new Mock().Object); diff --git a/src/Orchard.Core.Tests/Scheduling/ScheduledTaskManagerTests.cs b/src/Orchard.Core.Tests/Scheduling/ScheduledTaskManagerTests.cs index 9c7fc1710..ef2fdf56b 100644 --- a/src/Orchard.Core.Tests/Scheduling/ScheduledTaskManagerTests.cs +++ b/src/Orchard.Core.Tests/Scheduling/ScheduledTaskManagerTests.cs @@ -41,7 +41,6 @@ namespace Orchard.Core.Tests.Scheduling { builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); - builder.RegisterType().As(); builder.RegisterInstance(new Mock().Object); builder.RegisterInstance(new Mock().Object); diff --git a/src/Orchard.Tests.Modules/Orchard.Tests.Modules.csproj b/src/Orchard.Tests.Modules/Orchard.Tests.Modules.csproj index 9602ca227..03b1280c2 100644 --- a/src/Orchard.Tests.Modules/Orchard.Tests.Modules.csproj +++ b/src/Orchard.Tests.Modules/Orchard.Tests.Modules.csproj @@ -60,6 +60,7 @@ ..\..\lib\autofac\Autofac.dll + False ..\..\lib\fluentnhibernate\FluentNHibernate.dll diff --git a/src/Orchard.Tests.Modules/Themes/Services/ThemeServiceTests.cs b/src/Orchard.Tests.Modules/Themes/Services/ThemeServiceTests.cs index 1a98a5948..80d810580 100644 --- a/src/Orchard.Tests.Modules/Themes/Services/ThemeServiceTests.cs +++ b/src/Orchard.Tests.Modules/Themes/Services/ThemeServiceTests.cs @@ -77,7 +77,6 @@ namespace Orchard.Tests.Modules.Themes.Services { builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); - builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); diff --git a/src/Orchard.Tests.Modules/Users/Controllers/AdminControllerTests.cs b/src/Orchard.Tests.Modules/Users/Controllers/AdminControllerTests.cs index 619a17f56..dba94bd51 100644 --- a/src/Orchard.Tests.Modules/Users/Controllers/AdminControllerTests.cs +++ b/src/Orchard.Tests.Modules/Users/Controllers/AdminControllerTests.cs @@ -58,7 +58,6 @@ namespace Orchard.Tests.Modules.Users.Controllers { builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); - builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterInstance(new Mock().Object); builder.RegisterInstance(new Mock().Object); diff --git a/src/Orchard.Tests.Modules/Users/Services/MembershipServiceTests.cs b/src/Orchard.Tests.Modules/Users/Services/MembershipServiceTests.cs index dd135eb44..7db05d021 100644 --- a/src/Orchard.Tests.Modules/Users/Services/MembershipServiceTests.cs +++ b/src/Orchard.Tests.Modules/Users/Services/MembershipServiceTests.cs @@ -81,7 +81,6 @@ namespace Orchard.Tests.Modules.Users.Services { builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); - builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); diff --git a/src/Orchard.Tests.Modules/Widgets/Services/WidgetsServiceTest.cs b/src/Orchard.Tests.Modules/Widgets/Services/WidgetsServiceTest.cs index ec0dfe524..57cc64270 100644 --- a/src/Orchard.Tests.Modules/Widgets/Services/WidgetsServiceTest.cs +++ b/src/Orchard.Tests.Modules/Widgets/Services/WidgetsServiceTest.cs @@ -85,7 +85,6 @@ namespace Orchard.Tests.Modules.Widgets.Services { builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); - builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); Theme theme1 = new Theme { Zones = ThemeZoneName1 }; @@ -242,8 +241,24 @@ namespace Orchard.Tests.Modules.Widgets.Services { Assert.That(widgetPart3.Position, Is.EqualTo(Position3), "Widget remained in the same position"); } - [Test, Ignore("Fix when possible")] public void GetLayerWidgetsTest() { LayerPart layerPart = _widgetService.CreateLayer(LayerName1, LayerDescription1, ""); _contentManager.Flush(); // same zone widgets WidgetPart widgetPart1 = _widgetService.CreateWidget(layerPart.Id, "HtmlWidget", WidgetTitle1, Position1, Zone1); WidgetPart widgetPart2 = _widgetService.CreateWidget(layerPart.Id, "HtmlWidget", WidgetTitle2, Position2, Zone1); // different zone widget _widgetService.CreateWidget(layerPart.Id, "HtmlWidget", WidgetTitle3, Position3, Zone2); - // test 1 - moving first widget up will have no effect IEnumerable layerWidgets = _widgetService.GetWidgets(layerPart.Id); Assert.That(layerWidgets.Count(), Is.EqualTo(2)); Assert.That(layerWidgets.Contains(widgetPart1)); Assert.That(layerWidgets.Contains(widgetPart2)); } + [Test, Ignore("Fix when possible")] + public void GetLayerWidgetsTest() { + LayerPart layerPart = _widgetService.CreateLayer(LayerName1, LayerDescription1, ""); + _contentManager.Flush(); + + // same zone widgets + WidgetPart widgetPart1 = _widgetService.CreateWidget(layerPart.Id, "HtmlWidget", WidgetTitle1, Position1, Zone1); + WidgetPart widgetPart2 = _widgetService.CreateWidget(layerPart.Id, "HtmlWidget", WidgetTitle2, Position2, Zone1); + + // different zone widget + _widgetService.CreateWidget(layerPart.Id, "HtmlWidget", WidgetTitle3, Position3, Zone2); + + // test 1 - moving first widget up will have no effect + IEnumerable layerWidgets = _widgetService.GetWidgets(layerPart.Id); + Assert.That(layerWidgets.Count(), Is.EqualTo(2)); + Assert.That(layerWidgets.Contains(widgetPart1)); + Assert.That(layerWidgets.Contains(widgetPart2)); + } public class StubLayerPartHandler : ContentHandler { public StubLayerPartHandler(IRepository layersRepository) { diff --git a/src/Orchard.Tests/ContentManagement/ContentQueryTests.cs b/src/Orchard.Tests/ContentManagement/ContentQueryTests.cs index df11f5a64..5652f0f71 100644 --- a/src/Orchard.Tests/ContentManagement/ContentQueryTests.cs +++ b/src/Orchard.Tests/ContentManagement/ContentQueryTests.cs @@ -63,7 +63,6 @@ namespace Orchard.Tests.ContentManagement { builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); - builder.RegisterType().As(); builder.RegisterGeneric(typeof(Repository<>)).As(typeof(IRepository<>)); diff --git a/src/Orchard.Tests/ContentManagement/DefaultContentManagerTests.cs b/src/Orchard.Tests/ContentManagement/DefaultContentManagerTests.cs index 192a1f127..2a0d55261 100644 --- a/src/Orchard.Tests/ContentManagement/DefaultContentManagerTests.cs +++ b/src/Orchard.Tests/ContentManagement/DefaultContentManagerTests.cs @@ -73,7 +73,6 @@ namespace Orchard.Tests.ContentManagement { builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); - builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); diff --git a/src/Orchard.Tests/ContentManagement/Handlers/Coordinators/ContentPartDriverCoordinatorTests.cs b/src/Orchard.Tests/ContentManagement/Handlers/Coordinators/ContentPartDriverCoordinatorTests.cs index fcc91aa3b..5b9a249f6 100644 --- a/src/Orchard.Tests/ContentManagement/Handlers/Coordinators/ContentPartDriverCoordinatorTests.cs +++ b/src/Orchard.Tests/ContentManagement/Handlers/Coordinators/ContentPartDriverCoordinatorTests.cs @@ -22,7 +22,6 @@ namespace Orchard.Tests.ContentManagement.Handlers.Coordinators { var builder = new ContainerBuilder(); //builder.RegisterModule(new ImplicitCollectionSupportModule()); builder.RegisterType().As(); - builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterInstance(new Mock().Object); _container = builder.Build(); @@ -45,7 +44,7 @@ namespace Orchard.Tests.ContentManagement.Handlers.Coordinators { var contentHandler = _container.Resolve(); var contentItem = new ContentItem(); - var context = new BuildDisplayContext(null, contentItem, "", new ShapeHelperFactory(null)); + var context = new BuildDisplayContext(null, contentItem, "", new Mock().Object); driver1.Verify(x => x.BuildDisplay(context), Times.Never()); driver2.Verify(x => x.BuildDisplay(context), Times.Never()); @@ -61,13 +60,13 @@ namespace Orchard.Tests.ContentManagement.Handlers.Coordinators { builder.RegisterInstance(driver).As(); builder.Update(_container); var contentHandler = _container.Resolve(); - var shapeHelperFactory = _container.Resolve(); + dynamic shapeFactory = _container.Resolve(); var contentItem = new ContentItem(); contentItem.Weld(new StubPart { Foo = new[] { "a", "b", "c" } }); var ctx = new BuildDisplayContext(null, null, "", null); - var context = shapeHelperFactory.CreateHelper().Context(ctx); + var context = shapeFactory.Context(ctx); Assert.That(context.TopMeta, Is.Null); contentHandler.BuildDisplay(ctx); Assert.That(context.TopMeta, Is.Not.Null); diff --git a/src/Orchard.Tests/DisplayManagement/ShapeFactoryTests.cs b/src/Orchard.Tests/DisplayManagement/ShapeFactoryTests.cs index 62a14a7f5..d217198b8 100644 --- a/src/Orchard.Tests/DisplayManagement/ShapeFactoryTests.cs +++ b/src/Orchard.Tests/DisplayManagement/ShapeFactoryTests.cs @@ -21,7 +21,6 @@ namespace Orchard.Tests.DisplayManagement { var builder = new ContainerBuilder(); builder.RegisterType().As(); builder.RegisterType().As(); - builder.RegisterType().As(); builder.RegisterType().As(); _container = builder.Build(); } diff --git a/src/Orchard.Tests/DisplayManagement/ShapeHelperTests.cs b/src/Orchard.Tests/DisplayManagement/ShapeHelperTests.cs index 2bfd69210..ce6b42307 100644 --- a/src/Orchard.Tests/DisplayManagement/ShapeHelperTests.cs +++ b/src/Orchard.Tests/DisplayManagement/ShapeHelperTests.cs @@ -19,7 +19,6 @@ namespace Orchard.Tests.DisplayManagement { [SetUp] public void Init() { var builder = new ContainerBuilder(); - builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); @@ -29,7 +28,7 @@ namespace Orchard.Tests.DisplayManagement { [Test] public void CreatingNewShapeTypeByName() { - dynamic shape = _container.Resolve().CreateHelper(); + dynamic shape = _container.Resolve(); var alpha = shape.Alpha(); @@ -38,7 +37,7 @@ namespace Orchard.Tests.DisplayManagement { [Test] public void CreatingShapeWithAdditionalNamedParameters() { - dynamic shape = _container.Resolve().CreateHelper(); + dynamic shape = _container.Resolve(); var alpha = shape.Alpha(one: 1, two: "dos"); @@ -49,7 +48,7 @@ namespace Orchard.Tests.DisplayManagement { [Test] public void WithPropertyBearingObjectInsteadOfNamedParameters() { - dynamic shape = _container.Resolve().CreateHelper(); + dynamic shape = _container.Resolve(); var alpha = shape.Alpha(new { one = 1, two = "dos" }); diff --git a/src/Orchard.Tests/DisplayManagement/SubsystemTests.cs b/src/Orchard.Tests/DisplayManagement/SubsystemTests.cs index c9cea13f7..87a5095c9 100644 --- a/src/Orchard.Tests/DisplayManagement/SubsystemTests.cs +++ b/src/Orchard.Tests/DisplayManagement/SubsystemTests.cs @@ -44,7 +44,6 @@ namespace Orchard.Tests.DisplayManagement { builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterType().As(); - builder.RegisterType().As(); builder.RegisterType().As(); builder.RegisterInstance(new DefaultDisplayManagerTests.TestWorkContextAccessor(workContext)).As(); builder.RegisterInstance(new SimpleShapes()).WithMetadata("Feature", testFeature); @@ -72,7 +71,7 @@ namespace Orchard.Tests.DisplayManagement { [Test] public void RenderingSomething() { dynamic displayHelperFactory = _container.Resolve().CreateHelper(new ViewContext(), null); - dynamic shapeHelperFactory = _container.Resolve().CreateHelper(); + dynamic shapeHelperFactory = _container.Resolve(); var result1 = displayHelperFactory.Something(); var result2 = ((DisplayHelper)displayHelperFactory).ShapeExecute((Shape)shapeHelperFactory.Pager()); diff --git a/src/Orchard.Web/Core/Contents/Controllers/AdminController.cs b/src/Orchard.Web/Core/Contents/Controllers/AdminController.cs index c3a2bc47e..b53099453 100644 --- a/src/Orchard.Web/Core/Contents/Controllers/AdminController.cs +++ b/src/Orchard.Web/Core/Contents/Controllers/AdminController.cs @@ -29,14 +29,14 @@ namespace Orchard.Core.Contents.Controllers { IContentManager contentManager, IContentDefinitionManager contentDefinitionManager, ITransactionManager transactionManager, - IShapeHelperFactory shapeHelperFactory) { + IShapeFactory shapeFactory) { Services = orchardServices; _contentManager = contentManager; _contentDefinitionManager = contentDefinitionManager; _transactionManager = transactionManager; T = NullLocalizer.Instance; Logger = NullLogger.Instance; - Shape = shapeHelperFactory.CreateHelper(); + Shape = shapeFactory; } dynamic Shape { get; set; } diff --git a/src/Orchard.Web/Core/Contents/Controllers/ItemController.cs b/src/Orchard.Web/Core/Contents/Controllers/ItemController.cs index bfe5f75e5..f5ab31e71 100644 --- a/src/Orchard.Web/Core/Contents/Controllers/ItemController.cs +++ b/src/Orchard.Web/Core/Contents/Controllers/ItemController.cs @@ -8,9 +8,9 @@ namespace Orchard.Core.Contents.Controllers { public class ItemController : Controller { private readonly IContentManager _contentManager; - public ItemController(IContentManager contentManager, IShapeHelperFactory shapeHelperFactory) { + public ItemController(IContentManager contentManager, IShapeFactory shapeFactory) { _contentManager = contentManager; - Shape = shapeHelperFactory.CreateHelper(); + Shape = shapeFactory; } dynamic Shape { get; set; } diff --git a/src/Orchard.Web/Core/Feeds/Services/FeedFilter.cs b/src/Orchard.Web/Core/Feeds/Services/FeedFilter.cs index 10000f8c4..5af31c66c 100644 --- a/src/Orchard.Web/Core/Feeds/Services/FeedFilter.cs +++ b/src/Orchard.Web/Core/Feeds/Services/FeedFilter.cs @@ -9,10 +9,13 @@ namespace Orchard.Core.Feeds.Services { private readonly IFeedManager _feedManager; private readonly IWorkContextAccessor _workContextAccessor; - public FeedFilter(IFeedManager feedManager, IWorkContextAccessor workContextAccessor, IShapeHelperFactory shapeHelperFactory) { + public FeedFilter( + IFeedManager feedManager, + IWorkContextAccessor workContextAccessor, + IShapeFactory shapeFactory) { _feedManager = feedManager; _workContextAccessor = workContextAccessor; - Shape = shapeHelperFactory.CreateHelper(); + Shape = shapeFactory; } dynamic Shape { get; set; } diff --git a/src/Orchard.Web/Core/Localization/Controllers/AdminController.cs b/src/Orchard.Web/Core/Localization/Controllers/AdminController.cs index cb3aba8ee..c3388fd1b 100644 --- a/src/Orchard.Web/Core/Localization/Controllers/AdminController.cs +++ b/src/Orchard.Web/Core/Localization/Controllers/AdminController.cs @@ -24,13 +24,13 @@ namespace Orchard.Core.Localization.Controllers { IContentManager contentManager, ICultureManager cultureManager, ILocalizationService localizationService, - IShapeHelperFactory shapeHelperFactory) { + IShapeFactory shapeFactory) { _contentManager = contentManager; _cultureManager = cultureManager; _localizationService = localizationService; T = NullLocalizer.Instance; Services = orchardServices; - Shape = shapeHelperFactory.CreateHelper(); + Shape = shapeFactory; } dynamic Shape { get; set; } diff --git a/src/Orchard.Web/Core/Navigation/Controllers/AdminController.cs b/src/Orchard.Web/Core/Navigation/Controllers/AdminController.cs index 964962a08..ceba193a9 100644 --- a/src/Orchard.Web/Core/Navigation/Controllers/AdminController.cs +++ b/src/Orchard.Web/Core/Navigation/Controllers/AdminController.cs @@ -22,12 +22,12 @@ namespace Orchard.Core.Navigation.Controllers { IMenuService menuService, IOrchardServices services, INavigationManager navigationManager, - IShapeHelperFactory shapeHelperFactory) { + IShapeFactory shapeFactory) { _menuService = menuService; _services = services; _navigationManager = navigationManager; T = NullLocalizer.Instance; - Shape = shapeHelperFactory.CreateHelper(); + Shape = shapeFactory; } dynamic Shape { get; set; } diff --git a/src/Orchard.Web/Core/Reports/Controllers/AdminController.cs b/src/Orchard.Web/Core/Reports/Controllers/AdminController.cs index 728f94444..955bc415a 100644 --- a/src/Orchard.Web/Core/Reports/Controllers/AdminController.cs +++ b/src/Orchard.Web/Core/Reports/Controllers/AdminController.cs @@ -8,11 +8,10 @@ namespace Orchard.Core.Reports.Controllers { public class AdminController : Controller { private readonly IReportsManager _reportsManager; - public AdminController(IReportsManager reportsManager, IShapeHelperFactory shapeHelperFactory) { + public AdminController(IReportsManager reportsManager) { _reportsManager = reportsManager; } - dynamic Shape { get; set; } public ActionResult Index() { var model = new ReportsAdminIndexViewModel { Reports = _reportsManager.GetReports().ToList() }; diff --git a/src/Orchard.Web/Core/Routable/Controllers/ItemController.cs b/src/Orchard.Web/Core/Routable/Controllers/ItemController.cs index 1aed89ed8..1b4ffae1c 100644 --- a/src/Orchard.Web/Core/Routable/Controllers/ItemController.cs +++ b/src/Orchard.Web/Core/Routable/Controllers/ItemController.cs @@ -16,11 +16,15 @@ namespace Orchard.Core.Routable.Controllers { private readonly ITransactionManager _transactionManager; private readonly IRoutablePathConstraint _routablePathConstraint; - public ItemController(IContentManager contentManager, ITransactionManager transactionManager, IRoutablePathConstraint routablePathConstraint, IShapeHelperFactory shapeHelperFactory) { + public ItemController( + IContentManager contentManager, + ITransactionManager transactionManager, + IRoutablePathConstraint routablePathConstraint, + IShapeFactory shapeFactory) { _contentManager = contentManager; _transactionManager = transactionManager; _routablePathConstraint = routablePathConstraint; - Shape = shapeHelperFactory.CreateHelper(); + Shape = shapeFactory; } dynamic Shape { get; set; } diff --git a/src/Orchard.Web/Core/Routable/Services/RoutableHomePageProvider.cs b/src/Orchard.Web/Core/Routable/Services/RoutableHomePageProvider.cs index 5a2f32d60..60e39a828 100644 --- a/src/Orchard.Web/Core/Routable/Services/RoutableHomePageProvider.cs +++ b/src/Orchard.Web/Core/Routable/Services/RoutableHomePageProvider.cs @@ -12,11 +12,14 @@ namespace Orchard.Core.Routable.Services { private readonly IContentManager _contentManager; public const string Name = "RoutableHomePageProvider"; - public RoutableHomePageProvider(IOrchardServices services, IContentManager contentManager, IShapeHelperFactory shapeHelperFactory) { + public RoutableHomePageProvider( + IOrchardServices services, + IContentManager contentManager, + IShapeFactory shapeFactory) { _contentManager = contentManager; Services = services; T = NullLocalizer.Instance; - Shape = shapeHelperFactory.CreateHelper(); + Shape = shapeFactory; } dynamic Shape { get; set; } diff --git a/src/Orchard.Web/Core/Settings/Controllers/AdminController.cs b/src/Orchard.Web/Core/Settings/Controllers/AdminController.cs index e3355c79c..f191aa8df 100644 --- a/src/Orchard.Web/Core/Settings/Controllers/AdminController.cs +++ b/src/Orchard.Web/Core/Settings/Controllers/AdminController.cs @@ -21,15 +21,13 @@ namespace Orchard.Core.Settings.Controllers { public AdminController( ISiteService siteService, IOrchardServices services, - ICultureManager cultureManager, - IShapeHelperFactory shapeHelperFactory) { + ICultureManager cultureManager) { _siteService = siteService; _cultureManager = cultureManager; Services = services; T = NullLocalizer.Instance; } - dynamic Shape { get; set; } public Localizer T { get; set; } public ActionResult Index(string tabName) { diff --git a/src/Orchard.Web/Modules/Orchard.Blogs/Controllers/BlogAdminController.cs b/src/Orchard.Web/Modules/Orchard.Blogs/Controllers/BlogAdminController.cs index bd5bc5990..b660df687 100644 --- a/src/Orchard.Web/Modules/Orchard.Blogs/Controllers/BlogAdminController.cs +++ b/src/Orchard.Web/Modules/Orchard.Blogs/Controllers/BlogAdminController.cs @@ -21,13 +21,13 @@ namespace Orchard.Blogs.Controllers { private readonly ITransactionManager _transactionManager; private readonly IBlogSlugConstraint _blogSlugConstraint; - public BlogAdminController(IOrchardServices services, + public BlogAdminController( + IOrchardServices services, IBlogService blogService, IBlogPostService blogPostService, IContentManager contentManager, ITransactionManager transactionManager, - IBlogSlugConstraint blogSlugConstraint, - IShapeHelperFactory shapeHelperFactory) { + IBlogSlugConstraint blogSlugConstraint) { Services = services; _blogService = blogService; _blogPostService = blogPostService; @@ -35,10 +35,8 @@ namespace Orchard.Blogs.Controllers { _transactionManager = transactionManager; _blogSlugConstraint = blogSlugConstraint; T = NullLocalizer.Instance; - Shape = shapeHelperFactory.CreateHelper(); } - dynamic Shape { get; set; } public Localizer T { get; set; } public IOrchardServices Services { get; set; } @@ -123,7 +121,7 @@ namespace Orchard.Blogs.Controllers { } public ActionResult List() { - var list = Shape.List(); + var list = Services.New.List(); list.AddRange(_blogService.Get() .Select(b => { var blog = Services.ContentManager.BuildDisplay(b, "SummaryAdmin"); @@ -131,7 +129,7 @@ namespace Orchard.Blogs.Controllers { return blog; })); - var viewModel = Shape.ViewModel() + var viewModel = Services.New.ViewModel() .ContentItems(list); return View(viewModel); diff --git a/src/Orchard.Web/Modules/Orchard.Blogs/Controllers/BlogController.cs b/src/Orchard.Web/Modules/Orchard.Blogs/Controllers/BlogController.cs index 524ed60c2..bddfb7a1f 100644 --- a/src/Orchard.Web/Modules/Orchard.Blogs/Controllers/BlogController.cs +++ b/src/Orchard.Web/Modules/Orchard.Blogs/Controllers/BlogController.cs @@ -20,14 +20,20 @@ namespace Orchard.Blogs.Controllers { private readonly IBlogSlugConstraint _blogSlugConstraint; private readonly RouteCollection _routeCollection; - public BlogController(IOrchardServices services, IBlogService blogService, IBlogPostService blogPostService, IBlogSlugConstraint blogSlugConstraint, RouteCollection routeCollection, IShapeHelperFactory shapeHelperFactory) { + public BlogController( + IOrchardServices services, + IBlogService blogService, + IBlogPostService blogPostService, + IBlogSlugConstraint blogSlugConstraint, + RouteCollection routeCollection, + IShapeFactory shapeFactory) { _services = services; _blogService = blogService; _blogPostService = blogPostService; _blogSlugConstraint = blogSlugConstraint; _routeCollection = routeCollection; Logger = NullLogger.Instance; - Shape = shapeHelperFactory.CreateHelper(); + Shape = shapeFactory; } dynamic Shape { get; set; } diff --git a/src/Orchard.Web/Modules/Orchard.Blogs/Controllers/BlogPostController.cs b/src/Orchard.Web/Modules/Orchard.Blogs/Controllers/BlogPostController.cs index 09de5c0c7..d3c252767 100644 --- a/src/Orchard.Web/Modules/Orchard.Blogs/Controllers/BlogPostController.cs +++ b/src/Orchard.Web/Modules/Orchard.Blogs/Controllers/BlogPostController.cs @@ -23,13 +23,13 @@ namespace Orchard.Blogs.Controllers { IBlogService blogService, IBlogPostService blogPostService, IFeedManager feedManager, - IShapeHelperFactory shapeHelperFactory) { + IShapeFactory shapeFactory) { _services = services; _blogService = blogService; _blogPostService = blogPostService; _feedManager = feedManager; T = NullLocalizer.Instance; - Shape = shapeHelperFactory.CreateHelper(); + Shape = shapeFactory; } dynamic Shape { get; set; } diff --git a/src/Orchard.Web/Modules/Orchard.Blogs/Drivers/BlogPartDriver.cs b/src/Orchard.Web/Modules/Orchard.Blogs/Drivers/BlogPartDriver.cs index 9ed222575..2310d02b3 100644 --- a/src/Orchard.Web/Modules/Orchard.Blogs/Drivers/BlogPartDriver.cs +++ b/src/Orchard.Web/Modules/Orchard.Blogs/Drivers/BlogPartDriver.cs @@ -18,16 +18,19 @@ namespace Orchard.Blogs.Drivers { private readonly IBlogPostService _blogPostService; private readonly IFeedManager _feedManager; - public BlogPartDriver(IOrchardServices services, IContentManager contentManager, IBlogPostService blogPostService, IFeedManager feedManager, IShapeHelperFactory shapeHelperFactory) { + public BlogPartDriver( + IOrchardServices services, + IContentManager contentManager, + IBlogPostService blogPostService, + IFeedManager feedManager) { Services = services; _contentManager = contentManager; _blogPostService = blogPostService; _feedManager = feedManager; T = NullLocalizer.Instance; - Shape = shapeHelperFactory.CreateHelper(); } - dynamic Shape { get; set; } + public Localizer T { get; set; } protected override string Prefix { get { return ""; } } diff --git a/src/Orchard.Web/Modules/Orchard.Comments/Views/Parts/Comments.Comments.cshtml b/src/Orchard.Web/Modules/Orchard.Comments/Views/Parts/Comments.Comments.cshtml index 0b4162ba8..7a53265b8 100644 --- a/src/Orchard.Web/Modules/Orchard.Comments/Views/Parts/Comments.Comments.cshtml +++ b/src/Orchard.Web/Modules/Orchard.Comments/Views/Parts/Comments.Comments.cshtml @@ -22,7 +22,7 @@ using (Html.BeginForm("Create", "Comment", new { area = "Orchard.Comments" }, Fo if (!Request.IsAuthenticated) {
- @T("Add a Comment") + @T("Add a Comment")
  1. @@ -41,14 +41,15 @@ using (Html.BeginForm("Create", "Comment", new { area = "Orchard.Comments" }, Fo } else { @Html.Hidden("Name", WorkContext.CurrentUser.UserName ?? "") @Html.Hidden("Email", WorkContext.CurrentUser.Email ?? "") + +

    @if (Request.IsAuthenticated) { @T("Hi, {0}!", Html.Encode(WorkContext.CurrentUser.UserName))}

    } -

    @if (Request.IsAuthenticated) { @T("Hi, {0}!", Html.Encode(WorkContext.CurrentUser.UserName))}

    1. - - + +
    2. diff --git a/src/Orchard.Web/Modules/Orchard.Experimental/Controllers/ContentController.cs b/src/Orchard.Web/Modules/Orchard.Experimental/Controllers/ContentController.cs index a00082e22..91ad00be3 100644 --- a/src/Orchard.Web/Modules/Orchard.Experimental/Controllers/ContentController.cs +++ b/src/Orchard.Web/Modules/Orchard.Experimental/Controllers/ContentController.cs @@ -16,9 +16,10 @@ namespace Orchard.Experimental.Controllers { public ContentController( IRepository contentTypeRepository, IContentManager contentManager, - IShapeHelperFactory shapeHelperFactory) { + IShapeFactory shapeFactory) { _contentTypeRepository = contentTypeRepository; _contentManager = contentManager; + Shape = shapeFactory; } dynamic Shape { get; set; } diff --git a/src/Orchard.Web/Modules/Orchard.Experimental/Controllers/HomeController.cs b/src/Orchard.Web/Modules/Orchard.Experimental/Controllers/HomeController.cs index 8e6679047..7537e340b 100644 --- a/src/Orchard.Web/Modules/Orchard.Experimental/Controllers/HomeController.cs +++ b/src/Orchard.Web/Modules/Orchard.Experimental/Controllers/HomeController.cs @@ -14,10 +14,10 @@ namespace Orchard.Experimental.Controllers { public class HomeController : Controller { private readonly INotifier _notifier; - public HomeController(INotifier notifier, IShapeHelperFactory shapeHelperFactory) { + public HomeController(INotifier notifier, IShapeFactory shapeFactory) { _notifier = notifier; T = NullLocalizer.Instance; - Shape = shapeHelperFactory.CreateHelper(); + Shape = shapeFactory; } dynamic Shape { get; set; } diff --git a/src/Orchard.Web/Modules/Orchard.Search/Drivers/SearchSettingsPartDriver.cs b/src/Orchard.Web/Modules/Orchard.Search/Drivers/SearchSettingsPartDriver.cs index 369c6e7ed..638905e61 100644 --- a/src/Orchard.Web/Modules/Orchard.Search/Drivers/SearchSettingsPartDriver.cs +++ b/src/Orchard.Web/Modules/Orchard.Search/Drivers/SearchSettingsPartDriver.cs @@ -24,8 +24,8 @@ namespace Orchard.Search.Drivers { protected override string Prefix { get { return "SearchSettings"; } } protected override DriverResult Editor(SearchSettingsPart part, dynamic shapeHelper) { - var model = new SearchSettingsViewModel(); - var searchedFields = part.SearchedFields; + SearchSettingsViewModel model = new SearchSettingsViewModel(); + String [] searchedFields = part.SearchedFields; if (_indexManager.HasIndexProvider()) { model.Entries = new List(); @@ -34,13 +34,14 @@ namespace Orchard.Search.Drivers { } } - return ContentPartTemplate(model, "Parts/Search.SiteSettings"); + return ContentShape("Parts_Search_SiteSettings", + () => shapeHelper.EditorTemplate(TemplateName: "Parts/Search.SiteSettings", Model: model)); } protected override DriverResult Editor(SearchSettingsPart part, IUpdateModel updater, dynamic shapeHelper) { - var model = new SearchSettingsViewModel(); - - if(updater.TryUpdateModel(model, Prefix, null, null)) { + SearchSettingsViewModel model = new SearchSettingsViewModel(); + + if (updater.TryUpdateModel(model, Prefix, null, null)) { part.SearchedFields = model.Entries.Where(e => e.Selected).Select(e => e.Field).ToArray(); } diff --git a/src/Orchard.Web/Modules/Orchard.Search/Orchard.Search.csproj b/src/Orchard.Web/Modules/Orchard.Search/Orchard.Search.csproj index c9f772b90..f6b0ad474 100644 --- a/src/Orchard.Web/Modules/Orchard.Search/Orchard.Search.csproj +++ b/src/Orchard.Web/Modules/Orchard.Search/Orchard.Search.csproj @@ -106,6 +106,9 @@ + + +