* Upgrading projects, code generation templates and Specflow app to use Microsoft.CodeDom.Providers.DotNetCompilerPlatform 4.1.0 (latest)
* Updating csprojs not to define LangVersion separately in Release and Debug mode, setting it to "default" instead of "latest"
* Restricting C# language version to 7.3
* Downgrading SmtpMessageChannel.cs to C# 7.3
* Setting MvcBuildViews = false in the remaining csprojs that reference DotNetCompilerPlatform, like the others
* Setting RoslynCopyToOutDir = false in each csproj that references DotNetCompilerPlatform
See https://github.com/aspnet/RoslynCodeDomProvider?tab=readme-ov-file#build-time-options
- We only need Orchard.Web to include the Roslyn tools in its bin folder, the other csprojs only need the DLL reference
- We could simply remove the targets import in these csprojs, but it will be re-added when the package is updated, so this is cleaner/easier
* We don't actually need <MvcBuildViews>false</MvcBuildViews> in csprojs
* Orchard.Web: Copying Roslyn files to the output folder using the provided target (CopyRoslynCompilerFilesToOutputDirectory) instead of our custom one
* Orchard.proj: Factoring out a part of the Compile target into the DevCompile target and removing BuildViews target
- For a simple local build (just to validate that the solution builds), we don't actually need that second build that copies files to the output folder.
- CI builds (Test, Spec, etc.) that operate on the build output folder are unaffected, because Compile calls DevCompile
- The BuildViews target is not really necessary, just call any other target (Compile, DevCompile, Spec, etc.) with "/p:MvcBuildViews=true"
* Removing incorrect comment about Razor IntelliSense
* Removing VBCodeProvider configuration from Web.config files
* Getting rid of Microsoft.CodeDom.Providers.DotNetCompilerPlatform.targets imports and associated configuration except in Orchard.Web.csproj
* Adding VB compiler configuration to src/Orchard.Web/Web.config, because it would be readded on rebuild by the imported target anyway
* wip fixing Fields/TaxonomyFieldList.cshtml
* restored selector for expando label/handle
* cleanup
* fixed comparison to find parent blog
# Conflicts:
# src/Orchard.Web/Modules/Orchard.Blogs/BlogsLocalizationExtensions/Handlers/BlogPostPartHandler.cs
* fixed initialization of localizedtaxonomyfields
* Checks culture equality based on strings instead of culture records
* If term is culture neutral it is added to the applied terms list without looking for its localization.
# Conflicts:
# src/Orchard.Web/Modules/Orchard.Taxonomies/Controllers/LocalizedTaxonomyController.cs
* Added AdminLocalizedTaxonomyController to properly managed localized taxonomies back office calls.
# Conflicts:
# src/Orchard.Web/Modules/Orchard.Taxonomies/Controllers/LocalizedTaxonomyController.cs
# src/Orchard.Web/Modules/Orchard.Taxonomies/Views/EditorTemplates/Fields/TaxonomyFieldList.cshtml
* Added selectedValues parameter to controller call
---------
Co-authored-by: HermesSbicego-Laser <hermes.sbicego@laser-group.com>
Co-authored-by: Andrea Piovanelli <andrea.piovanelli@laser-group.com>
Removed support for eariler MSBuild versions (they cannot compile SmtpMessageChannel.cs)
Updated lib/nuget/nuget.exe to latest version (6.9.1.3) (required for package restoration)
Modified Obsolete attribute in SmtpSettingsPart.cs so the solution builds with VS2019
They were just rendered as a small, empty rectangle:
- Unassign Role activity styling was syntactically incorrect
- Send Email and Is In Role activity styling file name did not match what the Workflows ResourceManifest expects
"Cannot compile modules using option 'outFile' unless the '--module' flag is 'amd' or 'system'"
Also recompiling client-side assets, but the changes are not the result of the compiler option change, they were just outdated
* Fixing that RecipeManagerTests failed due to HttpContext not being available
* Fixing OwnerEditor tests in CommonPartProviderTests as the owner editor now checks for a different permission since 5b0c82d1ad
* Fixing typo in CommonPartProviderTests.UpdateModelStub class name
* Fixing that test cases for invalid path in FileSystemStorageProviderTests broke in a3e9bef3ca (issue #6802, PR #6919)
I should review PRs more carefully!
* Fixing CurrentCultureWorkContextTests
* Fixing indentation in DefaultDateFormatterTests
* Updating Orchard.Azure.Web's required version of System.Web.Mvc to match the rest of the solution
* Orchard.Specs: Fixing assembly loading errors when starting up the web host by adding binding redirects
* Adding empty compile workflow from dev
* Adding the compile workflow's actual contents
* Changing default shell to pwsh (msbuild was not found in cmd?)
* Adding msbuild to PATH
* Removing unused references to System.Net.Http
* Replacing System.Net.Http references with its NuGet package to pin the correct version number (experimental)
* Upgrading Microsoft.CodeDom.Providers.DotNetCompilerPlatform to 4.1.0 (latest) to get rid of old System.Http.Net dependency
* Orchard.proj: Spec target actually depends on only the Compile target, not Package-Stage (experimental)
* Compile workflow: Testing the Test and Spec targets
* Fixing Test step
* Fixing compile workflow to also mark Razor compilation warnings as errors
* Restoring Orchard.Specs/Hosting/Orchard.Web/Web.config to match Orchard.Web's web.config closer
so that it loads assemblies from the Dependencies folder.
This fixes the error with Autofac not being able to resolve dependencies for DefaultOrchardShell
* Orchard.Specs/Hosting/Orchard.Web/Global.asax.cs: Workaround for AntiForgeryToken bug in ASP.NET MVC since version 5.2.4
https://github.com/aspnet/AspNetWebStack/issues/162
* Revert "Replacing System.Net.Http references with its NuGet package to pin the correct version number (experimental)"
This reverts commit 087f2849b1.
* Revert "Upgrading Microsoft.CodeDom.Providers.DotNetCompilerPlatform to 4.1.0 (latest) to get rid of old System.Http.Net dependency"
This reverts commit be2ba866e3.
* Reverting the addition of assembly binding redirects to Orchard.Specs/Hosting/Simple.Web/Web.config
since it doesn't need them like Orchard.Specs/Hosting/Orchard.Web/Web.config does
* Disabling Test and Spec execution for now
* Orchard.Framework: Making the System.Net.Http not-private to prevent an outdated version sticking around
* Orchard.Workflows: Adding assembly binding redirect for System.Net.Http to avoid Razor compilation warning
* Moving the System.Net.Http assembly redirect to Orchard.Web
* Specs: Fixing "I can create browse blog posts on several pages" Blog test's usage of "I should not see" and correcting the parameters too
because unlike "I should see", this is not a regex match, just contains
* Specs: Fixing "I can create browse blog posts on several pages" Blog test's flakyness due to timing
because the blog posts are created quickly after one another and the lack of millisecond-precision can cause
the blog posts to appear out of order of creation
* Specs: Media test simplified since the Orchard.Media feature is deprecated
* Adding step to the Compile workflow to upload the MSBuild binlog results
* Pinning the referenced version of System.Net.Http to 4.2.0.0 to prevent Razor compilation warning
System.Net.Http is known to have such problems across different framework versions ways of referencing it
The original warning is:
ASPNETCOMPILER : error : The following assembly has dependencies on a version of the .NET Framework that is higher than the target and might not load correctly during runtime causing a failure: Orchard.Workflows, Version=1.10.3.0, Culture=neutral, PublicKeyToken=null. The dependencies are: System.Net.Http, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a. You should either ensure that the dependent assembly is correct for the target framework, or ensure that the target framework you are addressing is that of the dependent assembly. [D:\a\Orchard\Orchard\src\Orchard.Web\Modules\Orchard.Workflows\Orchard.Workflows.csproj
* Re-enabling the Test step
* Re-enabling the Specs step
* Marking System.Net.Http references as private (copy local) to make sure that it's always available, because it requires a specific version
* Revert "Marking System.Net.Http references as private (copy local) to make sure that it's always available, because it requires a specific version"
This reverts commit e4f5632236.
* Orchard.Specs: Adding Settings feature
* Orchard.Specs: Updating DateTime.CreatingAndUsingDateTimeFieldsInAnotherCulture structure without functional change
* Orchard.Specs: Updating Settings.AddingANewSiteCultureAndSelectingItAsTheDefaultWorks to correctly detect that a culture that wasn't added before can be set as default
* Fixing outdated assembly binding redirects
* Fixing Newtonsoft.Json references
* Updating Newtonsoft.Json reference in Orchard.Messaging.Tests.csproj
* Disabling the Test step for now
* Adding System.Net.Http 4.2.0.0 reference to Orchard.Email's web.config to fix Razor compilation warning
* Re-enabling the Test step
* Fixing HqlExpressionTests.AllDataTypesCanBeQueried
* Fixing initialization error error in StylesheetBindingStrategyTests
* Fixing initialization errors in FeatureManagerTests
* Fixing Orchard.Tests.Localization.TextTests
* Code styling and fixing warning in Orchard.Tests/UI/Resources/ResourceManagerTests.cs
* Updating Orchard.Tests/UI/Resources/ResourceManagerTests.cs according to ResourceManager API change in ac11024be4
and removing obsolete tests
* Orchard.Tests.Modules: Adding missing reference to Iesi.Collections (that doesn't cause a build error, just when running tests)
* Fixing initialization errors in ModuleStepTest and ThemeStepTest
* Fixing initialization errors in ShellDescriptorManagerTests
* Fixing initialization errors in AccountControllerTests
* Fixing that MembershipServiceTests should use IPasswordService, also making SaltAndPasswordShouldBeDifferentEvenWithSameSourcePassword test parameters more readable
* Specs: Updating the Newtonsoft.Json binding redirect in the spec app's web.config
* Re-enabling the Spec step
* Upgrading actions to latest versions
These actions generated the Node.js 16 deprecation warning
* Removing SpecFlow test execution from the compile workflow
* Testing the branch strategy matrix concept to be used for the nightly build
* Revert "Testing the branch strategy matrix concept to be used for the nightly build"
This reverts commit 1354e367b7.
* Adding workflow to run specflow tests as a nightly build
* Updating Orchard.Tests.ContentManagement.HqlExpressionTests.ShouldSortRandomly to decrease failure chance due to randomness
* Added checks to GetImageProfileUrl function to avoid trying to resize files with no ImagePart. If no content item is passed as a parameter, file gets to be processed anyway (throwing and logging exception is the file isn't processable - e.g. is a svg file)
* Added reference to Orchard.MediaLibrary.
