* Added publish and delete buttons to backoffice content edit.
* Corrected condition for content unpublishing.
Managed unpublish and delete button for blogs and widgets.
* Some little code refactoring
* Added css classes for unpublish-button.
Condition for delete button visibility now checks for contentItem.Id > 0 instead of IsNew() function
* Removed UnpublishButton from Widget Editor.
* Removed Widget_DeleteButton to use the generic Content_DeleteButton shape and avoid its duplication or confusing management via Placement.info.
* Removed Widget_UnpublishButton shape
* Removed unpublish button show/hide logic from driver.
Added comments to clarify how new Unpublish and Delete actions work.
* EOL fix to Orchard.Widgets.csproj.
* Added unpublish button to edit widget (shown if widget is draftable only)
* Hide Content edit delete button at frontend
* ContentsDriver: removed AdminFilter check to display delete button and checked the content is published before showing the unpublish button.
* Applied some of the proposed formatting changes
* Several refactoring operations
* Autoformatting.
* Stylesheet refactoring and reorganization to properly position backoffice buttons
* Autoformatting
---------
Co-authored-by: Alessandro Agostini <alessandro.agostini@laser-group.com>
Co-authored-by: Matteo Piovanelli <matteo.piovanelli@laser-group.com>
* #8828: Expose Redis API to clear multiple keys using wildcard syntax
* #8828: Rename IRedisCacheStorageProvider to ICacheStorageProviderWithKeyPrefix
* Moving ICacheStorageProviderWithKeyPrefix to Orchard.Caching
---------
Co-authored-by: Benedek Farkas <benedek.farkas@lombiq.com>
* Revert "#8640: Fixing consistency between different Enumeration Field flavors' data storage (#8789)"
This reverts commit fdbb06ba8d.
* Re-adding change to fix that changing the ListMode of an EnumerationField from a multi-select to a single-select flavor shouldn't break the editor
* Code styling in Fields/Enumeration.Edit.cshtml
* Projections: Returning empty list of content items instead of every content item when the query has no filters
* Better solution to skip processing empty filter groups, instead of returning nothing when there's an empty filter group
* Code styling and comments
* Code styling in ProjectionPartDriver, QueryPartDriver and ProjectionManager
* Reverting functional change to ignore empty filter groups
* Code styling in AdminController, ProjectionPartDriver and QueryPartDriver
* Adding notification when saving a Query or a ProjectionPart to warn about the effect of an empty filter group
* Fixing that upgrading Newtonsoft.Json 13.x broke the SpecFlow test execution app
* Fixing that Core.Containers "Show on admin menu" functionality shouldn't depend on the Orchard.Lists feature
* Moving menu.list.png admin menu icon from Orchard.Lists to Core.Containers as menu.container.png
to fix that Containers should have a default admin menu icon
* Fixing conflict between lists and container admin navicon by applying the unused menu.list-definition.png to lists
* Code styling and removing duplicate code
* #6986 Created feature Media Processing Html Filter
* Fixing HtmlAgilityPack and upgrading FW and package version to match Orchard.Specs
* Adapting MediaProcessingHtmlFilter to IHtmlFilter breaking change
* Fixing that Orchard.MediaProcessingHtmlFilter should depend on Orchard.MediaProcessing
* Code styling
* Using regexes instead of HtmlAgilityPack, thanks GHCP
* Updating comments and code styling
* Code styling
* Reworking ProcessContent to use StringBuilder instead of replaces
* Fixing that GetAttributeRegex should find attributes with empty value
* Code styling
* Fixing that detecting the extension works regardless of casing
but it still works with Azure Blob Storage (which is case-sensitive) too
* Optimizing image tag regex
* Caching attribute regexes
* Caching attribute values of img tags
* Simplifying attribute value cache
---------
Co-authored-by: Arjan Noordende <arjan@zumey.com>
* Updating Npgsql to version 4.0.17 (the latest minor version of the closest major version that isn't vulnerable)
https://github.com/OrchardCMS/Orchard/security/dependabot/54
* Fixing that Projection Migrations created indexes with the same name in different tables, which is not supported by PostgreSQL
* Updating Compile workflow with setup and code generation steps
* Updating NHibernate reference and OrchardBasicCorrectness.ruleset path in ModuleTestsCsProj code generation template
* Ignoring CS2008 warning when recompiling with generated modules, because the theme and test projects don't have .cs files
* Generating a test project should also include packages.config
* Fixing the relative path of Orchard.Core and Orchard.Framework in the generated test project
* A bit of code styling in the Compile workflow
* Updating Readme
* Revert "A bit of code styling in the Compile workflow"
This reverts commit 7b01ebbad0.
* Updating System.IdentityModel.Tokens.Jwt and its dependencies in Orchard.Azure.MediaServices
* Using System.IO.Compression instead of DotNetZip
* Upgrading Newtonsoft.Json from 12.0.3 (vulnerable) to 13.0.3
* Updating ModuleRootWebConfig.txt codegen template according to the new Newtonsoft.Json version
* Add AutorouteSettings.AllowSetAsHomePage to control whether user can set a content to display on a home page
* Extending the description of the AllowSetAsHomePage setting
* Updating setting label
---------
Co-authored-by: Benedek Farkas <benedek.farkas@lombiq.com>
* Moved content item publish before triggering form submit events.
Refreshed the content item passed in the context of rules manager and workflow manager.
* Added version to content manager get call after conditionally publishing the content item.
* Removed ambiguity to LocalizedTaxonomyController actions.
* Properly added ApplyPreRequest to the action.
* Code refactoring
* Code autoformatting
* Sorting using
* Overriding GetTaxonomy action
* Calling base GetTaxonomy action
* Removing ApplyPreRequest function
* Removed ApplyPreRequest function
* Added virtual keyword to GetTaxonomy action in LocalizedTaxonomyController
---------
Co-authored-by: Benedek Farkas <benedek.farkas@lombiq.com>
* #6981 Normalized image profile path hash and added profile purging
* Profile purge functions rather belong in IImageProfileService
* Deleting an Image Profile now also removes all its files too
* Comment formatting
* Caching the value of the "Orchard.MediaProcessing.NormalizePath" app setting in ImageProfileManager
* Code styling in ImageProfileManager
* Formatting and code styling ImageProfileManager
---------
Co-authored-by: Arjan Noordende <arjan@zumey.com>
* 6748: Stricter file and folder name validation (#6792)
* Media Library: More strict file and folder name validation, fixes#6748
* Resetting MediaLibraryService changes to 1.10.x
* Code styling in FileSystemStorageProvider
* Adding string file and folder name validation to FileSystemStorageProvider, so that MediaLibrary components don't need to do it separately
* Applying the same file and folder name validation to AzureFileSystem too
* Code styling and fixes in AzureFileSystem, MediaLibrary and IStorageProvider
* Simplifying invalid character detection
* Code styling
* Adding InvalidNameCharacterException to be able to handle invalid characters precisely at various user-facing components
* Updating MediaLibrary not to log an error when a file can't be uploaded due to invalid characters
---------
Co-authored-by: Lombiq <github@lombiq.com>
* #6793: Adding a content-independent culture selector shape for the front-end (#8784)
* Adds a new CultureSelector shape for front-end
* fixed query string culture change
* Moving NameValueCollectionExtensions from Orchard.DynamicForms and Orchard.Localization to Orchard.Framework
* Code styling
* Simplifying UserCultureSelectorController and removing the addition of the culture to the query string
* EOF empty lines and code styling
* Fixing that the main Orchard.Localization should depend on Orchard.Autoroute
* Code styling in LocalizationService
* Updating LocalizationService to not have to use IEnumerable.Single
* Matching culture name matching in LocalizationService culture- and casing-invariant
---------
Co-authored-by: Sergio Navarro <jersio@hotmail.com>
Co-authored-by: psp589 <pablosanchez589@gmail.com>
* #8640: Fixing consistency between different Enumeration Field flavors' data storage (#8789)
* Reworking EnumerationField's logic to store/retrieve its (selected) values
* Fixing exception when creating new item with CheckboxList flavor, adding more nullchecks and compactness
* Code styling in EnumerationFieldDriver
* Code styling in EnumerationField editor template
* Fixing that EnumerationFieldDriver and the EnumerationField editor template should read SelectedValues instead of Values directly
---------
Co-authored-by: Matteo Piovanelli <MatteoPiovanelli-Laser@users.noreply.github.com>
* Fixing merge
---------
Co-authored-by: Lombiq <github@lombiq.com>
Co-authored-by: Sergio Navarro <jersio@hotmail.com>
Co-authored-by: psp589 <pablosanchez589@gmail.com>
Co-authored-by: Matteo Piovanelli <MatteoPiovanelli-Laser@users.noreply.github.com>
* IHtmlFilter and TokenFilter improvements and bugfixes.
This changeset unifies the two separate TokenFilter implementations (one for BodyPart, TextField, etc and another one for certain elements such as Html).
It also fixes a bug with the TokenFilter when executing for HtmlWidget, where the wrong content item is being recorded by the handler (the original implementation).
Thirdly, it removes awkward code repetition by moving filter execution into a dedicated HtmlFilterRunner service.
* Renaming IHtmlFilterRunner to IHtmlFilterProcessor (and its references)
* Applying IHtmlFilterProcessor to HtmlMenuItems too + code styling in BodyPartDriver
* Fixing FeedControllerTests.CorePartValuesAreExtracted
* Code styling
---------
Co-authored-by: Jean-Thierry Kéchichian <jean-thierry.kechichian@wanadoo.fr>
Co-authored-by: Sipke Schoorstra <sipke@ideliverable.com>
Co-authored-by: Benedek Farkas <benedek.farkas@lombiq.com>
* Reworking EnumerationField's logic to store/retrieve its (selected) values
* Fixing exception when creating new item with CheckboxList flavor, adding more nullchecks and compactness
* Code styling in EnumerationFieldDriver
* Code styling in EnumerationField editor template
* Fixing that EnumerationFieldDriver and the EnumerationField editor template should read SelectedValues instead of Values directly
---------
Co-authored-by: Matteo Piovanelli <MatteoPiovanelli-Laser@users.noreply.github.com>
* Adds a new CultureSelector shape for front-end
* fixed query string culture change
* Moving NameValueCollectionExtensions from Orchard.DynamicForms and Orchard.Localization to Orchard.Framework
* Code styling
* Simplifying UserCultureSelectorController and removing the addition of the culture to the query string
* EOF empty lines and code styling
* Fixing that the main Orchard.Localization should depend on Orchard.Autoroute
* Code styling in LocalizationService
* Updating LocalizationService to not have to use IEnumerable.Single
* Matching culture name matching in LocalizationService culture- and casing-invariant
---------
Co-authored-by: Sergio Navarro <jersio@hotmail.com>
Co-authored-by: psp589 <pablosanchez589@gmail.com>
* Media Library: More strict file and folder name validation, fixes#6748
* Resetting MediaLibraryService changes to 1.10.x
* Code styling in FileSystemStorageProvider
* Adding string file and folder name validation to FileSystemStorageProvider, so that MediaLibrary components don't need to do it separately
* Applying the same file and folder name validation to AzureFileSystem too
* Code styling and fixes in AzureFileSystem, MediaLibrary and IStorageProvider
* Simplifying invalid character detection
* Code styling
* Adding InvalidNameCharacterException to be able to handle invalid characters precisely at various user-facing components
* Updating MediaLibrary not to log an error when a file can't be uploaded due to invalid characters
---------
Co-authored-by: Lombiq <github@lombiq.com>
* Updating Microsoft.IdentityModel.* packages from 5.2.4 to 5.7.0
* Updating OpenId packages from 4.0.0 to 4.2.2 to mach the version of Microsoft.Owin
* Fixing assembly binding redirects in Orchard.Web/Web.config
* OpenId: Updating Microsoft.IdentityModel.Tokens.* packages to version 5.7.0.0 to match Microsoft.IdentityModel.Tokens
* OpenId: Updating Microsoft.IdentityModel.Protocols packages to 5.7.0.0 too
* The return of System.Net.Http assembly binding redirects
* Adding a checkbox to StringFilterForm to control whether an empty value should cause the filter to be skipped
* Removing StringOperator.ContainsAnyIfProvided as its now obsolete due to the IgnoreFilterIfValueIsEmpty checkbox setting
* Code styling in StringFilterForm
* Adding missing T-string
* Adding migration step to upgrade from using the ContainsAnyIfProvided operator in StringFilterForm
* Add Excel Export functionality to DynamicForms.
* Using the net46-targeted DLL of DocumentFormat.OpenXml instead of net40
* Updating DocumentFormat.OpenXml to latest (3.0.2) version
* Code styling
---------
Co-authored-by: Benedek Farkas <benedek.farkas@lombiq.com>
* Updating rebuilt client-side assets that only changed in terms of sourceMappingURL
* Updating rebuilt client-side assets that changed functionally
* Fixing/simplifying Layout editor toolbox stickyness and height restriction to viewport
* Compile workflow: Upgrading actions/checkout and microsoft/setup-msbuild actions to their latest versions
* Compile workflow: Adding steps to validate that the client-side assets are up-to-date
* Compile workflow: Temporarily disabling MSBuild steps
* Moving client-side assets build to a separate job in the compile workflow
* Updating client-side compilation job
* Temporarily disabling the .NET build
* Separating package install from asset rebuild
* Adding debug command
* Fixing working directory
* Debugging
* Attempting to get rid of false positives due to line ending changes
* Removing debug code
* Checking asset validation by modifying Orchard.Resources/Assets/Less/Bootstrap/variables.less, but not its derivatives
* Revert "Checking asset validation by modifying Orchard.Resources/Assets/Less/Bootstrap/variables.less, but not its derivatives"
This reverts commit 3fc9b8362b.
* Revert "Temporarily disabling the .NET build"
This reverts commit 2a8fef7793.
* Fixing error message when client-side assets are not up-to-date
* Update TaxonomyFieldList.cshtml
Missing closing brackets after providing data for the ajax call
* As requested, added an empty line at the end of file
* AliasUI: removing UrlPrefix addition to url. Fixing issue in Href() that strips first / in urls for sites using UrlPrefix
* Simplifying fix for WebViewPage.Href for tenants with URL prefix
* Code styling WebViewPage
---------
Co-authored-by: Benedek Farkas <benedek.farkas@lombiq.com>
* Upgrading projects, code generation templates and Specflow app to use Microsoft.CodeDom.Providers.DotNetCompilerPlatform 4.1.0 (latest)
* Updating csprojs not to define LangVersion separately in Release and Debug mode, setting it to "default" instead of "latest"
* Restricting C# language version to 7.3
* Downgrading SmtpMessageChannel.cs to C# 7.3
* Setting MvcBuildViews = false in the remaining csprojs that reference DotNetCompilerPlatform, like the others
* Setting RoslynCopyToOutDir = false in each csproj that references DotNetCompilerPlatform
See https://github.com/aspnet/RoslynCodeDomProvider?tab=readme-ov-file#build-time-options
- We only need Orchard.Web to include the Roslyn tools in its bin folder, the other csprojs only need the DLL reference
- We could simply remove the targets import in these csprojs, but it will be re-added when the package is updated, so this is cleaner/easier
* We don't actually need <MvcBuildViews>false</MvcBuildViews> in csprojs
* Orchard.Web: Copying Roslyn files to the output folder using the provided target (CopyRoslynCompilerFilesToOutputDirectory) instead of our custom one
* Orchard.proj: Factoring out a part of the Compile target into the DevCompile target and removing BuildViews target
- For a simple local build (just to validate that the solution builds), we don't actually need that second build that copies files to the output folder.
- CI builds (Test, Spec, etc.) that operate on the build output folder are unaffected, because Compile calls DevCompile
- The BuildViews target is not really necessary, just call any other target (Compile, DevCompile, Spec, etc.) with "/p:MvcBuildViews=true"
* Removing incorrect comment about Razor IntelliSense
* Removing VBCodeProvider configuration from Web.config files
* Getting rid of Microsoft.CodeDom.Providers.DotNetCompilerPlatform.targets imports and associated configuration except in Orchard.Web.csproj
* Adding VB compiler configuration to src/Orchard.Web/Web.config, because it would be readded on rebuild by the imported target anyway
* wip fixing Fields/TaxonomyFieldList.cshtml
* restored selector for expando label/handle
* cleanup
* fixed comparison to find parent blog
# Conflicts:
# src/Orchard.Web/Modules/Orchard.Blogs/BlogsLocalizationExtensions/Handlers/BlogPostPartHandler.cs
* fixed initialization of localizedtaxonomyfields
* Checks culture equality based on strings instead of culture records
* If term is culture neutral it is added to the applied terms list without looking for its localization.
# Conflicts:
# src/Orchard.Web/Modules/Orchard.Taxonomies/Controllers/LocalizedTaxonomyController.cs
* Added AdminLocalizedTaxonomyController to properly managed localized taxonomies back office calls.
# Conflicts:
# src/Orchard.Web/Modules/Orchard.Taxonomies/Controllers/LocalizedTaxonomyController.cs
# src/Orchard.Web/Modules/Orchard.Taxonomies/Views/EditorTemplates/Fields/TaxonomyFieldList.cshtml
* Added selectedValues parameter to controller call
---------
Co-authored-by: HermesSbicego-Laser <hermes.sbicego@laser-group.com>
Co-authored-by: Andrea Piovanelli <andrea.piovanelli@laser-group.com>
Removed support for eariler MSBuild versions (they cannot compile SmtpMessageChannel.cs)
Updated lib/nuget/nuget.exe to latest version (6.9.1.3) (required for package restoration)
Modified Obsolete attribute in SmtpSettingsPart.cs so the solution builds with VS2019
