From 23ee2d623a14ef40739538363f9d363672bc188a Mon Sep 17 00:00:00 2001 From: Looly Date: Tue, 1 Dec 2020 15:06:03 +0800 Subject: [PATCH] fix code --- .../hutool/core/util/PrimitiveArrayUtil.java | 32 +++++-------------- .../cn/hutool/core/util/ArrayUtilTest.java | 7 ++++ 2 files changed, 15 insertions(+), 24 deletions(-) diff --git a/hutool-core/src/main/java/cn/hutool/core/util/PrimitiveArrayUtil.java b/hutool-core/src/main/java/cn/hutool/core/util/PrimitiveArrayUtil.java index b77130d3a..2e9a21340 100644 --- a/hutool-core/src/main/java/cn/hutool/core/util/PrimitiveArrayUtil.java +++ b/hutool-core/src/main/java/cn/hutool/core/util/PrimitiveArrayUtil.java @@ -2039,9 +2039,7 @@ public class PrimitiveArrayUtil { int j = Math.min(array.length, endIndexExclusive) - 1; long tmp; while (j > i) { - tmp = array[j]; - array[j] = array[i]; - array[i] = tmp; + swap(array, i, j); j--; i++; } @@ -2076,9 +2074,7 @@ public class PrimitiveArrayUtil { int j = Math.min(array.length, endIndexExclusive) - 1; int tmp; while (j > i) { - tmp = array[j]; - array[j] = array[i]; - array[i] = tmp; + swap(array, i, j); j--; i++; } @@ -2113,9 +2109,7 @@ public class PrimitiveArrayUtil { int j = Math.min(array.length, endIndexExclusive) - 1; short tmp; while (j > i) { - tmp = array[j]; - array[j] = array[i]; - array[i] = tmp; + swap(array, i, j); j--; i++; } @@ -2150,9 +2144,7 @@ public class PrimitiveArrayUtil { int j = Math.min(array.length, endIndexExclusive) - 1; char tmp; while (j > i) { - tmp = array[j]; - array[j] = array[i]; - array[i] = tmp; + swap(array, i, j); j--; i++; } @@ -2187,9 +2179,7 @@ public class PrimitiveArrayUtil { int j = Math.min(array.length, endIndexExclusive) - 1; byte tmp; while (j > i) { - tmp = array[j]; - array[j] = array[i]; - array[i] = tmp; + swap(array, i, j); j--; i++; } @@ -2224,9 +2214,7 @@ public class PrimitiveArrayUtil { int j = Math.min(array.length, endIndexExclusive) - 1; double tmp; while (j > i) { - tmp = array[j]; - array[j] = array[i]; - array[i] = tmp; + swap(array, i, j); j--; i++; } @@ -2261,9 +2249,7 @@ public class PrimitiveArrayUtil { int j = Math.min(array.length, endIndexExclusive) - 1; float tmp; while (j > i) { - tmp = array[j]; - array[j] = array[i]; - array[i] = tmp; + swap(array, i, j); j--; i++; } @@ -2298,9 +2284,7 @@ public class PrimitiveArrayUtil { int j = Math.min(array.length, endIndexExclusive) - 1; boolean tmp; while (j > i) { - tmp = array[j]; - array[j] = array[i]; - array[i] = tmp; + swap(array, i, j); j--; i++; } diff --git a/hutool-core/src/test/java/cn/hutool/core/util/ArrayUtilTest.java b/hutool-core/src/test/java/cn/hutool/core/util/ArrayUtilTest.java index 948ea96c0..1c72f4a8a 100644 --- a/hutool-core/src/test/java/cn/hutool/core/util/ArrayUtilTest.java +++ b/hutool-core/src/test/java/cn/hutool/core/util/ArrayUtilTest.java @@ -377,4 +377,11 @@ public class ArrayUtilTest { i = ArrayUtil.lastIndexOfSub(null, b); Assert.assertEquals(-1, i); } + + @Test + public void reverseTest(){ + int[] a = {1,2,3,4}; + final int[] reverse = ArrayUtil.reverse(a); + Assert.assertArrayEquals(new int[]{4,3,2,1}, reverse); + } }