lsm/initializr
1
0
Fork 0
mirror of https://gitee.com/dcren/initializr.git synced 2025-09-19 18:22:26 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tune metadata caching

Browse Source 
This commit reduces the cache metadata lookup to 2h so that clients can
see new Spring Boot version faster. It also offers an option for
custom instance to override the cache strategy any way they like.

Closes gh-979
This commit is contained in:
Stephane Nicoll
2019-09-06 12:00:47 +02:00
parent 88f986b7c1
commit 2a183354b2
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
initializr-web/src/main/java/io/spring/initializr/web/controller/ProjectMetadataController.java
View File

@@ -85,6 +85,17 @@ public class ProjectMetadataController extends AbstractMetadataController {
return dependenciesFor(InitializrMetadataVersion.V2_1, bootVersion); return dependenciesFor(InitializrMetadataVersion.V2_1, bootVersion);
} }
/**
* Return the {@link CacheControl} response headers to use for the specified
* {@link InitializrMetadata metadata}. If no cache should be applied
* {@link CacheControl#empty()} can be used.
* @param metadata the metadata about to be exposed
* @return the {@code Cache-Control} headers to use
*/
protected CacheControl determineCacheControlFor(InitializrMetadata metadata) {
return CacheControl.maxAge(2, TimeUnit.HOURS);
}
private ResponseEntity<String> dependenciesFor(InitializrMetadataVersion version, String bootVersion) { private ResponseEntity<String> dependenciesFor(InitializrMetadataVersion version, String bootVersion) {
InitializrMetadata metadata = this.metadataProvider.get(); InitializrMetadata metadata = this.metadataProvider.get();
Version v = (bootVersion != null) ? Version.parse(bootVersion) Version v = (bootVersion != null) ? Version.parse(bootVersion)
@@ -92,7 +103,7 @@ public class ProjectMetadataController extends AbstractMetadataController {
DependencyMetadata dependencyMetadata = this.dependencyMetadataProvider.get(metadata, v); DependencyMetadata dependencyMetadata = this.dependencyMetadataProvider.get(metadata, v);
String content = new DependencyMetadataV21JsonMapper().write(dependencyMetadata); String content = new DependencyMetadataV21JsonMapper().write(dependencyMetadata);
return ResponseEntity.ok().contentType(version.getMediaType()).eTag(createUniqueId(content)) return ResponseEntity.ok().contentType(version.getMediaType()).eTag(createUniqueId(content))
.cacheControl(CacheControl.maxAge(7, TimeUnit.DAYS)).body(content); .cacheControl(determineCacheControlFor(metadata)).body(content);
} }
private ResponseEntity<String> serviceCapabilitiesFor(InitializrMetadataVersion version) { private ResponseEntity<String> serviceCapabilitiesFor(InitializrMetadataVersion version) {
@@ -101,9 +112,10 @@ public class ProjectMetadataController extends AbstractMetadataController {
private ResponseEntity<String> serviceCapabilitiesFor(InitializrMetadataVersion version, MediaType contentType) { private ResponseEntity<String> serviceCapabilitiesFor(InitializrMetadataVersion version, MediaType contentType) {
String appUrl = generateAppUrl(); String appUrl = generateAppUrl();
String content = getJsonMapper(version).write(this.metadataProvider.get(), appUrl); InitializrMetadata metadata = this.metadataProvider.get();
String content = getJsonMapper(version).write(metadata, appUrl);
return ResponseEntity.ok().contentType(contentType).eTag(createUniqueId(content)).varyBy("Accept") return ResponseEntity.ok().contentType(contentType).eTag(createUniqueId(content)).varyBy("Accept")
.cacheControl(CacheControl.maxAge(7, TimeUnit.DAYS)).body(content); .cacheControl(determineCacheControlFor(metadata)).body(content);
} }
private static InitializrMetadataJsonMapper getJsonMapper(InitializrMetadataVersion version) { private static InitializrMetadataJsonMapper getJsonMapper(InitializrMetadataVersion version) {