lsm/initializr
1
0
Fork 0
mirror of https://gitee.com/dcren/initializr.git synced 2025-09-19 01:58:16 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Polish "Allow adding <extensions>true</extensions> to plugin config"

Browse Source 
See gh-921
This commit is contained in:
Andy Wilkinson
2019-06-10 14:12:54 +01:00
parent 3e86a446a8
commit 50160d4931
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
initializr-generator/src/main/java/io/spring/initializr/generator/buildsystem/maven/MavenBuildWriter.java
View File

@@ -271,8 +271,8 @@ public class MavenBuildWriter {
writeSingleElement(writer, "groupId", plugin.getGroupId());
writeSingleElement(writer, "artifactId", plugin.getArtifactId());
writeSingleElement(writer, "version", plugin.getVersion());
if (plugin.shouldLoadExtensions()) {
writeSingleElement(writer, "extensions", Boolean.toString(true));
if (plugin.isExtensions()) {
writeSingleElement(writer, "extensions", "true");
}
writePluginConfiguration(writer, plugin.getConfiguration());
if (!plugin.getExecutions().isEmpty()) {

2
initializr-generator/src/main/java/io/spring/initializr/generator/buildsystem/maven/MavenPlugin.java
View File

@@ -102,7 +102,7 @@ public class MavenPlugin {
: this.configurationCustomization.build();
}
public boolean shouldLoadExtensions() {
public boolean isExtensions() {
return this.extensions;
}

4
initializr-generator/src/test/java/io/spring/initializr/generator/buildsystem/maven/MavenBuildTests.java
View File

@@ -102,7 +102,7 @@ class MavenBuildTests {
MavenPlugin testPlugin = build.getPlugins().get(0);
assertThat(testPlugin.shouldLoadExtensions()).isFalse();
assertThat(testPlugin.isExtensions()).isFalse();
}
@Test
@@ -112,7 +112,7 @@ class MavenBuildTests {
MavenPlugin testPlugin = build.getPlugins().get(0);
assertThat(testPlugin.shouldLoadExtensions()).isTrue();
assertThat(testPlugin.isExtensions()).isTrue();
}
}

2
initializr-generator/src/test/java/io/spring/initializr/generator/buildsystem/maven/MavenBuildWriterTests.java
View File

@@ -473,7 +473,7 @@ class MavenBuildWriterTests {
NodeAssert plugin = pom.nodeAtPath("/project/build/plugins/plugin");
assertThat(plugin).textAtPath("groupId").isEqualTo("com.example.demo");
assertThat(plugin).textAtPath("artifactId").isEqualTo("demo-plugin");
assertThat(plugin).textAtPath("extensions").isEqualTo(Boolean.toString(true));
assertThat(plugin).textAtPath("extensions").isEqualTo("true");
});
}