From 593759f321da584d2fdd0780e52588509ae793ac Mon Sep 17 00:00:00 2001 From: Phillip Webb Date: Thu, 12 Apr 2018 17:14:55 -0700 Subject: [PATCH] Fix IDE warnings Fix warnings shown in Eclipse --- .../src/main/java/io/spring/initializr/metadata/Type.java | 2 -- .../spring/initializr/test/generator/GradleBuildAssert.java | 2 ++ .../java/io/spring/initializr/test/generator/PomAssert.java | 2 ++ .../io/spring/initializr/test/generator/ProjectAssert.java | 5 +++++ .../java/io/spring/initializr/service/InitializrService.java | 1 - .../service/info/CloudFoundryInfoContributorTests.java | 1 + .../initializr/web/AbstractInitializrIntegrationTests.java | 4 ++++ 7 files changed, 14 insertions(+), 3 deletions(-) diff --git a/initializr-generator/src/main/java/io/spring/initializr/metadata/Type.java b/initializr-generator/src/main/java/io/spring/initializr/metadata/Type.java index f0694013..e880ee13 100644 --- a/initializr-generator/src/main/java/io/spring/initializr/metadata/Type.java +++ b/initializr-generator/src/main/java/io/spring/initializr/metadata/Type.java @@ -53,12 +53,10 @@ public class Type extends DefaultMetadataElement implements Describable { this.description = description; } - @SuppressWarnings("deprecation") public String getStsId() { return this.stsId; } - @SuppressWarnings("deprecation") public void setStsId(String stsId) { this.stsId = stsId; } diff --git a/initializr-generator/src/test/java/io/spring/initializr/test/generator/GradleBuildAssert.java b/initializr-generator/src/test/java/io/spring/initializr/test/generator/GradleBuildAssert.java index 413ef29a..d709511b 100644 --- a/initializr-generator/src/test/java/io/spring/initializr/test/generator/GradleBuildAssert.java +++ b/initializr-generator/src/test/java/io/spring/initializr/test/generator/GradleBuildAssert.java @@ -35,6 +35,8 @@ public class GradleBuildAssert { /** * Validate that this generated gradle build validates against its request. + * @param request the source request + * @return a gradle assert */ public GradleBuildAssert validateProjectRequest(ProjectRequest request) { return hasVersion(request.getVersion()).hasBootVersion(request.getBootVersion()) diff --git a/initializr-generator/src/test/java/io/spring/initializr/test/generator/PomAssert.java b/initializr-generator/src/test/java/io/spring/initializr/test/generator/PomAssert.java index 261fe7f3..6171ade1 100644 --- a/initializr-generator/src/test/java/io/spring/initializr/test/generator/PomAssert.java +++ b/initializr-generator/src/test/java/io/spring/initializr/test/generator/PomAssert.java @@ -81,6 +81,8 @@ public class PomAssert { /** * Validate that this generated pom validates against its request. + * @param request the source request + * @return a POM assert */ public PomAssert validateProjectRequest(ProjectRequest request) { return hasGroupId(request.getGroupId()).hasArtifactId(request.getArtifactId()) diff --git a/initializr-generator/src/test/java/io/spring/initializr/test/generator/ProjectAssert.java b/initializr-generator/src/test/java/io/spring/initializr/test/generator/ProjectAssert.java index 971a38c0..41dd5e15 100644 --- a/initializr-generator/src/test/java/io/spring/initializr/test/generator/ProjectAssert.java +++ b/initializr-generator/src/test/java/io/spring/initializr/test/generator/ProjectAssert.java @@ -80,6 +80,7 @@ public class ProjectAssert { /** * Return a {@link PomAssert} for this project. + * @return a POM assert */ public PomAssert pomAssert() { try { @@ -93,6 +94,7 @@ public class ProjectAssert { /** * Return a {@link GradleBuildAssert} for this project. + * @return a gradle assert */ public GradleBuildAssert gradleBuildAssert() { try { @@ -106,6 +108,7 @@ public class ProjectAssert { /** * Return a {@link GradleSettingsAssert} for this project. + * @return A gradle settings assert */ public GradleSettingsAssert gradleSettingsAssert() { try { @@ -120,6 +123,8 @@ public class ProjectAssert { /** * Return a {@link SourceCodeAssert} for the specified source code. + * @param sourceCodePath the source code path + * @return a source assert */ public SourceCodeAssert sourceCodeAssert(String sourceCodePath) { hasFile(sourceCodePath); diff --git a/initializr-service/src/main/java/io/spring/initializr/service/InitializrService.java b/initializr-service/src/main/java/io/spring/initializr/service/InitializrService.java index f7125410..412b1968 100644 --- a/initializr-service/src/main/java/io/spring/initializr/service/InitializrService.java +++ b/initializr-service/src/main/java/io/spring/initializr/service/InitializrService.java @@ -45,7 +45,6 @@ public class InitializrService { } @Bean - @SuppressWarnings("deprecation") public LegacyStsController legacyStsController( InitializrMetadataProvider metadataProvider, ResourceUrlProvider resourceUrlProvider) { diff --git a/initializr-service/src/test/java/io/spring/initializr/service/info/CloudFoundryInfoContributorTests.java b/initializr-service/src/test/java/io/spring/initializr/service/info/CloudFoundryInfoContributorTests.java index 9f36cd7c..f24426dd 100755 --- a/initializr-service/src/test/java/io/spring/initializr/service/info/CloudFoundryInfoContributorTests.java +++ b/initializr-service/src/test/java/io/spring/initializr/service/info/CloudFoundryInfoContributorTests.java @@ -42,6 +42,7 @@ public class CloudFoundryInfoContributorTests { } @Test + @SuppressWarnings("unchecked") public void applicationName() { this.environment.setProperty("vcap.application.name", "foo-bar"); Info info = getInfo(this.environment); diff --git a/initializr-web/src/test/java/io/spring/initializr/web/AbstractInitializrIntegrationTests.java b/initializr-web/src/test/java/io/spring/initializr/web/AbstractInitializrIntegrationTests.java index 2e276a92..cca4f8b1 100755 --- a/initializr-web/src/test/java/io/spring/initializr/web/AbstractInitializrIntegrationTests.java +++ b/initializr-web/src/test/java/io/spring/initializr/web/AbstractInitializrIntegrationTests.java @@ -155,6 +155,8 @@ public abstract class AbstractInitializrIntegrationTests { /** * Return a {@link ProjectAssert} for the following archive content. + * @param content the source content + * @return a project assert */ protected ProjectAssert zipProjectAssert(byte[] content) { return projectAssert(content, ArchiveType.ZIP); @@ -162,6 +164,8 @@ public abstract class AbstractInitializrIntegrationTests { /** * Return a {@link ProjectAssert} for the following TGZ archive. + * @param content the source content + * @return a project assert */ protected ProjectAssert tgzProjectAssert(byte[] content) { return projectAssert(content, ArchiveType.TGZ);