From 5f0bb06e8f4738a3ab378f9d2097111b6386a551 Mon Sep 17 00:00:00 2001 From: Stephane Nicoll Date: Sat, 25 Oct 2014 15:15:46 +0200 Subject: [PATCH] Fix potential NPE with unknown Spring Boot starter Fixes gh-41 --- .../groovy/io/spring/initializr/InitializrMetadata.groovy | 1 + .../initializr/web/MainControllerIntegrationTests.groovy | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/initializr/src/main/groovy/io/spring/initializr/InitializrMetadata.groovy b/initializr/src/main/groovy/io/spring/initializr/InitializrMetadata.groovy index 6b7ee3d1..325ab7b2 100644 --- a/initializr/src/main/groovy/io/spring/initializr/InitializrMetadata.groovy +++ b/initializr/src/main/groovy/io/spring/initializr/InitializrMetadata.groovy @@ -223,6 +223,7 @@ class InitializrMetadata { def asSpringBootStarter(String name) { groupId = 'org.springframework.boot' artifactId = StringUtils.hasText(name) ? 'spring-boot-starter-' + name : 'spring-boot-starter' + id = name } /** diff --git a/initializr/src/test/groovy/io/spring/initializr/web/MainControllerIntegrationTests.groovy b/initializr/src/test/groovy/io/spring/initializr/web/MainControllerIntegrationTests.groovy index 96886fe3..53154428 100644 --- a/initializr/src/test/groovy/io/spring/initializr/web/MainControllerIntegrationTests.groovy +++ b/initializr/src/test/groovy/io/spring/initializr/web/MainControllerIntegrationTests.groovy @@ -144,6 +144,11 @@ class MainControllerIntegrationTests extends AbstractInitializrControllerIntegra slurper.parseText(restTemplate.getForObject(createUrl('/metrics'), String)) } + @Test + void downloadWithUnknownSpringBootStarter() { // Simple id are accepted as spring-boot-starter + downloadZip('/starter.zip?style=foo').pomAssert().hasSpringBootStarterDependency('foo') + } + // Existing tests for backward compatibility @Test