lsm/initializr
1
0
Fork 0
mirror of https://gitee.com/dcren/initializr.git synced 2025-07-17 10:41:57 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add parentheses for method invocations with no argument

Browse Source 
Closes gh-907
This commit is contained in:
Stephane Nicoll 2019-05-21 11:39:04 +02:00
parent fd8ebf728c
commit 75228ba4a3
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
initializr-generator/src/main/java/io/spring/initializr/generator/buildsystem/gradle/GroovyDslGradleBuildWriter.java
View File

@ -189,8 +189,9 @@ public class GroovyDslGradleBuildWriter extends GradleBuildWriter {
@Override @Override
protected String invocationAsString( protected String invocationAsString(
GradleBuild.TaskCustomization.Invocation invocation) { GradleBuild.TaskCustomization.Invocation invocation) {
return invocation.getTarget() + " " String arguments = (invocation.getArguments().isEmpty()) ? "()"
+ String.join(", ", invocation.getArguments()); : " " + String.join(", ", invocation.getArguments());
return invocation.getTarget() + arguments;
} }
@Override @Override

8
initializr-generator/src/test/java/io/spring/initializr/generator/buildsystem/gradle/GroovyDslGradleBuildWriterTests.java
View File

@ -183,6 +183,14 @@ class GroovyDslGradleBuildWriterTests {
" dependsOn test", "}"); " dependsOn test", "}");
} }
@Test
void gradleBuildWithTaskCustomizedWithInvocationAndNoArgument() throws IOException {
GradleBuild build = new GradleBuild();
build.customizeTask("test", (task) -> task.invoke("myMethod"));
List<String> lines = generateBuild(build);
assertThat(lines).containsSequence("test {", " myMethod()", "}");
}
@Test @Test
void gradleBuildWithTaskCustomizedWithAssignments() throws IOException { void gradleBuildWithTaskCustomizedWithAssignments() throws IOException {
GradleBuild build = new GradleBuild(); GradleBuild build = new GradleBuild();