From 4a2b3edcc89da2819e3e122fa6c239894a113be0 Mon Sep 17 00:00:00 2001 From: markstrecker <35345080+markstrecker@users.noreply.github.com> Date: Fri, 11 Oct 2019 10:28:15 -0400 Subject: [PATCH 1/2] Fix Groovy array declaration See gh-1016 --- .../generator/language/groovy/GroovySourceCodeWriter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/initializr-generator/src/main/java/io/spring/initializr/generator/language/groovy/GroovySourceCodeWriter.java b/initializr-generator/src/main/java/io/spring/initializr/generator/language/groovy/GroovySourceCodeWriter.java index 7b87173b..1e443a2f 100644 --- a/initializr-generator/src/main/java/io/spring/initializr/generator/language/groovy/GroovySourceCodeWriter.java +++ b/initializr-generator/src/main/java/io/spring/initializr/generator/language/groovy/GroovySourceCodeWriter.java @@ -179,7 +179,7 @@ public class GroovySourceCodeWriter implements SourceCodeWriter values, Function formatter) { String result = values.stream().map(formatter).collect(Collectors.joining(", ")); - return (values.size() > 1) ? "{ " + result + " }" : result; + return (values.size() > 1) ? "[ " + result + " ]" : result; } private void writeFieldDeclaration(IndentingWriter writer, GroovyFieldDeclaration fieldDeclaration) { From cddd4c7b5b737a3212d4038eac31d8e7ceeb60a2 Mon Sep 17 00:00:00 2001 From: Stephane Nicoll Date: Mon, 21 Oct 2019 14:07:39 +0200 Subject: [PATCH 2/2] Polish "Fix Groovy array declaration" See gh-1016 --- .../generator/language/groovy/GroovySourceCodeWriterTests.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/initializr-generator/src/test/java/io/spring/initializr/generator/language/groovy/GroovySourceCodeWriterTests.java b/initializr-generator/src/test/java/io/spring/initializr/generator/language/groovy/GroovySourceCodeWriterTests.java index 04d65f47..a263ed28 100644 --- a/initializr-generator/src/test/java/io/spring/initializr/generator/language/groovy/GroovySourceCodeWriterTests.java +++ b/initializr-generator/src/test/java/io/spring/initializr/generator/language/groovy/GroovySourceCodeWriterTests.java @@ -243,7 +243,7 @@ class GroovySourceCodeWriterTests { List lines = writeClassAnnotation(Annotation.name("org.springframework.test.TestApplication", (builder) -> builder.attribute("target", Class.class, "com.example.One", "com.example.Two"))); assertThat(lines).containsExactly("package com.example", "", "import com.example.One", "import com.example.Two", - "import org.springframework.test.TestApplication", "", "@TestApplication(target = { One, Two })", + "import org.springframework.test.TestApplication", "", "@TestApplication(target = [ One, Two ])", "class Test {", "", "}"); }