Avoid overriding baseName for jar/war task

Closes gh-381
This commit is contained in:
Stephane Nicoll
2017-03-15 14:19:11 +01:00
parent 9e35b8acd6
commit c6194d2357
13 changed files with 14 additions and 59 deletions

View File

@@ -41,11 +41,7 @@ apply plugin: 'io.spring.dependency-management'
apply plugin: 'war' apply plugin: 'war'
{{/war}} {{/war}}
{{#war}}war{{/war}}{{^war}}jar{{/war}} { version = '{{version}}'
baseName = '{{artifactId}}'
version = '{{version}}'
}
sourceCompatibility = {{javaVersion}} sourceCompatibility = {{javaVersion}}
repositories { repositories {

View File

@@ -168,8 +168,8 @@ public class ProjectGeneratorTests extends AbstractProjectGeneratorTests {
request.setType("gradle-project"); request.setType("gradle-project");
generateProject(request).isJavaWarProject().isGradleProject().gradleBuildAssert() generateProject(request).isJavaWarProject().isGradleProject().gradleBuildAssert()
// This is tagged as web facet so it brings the web one // This is tagged as web facet so it brings the web one
.contains("compile('org.foo:thymeleaf')").contains("war {") .contains("apply plugin: 'war'")
.contains("compile('org.foo:thymeleaf')").contains("apply plugin: 'war'") .contains("compile('org.foo:thymeleaf')")
.doesNotContain( .doesNotContain(
"compile('org.springframework.boot:spring-boot-starter-web')") "compile('org.springframework.boot:spring-boot-starter-web')")
.contains( .contains(

View File

@@ -38,8 +38,7 @@ public class GradleBuildAssert {
* Validate that this generated gradle build validates against its request. * Validate that this generated gradle build validates against its request.
*/ */
public GradleBuildAssert validateProjectRequest(ProjectRequest request) { public GradleBuildAssert validateProjectRequest(ProjectRequest request) {
return hasArtifactId(request.getArtifactId()).hasVersion(request.getVersion()) return hasVersion(request.getVersion()).hasBootVersion(request.getBootVersion())
.hasBootVersion(request.getBootVersion())
.hasJavaVersion(request.getJavaVersion()); .hasJavaVersion(request.getJavaVersion());
} }

View File

@@ -16,11 +16,7 @@ apply plugin: 'eclipse'
apply plugin: 'spring-boot' apply plugin: 'spring-boot'
apply plugin: 'io.spring.dependency-management' apply plugin: 'io.spring.dependency-management'
jar { version = '0.0.1-SNAPSHOT'
baseName = 'demo'
version = '0.0.1-SNAPSHOT'
}
sourceCompatibility = 1.8 sourceCompatibility = 1.8
repositories { repositories {

View File

@@ -16,11 +16,7 @@ apply plugin: 'eclipse'
apply plugin: 'spring-boot' apply plugin: 'spring-boot'
apply plugin: 'io.spring.dependency-management' apply plugin: 'io.spring.dependency-management'
jar { version = '0.0.1-SNAPSHOT'
baseName = 'demo'
version = '0.0.1-SNAPSHOT'
}
sourceCompatibility = 1.8 sourceCompatibility = 1.8
repositories { repositories {

View File

@@ -16,11 +16,7 @@ apply plugin: 'eclipse'
apply plugin: 'spring-boot' apply plugin: 'spring-boot'
apply plugin: 'io.spring.dependency-management' apply plugin: 'io.spring.dependency-management'
jar { version = '0.0.1-SNAPSHOT'
baseName = 'demo'
version = '0.0.1-SNAPSHOT'
}
sourceCompatibility = 1.8 sourceCompatibility = 1.8
repositories { repositories {

View File

@@ -16,11 +16,7 @@ apply plugin: 'eclipse'
apply plugin: 'spring-boot' apply plugin: 'spring-boot'
apply plugin: 'io.spring.dependency-management' apply plugin: 'io.spring.dependency-management'
jar { version = '0.0.1-SNAPSHOT'
baseName = 'demo'
version = '0.0.1-SNAPSHOT'
}
sourceCompatibility = 1.8 sourceCompatibility = 1.8
repositories { repositories {

View File

@@ -16,11 +16,7 @@ apply plugin: 'eclipse'
apply plugin: 'spring-boot' apply plugin: 'spring-boot'
apply plugin: 'io.spring.dependency-management' apply plugin: 'io.spring.dependency-management'
jar { version = '0.0.1-SNAPSHOT'
baseName = 'demo'
version = '0.0.1-SNAPSHOT'
}
sourceCompatibility = 1.8 sourceCompatibility = 1.8
repositories { repositories {

View File

@@ -17,11 +17,7 @@ apply plugin: 'spring-boot'
apply plugin: 'io.spring.dependency-management' apply plugin: 'io.spring.dependency-management'
apply plugin: 'war' apply plugin: 'war'
war { version = '0.0.1-SNAPSHOT'
baseName = 'demo'
version = '0.0.1-SNAPSHOT'
}
sourceCompatibility = 1.8 sourceCompatibility = 1.8
repositories { repositories {

View File

@@ -16,11 +16,7 @@ apply plugin: 'eclipse'
apply plugin: 'spring-boot' apply plugin: 'spring-boot'
apply plugin: 'io.spring.dependency-management' apply plugin: 'io.spring.dependency-management'
jar { version = '0.0.1-SNAPSHOT'
baseName = 'demo'
version = '0.0.1-SNAPSHOT'
}
sourceCompatibility = 1.8 sourceCompatibility = 1.8
repositories { repositories {

View File

@@ -17,11 +17,7 @@ apply plugin: 'spring-boot'
apply plugin: 'io.spring.dependency-management' apply plugin: 'io.spring.dependency-management'
apply plugin: 'war' apply plugin: 'war'
war { version = '0.0.1-SNAPSHOT'
baseName = 'demo'
version = '0.0.1-SNAPSHOT'
}
sourceCompatibility = 1.8 sourceCompatibility = 1.8
repositories { repositories {

View File

@@ -20,11 +20,7 @@ apply plugin: 'eclipse'
apply plugin: 'spring-boot' apply plugin: 'spring-boot'
apply plugin: 'io.spring.dependency-management' apply plugin: 'io.spring.dependency-management'
jar { version = '0.0.1-SNAPSHOT'
baseName = 'demo'
version = '0.0.1-SNAPSHOT'
}
sourceCompatibility = 1.8 sourceCompatibility = 1.8
repositories { repositories {

View File

@@ -21,11 +21,7 @@ apply plugin: 'spring-boot'
apply plugin: 'io.spring.dependency-management' apply plugin: 'io.spring.dependency-management'
apply plugin: 'war' apply plugin: 'war'
war { version = '0.0.1-SNAPSHOT'
baseName = 'demo'
version = '0.0.1-SNAPSHOT'
}
sourceCompatibility = 1.8 sourceCompatibility = 1.8
repositories { repositories {