lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2026-01-23 13:26:07 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

underline width fix

Browse Source
This commit is contained in:
Anton Lavrenov
2016-12-07 17:20:47 -05:00
parent 265e365b12
commit 03c65860e8
4 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
konva.js
View File

@@ -13087,6 +13087,7 @@
letterSpacing = this.getLetterSpacing(), letterSpacing = this.getLetterSpacing(),
textDecoration = this.textDecoration(), textDecoration = this.textDecoration(),
fill = this.fill(), fill = this.fill(),
fontSize = this.fontSize(),
n; n;
context.setAttr('font', this._getContextFont()); context.setAttr('font', this._getContextFont());
@@ -13123,7 +13124,9 @@
context.beginPath(); context.beginPath();
context.moveTo(0, Math.round(lineHeightPx / 2)); context.moveTo(0, Math.round(lineHeightPx / 2));
context.lineTo(Math.round(width), Math.round(lineHeightPx / 2)); context.lineTo(Math.round(width), Math.round(lineHeightPx / 2));
// context // TODO: I have no idea what is real ratio
// just /20 looks good enough
context.lineWidth = fontSize / 20;
context.strokeStyle = fill; context.strokeStyle = fill;
context.stroke(); context.stroke();
context.restore(); context.restore();

4
konva.min.js vendored
View File

File diff suppressed because one or more lines are too long

5
src/shapes/Text.js
View File

@@ -107,6 +107,7 @@
letterSpacing = this.getLetterSpacing(), letterSpacing = this.getLetterSpacing(),
textDecoration = this.textDecoration(), textDecoration = this.textDecoration(),
fill = this.fill(), fill = this.fill(),
fontSize = this.fontSize(),
n; n;
context.setAttr('font', this._getContextFont()); context.setAttr('font', this._getContextFont());
@@ -143,7 +144,9 @@
context.beginPath(); context.beginPath();
context.moveTo(0, Math.round(lineHeightPx / 2)); context.moveTo(0, Math.round(lineHeightPx / 2));
context.lineTo(Math.round(width), Math.round(lineHeightPx / 2)); context.lineTo(Math.round(width), Math.round(lineHeightPx / 2));
// context // TODO: I have no idea what is real ratio
// just /20 looks good enough
context.lineWidth = fontSize / 20;
context.strokeStyle = fill; context.strokeStyle = fill;
context.stroke(); context.stroke();
context.restore(); context.restore();

2
test/unit/shapes/Text-test.js
View File

@@ -342,7 +342,7 @@ suite('Text', function(){
x: 10, x: 10,
y: 10, y: 10,
text: 'hello\nworld', text: 'hello\nworld',
fontSize: 15, fontSize: 80,
fill: 'red', fill: 'red',
letterSpacing: 5, letterSpacing: 5,
textDecoration: 'underline', textDecoration: 'underline',