lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-10-15 12:34:52 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Warn on undefined return value of dragBoundFunc. close #764

Browse Source
This commit is contained in:
Anton Lavrenov
2019-10-18 14:09:29 -05:00
parent 0192be7784
commit 0669b24cf9
5 changed files with 55 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/Node.ts
View File

@@ -2294,7 +2294,6 @@ export abstract class Node<Config extends NodeConfig = NodeConfig> {
// const pos = pointers.find(p => p.id === this._dragEventId);
const pos = this.getStage()._getPointerById(elem.pointerId);
var dbf = this.dragBoundFunc();
if (!pos) {
return;
}
@@ -2303,8 +2302,16 @@ export abstract class Node<Config extends NodeConfig = NodeConfig> {
y: pos.y - elem.offset.y
};
var dbf = this.dragBoundFunc();
if (dbf !== undefined) {
newNodePos = dbf.call(this, newNodePos, evt);
const bounded = dbf.call(this, newNodePos, evt);
if (!bounded) {
Util.warn(
'dragBoundFunc did not return any value. That is unexpected behavior. You must return new absolute position from dragBoundFunc.'
);
} else {
newNodePos = bounded;
}
}
if (