lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-11-24 16:53:06 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #567 from VladimirTechMan/master

Browse Source 
When removing a child, set key "parent" to null, don't delete it
This commit is contained in:
Anton Lavrenov
2019-02-04 09:13:22 -05:00
committed by GitHub
parent 6b1cf1d306 15e7477e81
commit 075431cc2d
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Container.ts
View File

@@ -66,7 +66,7 @@ export abstract class Container extends Node {
for (var i = 0; i < children.length; i++) {
child = children[i];
// reset parent to prevent many _setChildrenIndices calls
delete child.parent;
child.parent = null;
child.index = 0;
child.remove();
}
@@ -85,7 +85,7 @@ export abstract class Container extends Node {
for (var i = 0; i < children.length; i++) {
child = children[i];
// reset parent to prevent many _setChildrenIndices calls
delete child.parent;
child.parent = null;
child.index = 0;
child.destroy();
}

2
src/Node.ts
View File

@@ -719,7 +719,7 @@ export abstract class Node {
if (parent && parent.children) {
parent.children.splice(this.index, 1);
parent._setChildrenIndices();
delete this.parent;
this.parent = null;
}
// every cached attr that is calculated via node tree