lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-06-28 04:42:02 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

identified a couple public methods in the global object which are actually private

Browse Source
This commit is contained in:
Eric Rowell 2012-04-28 11:23:47 -07:00
parent 4e82139b74
commit 3200a9063a
5 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
dist/kinetic-core.js vendored
View File

@ -67,11 +67,11 @@ Kinetic.GlobalObject = {
} }
} }
}, },
addAnimation: function(anim) { _addAnimation: function(anim) {
anim.id = Kinetic.GlobalObject.animIdCounter++; anim.id = Kinetic.GlobalObject.animIdCounter++;
this.animations.push(anim); this.animations.push(anim);
}, },
removeAnimation: function(id) { _removeAnimation: function(id) {
var animations = this.animations; var animations = this.animations;
for(var n = 0; n < animations.length; n++) { for(var n = 0; n < animations.length; n++) {
if(animations[n].id === id) { if(animations[n].id === id) {
@ -831,11 +831,11 @@ Kinetic.Node.prototype = {
* adding the animation with the addAnimation * adding the animation with the addAnimation
* method auto generates an id * method auto generates an id
*/ */
go.addAnimation(anim); go._addAnimation(anim);
// subscribe to onFinished for first tween // subscribe to onFinished for first tween
trans.tweens[0].onFinished = function() { trans.tweens[0].onFinished = function() {
go.removeAnimation(anim.id); go._removeAnimation(anim.id);
if(config.callback !== undefined) { if(config.callback !== undefined) {
config.callback(); config.callback();
} }
@ -1288,7 +1288,7 @@ Kinetic.Stage.prototype = {
*/ */
start: function() { start: function() {
var go = Kinetic.GlobalObject; var go = Kinetic.GlobalObject;
go.addAnimation(this.anim); go._addAnimation(this.anim);
go._handleAnimation(); go._handleAnimation();
}, },
/** /**
@ -1296,7 +1296,7 @@ Kinetic.Stage.prototype = {
*/ */
stop: function() { stop: function() {
var go = Kinetic.GlobalObject; var go = Kinetic.GlobalObject;
go.removeAnimation(this.anim.id); go._removeAnimation(this.anim.id);
go._handleAnimation(); go._handleAnimation();
}, },
/** /**

4
dist/kinetic-core.min.js vendored
View File

File diff suppressed because one or more lines are too long

4
src/GlobalObject.js
View File

@ -39,11 +39,11 @@ Kinetic.GlobalObject = {
} }
} }
}, },
addAnimation: function(anim) { _addAnimation: function(anim) {
anim.id = Kinetic.GlobalObject.animIdCounter++; anim.id = Kinetic.GlobalObject.animIdCounter++;
this.animations.push(anim); this.animations.push(anim);
}, },
removeAnimation: function(id) { _removeAnimation: function(id) {
var animations = this.animations; var animations = this.animations;
for(var n = 0; n < animations.length; n++) { for(var n = 0; n < animations.length; n++) {
if(animations[n].id === id) { if(animations[n].id === id) {

4
src/Node.js
View File

@ -661,11 +661,11 @@ Kinetic.Node.prototype = {
* adding the animation with the addAnimation * adding the animation with the addAnimation
* method auto generates an id * method auto generates an id
*/ */
go.addAnimation(anim); go._addAnimation(anim);
// subscribe to onFinished for first tween // subscribe to onFinished for first tween
trans.tweens[0].onFinished = function() { trans.tweens[0].onFinished = function() {
go.removeAnimation(anim.id); go._removeAnimation(anim.id);
if(config.callback !== undefined) { if(config.callback !== undefined) {
config.callback(); config.callback();
} }

4
src/Stage.js
View File

@ -86,7 +86,7 @@ Kinetic.Stage.prototype = {
*/ */
start: function() { start: function() {
var go = Kinetic.GlobalObject; var go = Kinetic.GlobalObject;
go.addAnimation(this.anim); go._addAnimation(this.anim);
go._handleAnimation(); go._handleAnimation();
}, },
/** /**
@ -94,7 +94,7 @@ Kinetic.Stage.prototype = {
*/ */
stop: function() { stop: function() {
var go = Kinetic.GlobalObject; var go = Kinetic.GlobalObject;
go.removeAnimation(this.anim.id); go._removeAnimation(this.anim.id);
go._handleAnimation(); go._handleAnimation();
}, },
/** /**