lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2026-01-18 19:51:21 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

reworked _getCache implementation

Browse Source
This commit is contained in:
Eric Rowell
2013-08-09 22:31:25 -07:00
parent 3933568b45
commit 41dea5300a
1 changed files with 17 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
src/Node.js
View File

@@ -46,10 +46,6 @@
skewY: TRANSFORM
};
CACHE_ATTRS = {
transform: 1
};
Kinetic.Util.addMethods(Kinetic.Node, {
_init: function(config) {
this._id = Kinetic.Global.idCounter++;
@@ -64,24 +60,15 @@
delete this.cache[cacheAttr];
}
},
_getCache: function(attr, def){
var val, cache;
// if attr is cacheable
if (CACHE_ATTRS[attr]) {
cache = this.cache[attr];
_getCache: function(attr, privateGetter){
var cache = this.cache[attr];
// if not cached, we need to set it using the private getter method.
if (!cache) {
this.cache[attr] = this[PRIVATE_GET + Kinetic.Util._capitalize(attr)]();
this.cache[attr] = privateGetter.call(this);
}
return this.cache[attr];
}
else {
val = this.attrs[attr];
return val === undefined ? def : val;
}
},
/**
* bind events to the node. KineticJS supports mouseover, mousemove,
@@ -1148,6 +1135,14 @@
},
isDraggable: function() {
return false;
},
/**
* get transform of the node
* @method
* @memberof Kinetic.Node.prototype
*/
getTransform: function() {
return this._getCache(TRANSFORM, this._getTransform);
}
});
@@ -1221,7 +1216,8 @@
method = GET + Kinetic.Util._capitalize(attr);
constructor.prototype[method] = function() {
return this._getCache(attr, def);
var val = this.attrs[attr];
return val === undefined ? def : val;
};
};
Kinetic.Node.addPointGetter = function(constructor, attr) {
@@ -1727,14 +1723,6 @@
* @param {Boolean} visible
*/
Kinetic.Node.addGetter(Kinetic.Node, 'transform');
/**
* get transform of the node
* name getTransform
* @method
* @memberof Kinetic.Node.prototype
*/
// aliases
/**