lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-06-28 01:57:14 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Kinetic.Line detection type is now defaulted to pixel since this is the expected detection strategy

Browse Source
This commit is contained in:
Eric Rowell 2012-05-12 15:45:04 -07:00
parent 51258531bf
commit 502115fad7
5 changed files with 30 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dist/kinetic-core.js vendored
View File

@ -3609,9 +3609,9 @@ Kinetic.Text.prototype = {
* will be no associated context. Will have to create
* a dummy context
*/
if (!context) {
var dummyCanvas = document.createElement('canvas');
context = dummyCanvas.getContext('2d');
if(!context) {
var dummyCanvas = document.createElement('canvas');
context = dummyCanvas.getContext('2d');
}
context.save();
@ -3640,7 +3640,8 @@ Kinetic.Line = function(config) {
this.setDefaultAttrs({
points: [],
lineCap: 'butt',
dashArray: []
dashArray: [],
detectionType: 'pixel'
});
this.shapeType = "Line";

29
dist/kinetic-core.min.js vendored
View File

File diff suppressed because one or more lines are too long

3
src/shapes/Line.js
View File

@ -11,7 +11,8 @@ Kinetic.Line = function(config) {
this.setDefaultAttrs({
points: [],
lineCap: 'butt',
dashArray: []
dashArray: [],
detectionType: 'pixel'
});
this.shapeType = "Line";

6
src/shapes/Text.js
View File

@ -240,9 +240,9 @@ Kinetic.Text.prototype = {
* will be no associated context. Will have to create
* a dummy context
*/
if (!context) {
var dummyCanvas = document.createElement('canvas');
context = dummyCanvas.getContext('2d');
if(!context) {
var dummyCanvas = document.createElement('canvas');
context = dummyCanvas.getContext('2d');
}
context.save();

21
tests/js/unitTests.js
View File

@ -1219,10 +1219,11 @@ Test.prototype.tests = {
}, {
x: 340,
y: 23
}, {
x: 500,
y: 109
}];
}
/*, {
x: 500,
y: 109
}*/];
var line = new Kinetic.Line({
points: points,
@ -1233,9 +1234,17 @@ Test.prototype.tests = {
draggable: true
});
// test that default detection type is pixel
test(line.getDetectionType() === 'pixel', 'dection type should be pixel');
layer.add(line);
stage.add(layer);
line.saveData();
line.on('dragend', function() {
line.saveData();
});
},
'SHAPES - add dashed line': function(containerId) {
var stage = new Kinetic.Stage({
@ -1936,8 +1945,8 @@ Test.prototype.tests = {
verticalAlign: 'middle'
});
// test text width before adding it to stage
test(text.getTextWidth() > 0, 'text width should have a value');
// test text width before adding it to stage
test(text.getTextWidth() > 0, 'text width should have a value');
layer.add(text);
stage.add(layer);