lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2026-01-23 13:26:07 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

stop triggering click and tap on short drag&drop. fix #784

Browse Source
This commit is contained in:
Anton Lavrenov
2019-11-12 15:10:36 -05:00
parent 680ea026d8
commit 67d5e362e8
6 changed files with 1444 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

103
test/functional/DragAndDropEvents-test.js
View File

@@ -475,7 +475,7 @@ suite('DragAndDropEvents', function() {
}, 20);
});
test('drag events should not trigger on a click', function() {
test('click should not start drag&drop', function() {
var stage = addStage();
var layer = new Konva.Layer({
draggable: true
@@ -522,4 +522,105 @@ suite('DragAndDropEvents', function() {
assert.equal(dragmove, 0, 'dragmove not triggered');
assert.equal(dragend, 0, 'dragend not triggered');
});
test('drag&drop should not fire click', function() {
var stage = addStage();
var layer = new Konva.Layer({
draggable: true
});
var circle = new Konva.Circle({
x: 70,
y: 70,
radius: 70,
fill: 'green',
stroke: 'black',
strokeWidth: 4,
name: 'myCircle',
draggable: true
});
layer.add(circle);
stage.add(layer);
var dragstart = 0;
circle.on('dragstart', function() {
dragstart += 1;
});
var dragmove = 0;
circle.on('dragmove', function() {
dragmove += 1;
});
var dragend = 0;
circle.on('dragend', function() {
dragend += 1;
});
var click = 0;
circle.on('click', function() {
click += 1;
});
stage.simulateMouseDown({ x: 70, y: 70 });
stage.simulateMouseMove({ x: 80, y: 80 });
stage.simulateMouseUp({ x: 80, y: 80 });
assert.equal(click, 0, 'click triggered');
assert.equal(dragstart, 1, 'dragstart not triggered');
assert.equal(dragmove, 1, 'dragmove not triggered');
assert.equal(dragend, 1, 'dragend not triggered');
});
test('drag events should not trigger on a click even if we stop drag on dragstart', function() {
var stage = addStage();
var layer = new Konva.Layer({
draggable: true
});
var circle = new Konva.Circle({
x: 70,
y: 70,
radius: 70,
fill: 'green',
stroke: 'black',
strokeWidth: 4,
name: 'myCircle',
draggable: true
});
layer.add(circle);
stage.add(layer);
var dragstart = 0;
circle.on('dragstart', function() {
circle.stopDrag();
dragstart += 1;
});
var dragmove = 0;
circle.on('dragmove', function() {
dragmove += 1;
});
var dragend = 0;
circle.on('dragend', function() {
dragend += 1;
});
var click = 0;
circle.on('click', function() {
click += 1;
});
stage.simulateMouseDown({ x: 70, y: 70 });
stage.simulateMouseMove({ x: 75, y: 75 });
stage.simulateMouseUp({ x: 75, y: 75 });
assert.equal(click, 0, 'click triggered');
assert.equal(dragstart, 1, 'dragstart triggered');
assert.equal(dragmove, 0, 'dragmove not triggered');
assert.equal(dragend, 1, 'dragend triggered');
});
});