From 79d8fe48a936571a39eb1583fa68172d01d74bed Mon Sep 17 00:00:00 2001 From: Slawa Pidgorny Date: Wed, 17 Mar 2021 14:05:14 +0100 Subject: [PATCH 1/4] Fix #1084 --- konva-node/index.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/konva-node/index.js b/konva-node/index.js index 4b6b3c77..f215b799 100644 --- a/konva-node/index.js +++ b/konva-node/index.js @@ -33,6 +33,14 @@ Konva.Util.createImageElement = () => { return node; }; +Konva.Util._urlToImage = (url, callback) => { + const imageObj = Konva.Util.createImageElement(); + imageObj.onload = function () { + callback(imageObj); + }; + imageObj.src = url; +}; + // _checkVisibility use dom element, in node we can skip it Konva.Stage.prototype._checkVisibility = () => {}; From 28b1c1ceddc51db25b767a10a396197f16fe93fc Mon Sep 17 00:00:00 2001 From: Slawa Pidgorny Date: Wed, 17 Mar 2021 14:06:03 +0100 Subject: [PATCH 2/4] Tabs -> spaces --- konva-node/index.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/konva-node/index.js b/konva-node/index.js index f215b799..e99e316a 100644 --- a/konva-node/index.js +++ b/konva-node/index.js @@ -34,11 +34,11 @@ Konva.Util.createImageElement = () => { }; Konva.Util._urlToImage = (url, callback) => { - const imageObj = Konva.Util.createImageElement(); - imageObj.onload = function () { - callback(imageObj); - }; - imageObj.src = url; + const imageObj = Konva.Util.createImageElement(); + imageObj.onload = function () { + callback(imageObj); + }; + imageObj.src = url; }; // _checkVisibility use dom element, in node we can skip it From c4fba7b3fef6e8548d188dae03fb2ad5fcc7278e Mon Sep 17 00:00:00 2001 From: Slawa Pidgorny Date: Wed, 24 Mar 2021 07:31:10 +0100 Subject: [PATCH 3/4] var imageObj = Util.createImageElement(); --- src/Util.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Util.ts b/src/Util.ts index 6a5cba62..2978fcba 100644 --- a/src/Util.ts +++ b/src/Util.ts @@ -666,7 +666,7 @@ export const Util = { */ _urlToImage(url: string, callback: Function) { // if arg is a string, then it's a data url - var imageObj = new glob.Image(); + var imageObj = Util.createImageElement(); imageObj.onload = function () { callback(imageObj); }; From 739b7a782bdf877f7824e61819db52dacfbdfd9c Mon Sep 17 00:00:00 2001 From: Anton Lavrenov Date: Wed, 24 Mar 2021 09:37:18 -0500 Subject: [PATCH 4/4] remove unused inject --- konva-node/index.js | 8 -------- 1 file changed, 8 deletions(-) diff --git a/konva-node/index.js b/konva-node/index.js index e99e316a..4b6b3c77 100644 --- a/konva-node/index.js +++ b/konva-node/index.js @@ -33,14 +33,6 @@ Konva.Util.createImageElement = () => { return node; }; -Konva.Util._urlToImage = (url, callback) => { - const imageObj = Konva.Util.createImageElement(); - imageObj.onload = function () { - callback(imageObj); - }; - imageObj.src = url; -}; - // _checkVisibility use dom element, in node we can skip it Konva.Stage.prototype._checkVisibility = () => {};