lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-10-15 12:34:52 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix caching issues. close #581

Browse Source
This commit is contained in:
Anton Lavrenov
2019-02-18 12:38:17 -05:00
parent 7b22a7ae50
commit 74210cbc79
4 changed files with 47 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/Container.ts
View File

@@ -414,7 +414,10 @@ export abstract class Container extends Node {
this._drawCachedSceneCanvas(context);
context.restore();
} else {
this._drawChildren(canvas, 'drawScene', top, false, caching);
// TODO: comment all arguments here
// describe why we use false for caching
// and why we use caching for skipBuffer, skipComposition
this._drawChildren(canvas, 'drawScene', top, false, caching, caching);
}
}
return this;
@@ -433,13 +436,23 @@ export abstract class Container extends Node {
this._drawCachedHitCanvas(context);
context.restore();
} else {
this._drawChildren(canvas, 'drawHit', top, false, caching);
// TODO: comment all arguments here
// describe why we use false for caching
// and why we use caching for skipBuffer, skipComposition
this._drawChildren(canvas, 'drawHit', top, false, caching, caching);
}
}
return this;
}
// TODO: create ClipContainer
_drawChildren(canvas, drawMethod, top, caching?, skipBuffer?) {
_drawChildren(
canvas,
drawMethod,
top,
caching?,
skipBuffer?,
skipComposition?
) {
var layer = this.getLayer(),
context = canvas && canvas.getContext(),
clipWidth = this.clipWidth(),
@@ -471,7 +484,7 @@ export abstract class Container extends Node {
}
var hasComposition =
this.globalCompositeOperation() !== 'source-over' && !caching;
this.globalCompositeOperation() !== 'source-over' && !skipComposition;
if (hasComposition && layer) {
context.save();
context._applyGlobalCompositeOperation(this);