lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-06-28 14:53:09 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

unrecognized selector should return an empty array. also formatted unit tests

Browse Source
This commit is contained in:
ericdrowell 2012-09-25 12:12:27 -07:00
parent 9bfe5f5e52
commit 74bef1e108
4 changed files with 28 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dist/kinetic-core.js vendored
View File

@ -2592,7 +2592,7 @@ Kinetic.Container.prototype = {
}
// unrecognized selector
else {
return false;
return [];
}
},
_getDescendants: function(arr) {

2
dist/kinetic-core.min.js vendored
View File

File diff suppressed because one or more lines are too long

2
src/Container.js
View File

@ -176,7 +176,7 @@ Kinetic.Container.prototype = {
}
// unrecognized selector
else {
return false;
return [];
}
},
_getDescendants: function(arr) {

9
tests/js/unitTests.js
View File

@ -742,7 +742,9 @@ Test.prototype.tests = {
test(shapes.length === 2, 'shapes array should have 2 elements');
var a = 0;
shapes.apply('on', 'mouseover', function () {a++;});
shapes.apply('on', 'mouseover', function() {
a++;
});
circle.simulate('mouseover');
test(a === 1, 'listener should have fired for circle');
rect.simulate('mouseover');
@ -3229,7 +3231,9 @@ Test.prototype.tests = {
clone.get('.myText')[0].setTextFill('black');
test(group.get('.myRect')[0].attrs.myAttr === 'group rect', 'group rect should have myAttr: group rect');
test(clone.get('.myRect')[0].attrs.myAttr === 'group rect', 'clone rect should have myAttr: group rect');
clone.get('.myRect')[0].setAttrs({myAttr: 'clone rect'});
clone.get('.myRect')[0].setAttrs({
myAttr: 'clone rect'
});
/*
* Make sure that when we change a clone object attr that the rect object
@ -3350,7 +3354,6 @@ Test.prototype.tests = {
layer.add(rect);
stage.add(layer);
rect.setShadow({
offset: [1, 2]
});