lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-11-24 08:46:44 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Fixed "calling remove() for dragging shape will throw an error". close #184

Browse Source
This commit is contained in:
Anton Lavrenov
2016-11-10 16:41:31 -06:00
parent 7b4e10fba8
commit 9b92331410
7 changed files with 100 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

75
test/unit/DragAndDrop-test.js
View File

@@ -369,4 +369,79 @@ suite('DragAndDrop', function() {
}, 50);
});
test('removing shape while drag and drop should no throw error', function() {
var stage = addStage();
var layer = new Konva.Layer();
var circle = new Konva.Circle({
x: stage.getWidth() / 2,
y: stage.getHeight() / 2,
radius: 70,
fill: 'green',
stroke: 'black',
strokeWidth: 4,
name: 'myCircle',
draggable: true
});
layer.add(circle);
stage.add(layer);
stage.simulateMouseDown({
x: 291,
y: 112
});
circle.remove();
stage.simulateMouseMove({
x: 311,
y: 112
});
stage.simulateMouseUp({
x: 291,
y: 112,
button: 2
});
});
test('destroying shape while drag and drop should no throw error', function() {
var stage = addStage();
var layer = new Konva.Layer();
var circle = new Konva.Circle({
x: stage.getWidth() / 2,
y: stage.getHeight() / 2,
radius: 70,
fill: 'green',
stroke: 'black',
strokeWidth: 4,
name: 'myCircle',
draggable: true
});
layer.add(circle);
stage.add(layer);
stage.simulateMouseDown({
x: 291,
y: 112
});
circle.destroy();
stage.simulateMouseMove({
x: 311,
y: 112
});
stage.simulateMouseUp({
x: 291,
y: 112,
});
});
});

10
test/unit/filters/Enhance-test.js
View File

@@ -5,7 +5,7 @@ suite('Enhance', function () {
var imageObj = new Image();
imageObj.onload = function() {
var layer = new Konva.Layer();
var filt = new Konva.Image({
x: 10,
@@ -41,7 +41,7 @@ suite('Enhance', function () {
var imageObj = new Image();
imageObj.onload = function() {
var layer = new Konva.Layer();
darth = new Konva.Image({
x: 10,
@@ -59,16 +59,16 @@ suite('Enhance', function () {
layer.draw();
var tween = new Konva.Tween({
node: darth,
node: darth,
duration: 2.0,
enhance: 1.0,
easing: Konva.Easings.EaseInOut
});
darth.on('mouseover', function() {
tween.play();
});
darth.on('mouseout', function() {
tween.reverse();
});