lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-06-28 15:23:44 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix transform cache issue. close #1116

Browse Source
This commit is contained in:
Anton Lavrenov 2021-05-27 15:02:59 -05:00
parent 3f2c2e5042
commit 9ed1cd7009
2 changed files with 41 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Container.ts
View File

@ -126,9 +126,9 @@ export abstract class Container<
return this; return this;
} }
this._validateAdd(child); this._validateAdd(child);
child._clearCaches();
child.index = this.getChildren().length; child.index = this.getChildren().length;
child.parent = this; child.parent = this;
child._clearCaches();
this.getChildren().push(child); this.getChildren().push(child);
this._fire('add', { this._fire('add', {
child: child, child: child,

44
test/unit/Transformer-test.ts
View File

@ -3419,8 +3419,7 @@ describe('Transformer', function () {
var shape = new Konva.Path({ var shape = new Konva.Path({
x: 50, x: 50,
y: 40, y: 40,
data: data: 'M12.582,9.551C3.251,16.237,0.921,29.021,7.08,38.564l-2.36,1.689l4.893,2.262l4.893,2.262l-0.568-5.36l-0.567-5.359l-2.365,1.694c-4.657-7.375-2.83-17.185,4.352-22.33c7.451-5.338,17.817-3.625,23.156,3.824c5.337,7.449,3.625,17.813-3.821,23.152l2.857,3.988c9.617-6.893,11.827-20.277,4.935-29.896C35.591,4.87,22.204,2.658,12.582,9.551z',
'M12.582,9.551C3.251,16.237,0.921,29.021,7.08,38.564l-2.36,1.689l4.893,2.262l4.893,2.262l-0.568-5.36l-0.567-5.359l-2.365,1.694c-4.657-7.375-2.83-17.185,4.352-22.33c7.451-5.338,17.817-3.625,23.156,3.824c5.337,7.449,3.625,17.813-3.821,23.152l2.857,3.988c9.617-6.893,11.827-20.277,4.935-29.896C35.591,4.87,22.204,2.658,12.582,9.551z',
fill: 'green', fill: 'green',
}); });
layer.add(shape); layer.add(shape);
@ -3636,8 +3635,7 @@ describe('Transformer', function () {
fill: '#333', fill: '#333',
fontSize: 16, fontSize: 16,
fontFamily: 'Arial', fontFamily: 'Arial',
text: text: "All the world's a stage, and all the men and women merely players.",
"All the world's a stage, and all the men and women merely players.",
data: 'M10,10 C0,0 10,150 100,100 S300,150 400,50', data: 'M10,10 C0,0 10,150 100,100 S300,150 400,50',
}); });
layer.add(shape); layer.add(shape);
@ -4584,4 +4582,42 @@ describe('Transformer', function () {
simulateMouseUp(tr); simulateMouseUp(tr);
assert.equal(shape.scaleX(), 0.5); assert.equal(shape.scaleX(), 0.5);
}); });
it('check transform cache', function () {
var stage = addStage({ scaleX: 0.5, scaleY: 0.5 });
var layer = new Konva.Layer();
stage.add(layer);
var textNode = new Konva.Text({
text: 'Some text here',
x: 300,
y: 100,
fontSize: 20,
draggable: true,
width: 200,
});
var tr = new Konva.Transformer({
nodes: [textNode],
enabledAnchors: [
'top-left',
'top-right',
'bottom-left',
'bottom-right',
'middle-left',
'middle-right',
],
boundBoxFunc: function (oldBox, newBox) {
if (newBox.width < 5 || newBox.height < 5 || newBox.width > 1000) {
return oldBox;
}
return newBox;
},
});
layer.add(tr);
layer.add(textNode);
assert.equal(textNode.getClientRect().width, 100);
});
}); });