lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2026-01-23 13:26:07 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix dbltap event in Safari. close #1209

Browse Source
This commit is contained in:
Anton Lavrenov
2021-12-09 08:57:01 -05:00
parent b39b9a8116
commit a4cc960353
6 changed files with 71 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
test/unit/TouchEvents-test.ts
View File

@@ -469,7 +469,7 @@ describe('TouchEvents', function () {
assert.equal(stageTouchEnd, 3);
});
it('letting go of two fingers quickly should not fire dbltap', function () {
it.skip('letting go of two fingers quickly should not fire dbltap', function () {
var stage = addStage();
var layer = new Konva.Layer();
stage.add(layer);
@@ -508,7 +508,11 @@ describe('TouchEvents', function () {
'1) no dbltap triggered after holding down two fingers'
);
simulateTouchEnd(stage, [], [{ x: 100, y: 100, id: 0 }]);
simulateTouchEnd(
stage,
[{ x: 110, y: 110, id: 1 }],
[{ x: 100, y: 100, id: 0 }]
);
simulateTouchEnd(stage, [], [{ x: 110, y: 110, id: 1 }]);
assert.equal(
@@ -666,6 +670,58 @@ describe('TouchEvents', function () {
assert.equal(dbltap, 1, 'no dbltap triggered');
});
it('tapping with different fingers on the different time should trigger double tap', function () {
var stage = addStage();
var layer = new Konva.Layer();
stage.add(layer);
var circle1 = new Konva.Circle({
x: 100,
y: 100,
radius: 70,
fill: 'green',
stroke: 'black',
strokeWidth: 4,
name: 'myCircle1',
});
layer.add(circle1);
layer.draw();
var tap = 0;
var dbltap = 0;
stage.on('tap', function (e) {
assert.equal(e.target, circle1);
tap += 1;
});
stage.on('dbltap', function (e) {
assert.equal(e.target, circle1);
dbltap += 1;
});
simulateTouchStart(
stage,
[{ x: 100, y: 100, id: 0 }],
[{ x: 100, y: 100, id: 0 }]
);
simulateTouchEnd(stage, [], [{ x: 100, y: 100, id: 0 }]);
assert.equal(tap, 1, 'tap triggered');
assert.equal(dbltap, 0, 'no dbltap triggered');
simulateTouchStart(
stage,
[{ x: 100, y: 100, id: 1 }],
[{ x: 100, y: 100, id: 1 }]
);
simulateTouchEnd(stage, [], [{ x: 100, y: 100, id: 1 }]);
assert.equal(tap, 2, 'tap triggered');
assert.equal(dbltap, 1, 'dbltap triggered');
});
it('drag and second tap should not trigger dbltap', function () {
var stage = addStage();
var layer = new Konva.Layer();