lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-10-15 12:34:52 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

deprecate getTextHeight

Browse Source
This commit is contained in:
Anton Lavrenov
2019-02-19 08:41:32 -05:00
parent 1b065a55a0
commit ab4a14abce
4 changed files with 11 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/shapes/Text.ts
View File

@@ -123,8 +123,8 @@ export class Text extends Shape {
_sceneFunc(context) {
var padding = this.padding(),
textHeight = this.getTextHeight(),
lineHeightPx = this.lineHeight() * textHeight,
fontSize = this.fontSize(),
lineHeightPx = this.lineHeight() * fontSize,
textArr = this.textArr,
textArrLen = textArr.length,
verticalAlign = this.verticalAlign(),
@@ -133,7 +133,6 @@ export class Text extends Shape {
totalWidth = this.getWidth(),
letterSpacing = this.letterSpacing(),
fill = this.fill(),
fontSize = this.fontSize(),
textDecoration = this.textDecoration(),
shouldUnderline = textDecoration.indexOf('underline') !== -1,
shouldLineThrough = textDecoration.indexOf('line-through') !== -1,
@@ -263,7 +262,7 @@ export class Text extends Shape {
getHeight() {
var isAuto = this.attrs.height === AUTO || this.attrs.height === undefined;
return isAuto
? this.getTextHeight() * this.textArr.length * this.lineHeight() +
? this.fontSize() * this.textArr.length * this.lineHeight() +
this.padding() * 2
: this.attrs.height;
}
@@ -276,14 +275,10 @@ export class Text extends Shape {
getTextWidth() {
return this.textWidth;
}
// TODO: deprecate and remove the method
/**
* get height of one line of text
* @method
* @name Konva.Text#getTextHeight
* @returns {Number}
*/
getTextHeight() {
Util.warn(
'text.getTextHeight() method is deprecated. Use text.height() - for full height and text.fontSize() - for one line height.'
);
return this.textHeight;
}