lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-10-15 12:34:52 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix detach bug on destroy

Browse Source
This commit is contained in:
Anton Lavrenov
2020-04-23 11:33:00 -05:00
parent f58635bbf6
commit b657111578
4 changed files with 1373 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/shapes/Transformer.ts
View File

@@ -463,9 +463,11 @@ export class Transformer extends Group {
*/
detach() {
// remove events
this._nodes.forEach(node => {
node.off('.' + EVENTS_NAME);
});
if (this._nodes) {
this._nodes.forEach(node => {
node.off('.' + EVENTS_NAME);
});
}
this._nodes = [];
this._resetTransformCache();
}
@@ -1004,6 +1006,13 @@ export class Transformer extends Group {
return;
}
}
// let's find delta transform
// var dx = newAttrs.x - oldAttrs.x,
// dy = newAttrs.y - oldAttrs.y,
// angle = newAttrs.rotation - oldAttrs.rotation,
// scaleX = newAttrs.width / oldAttrs.width,
// scaleY = newAttrs.height / oldAttrs.height;
this._nodes.forEach(node => {
var oldRect = this.__getNodeShape(node, 0);
var newRect = transformAndRotateShape(oldRect, oldAttrs, newAttrs);