lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-09-19 19:07:59 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

cleaned up isAncestorOf logic. stage should not be an ancestor of self. plus this was bad OO design

Browse Source
This commit is contained in:
ericdrowell
2012-09-25 16:30:13 -07:00
parent 2b99a88b7e
commit b757342b11
3 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dist/kinetic-core.js vendored
View File

@@ -2586,10 +2586,6 @@ Kinetic.Container.prototype = {
* @param {Kinetic.Node} node * @param {Kinetic.Node} node
*/ */
isAncestorOf: function(node) { isAncestorOf: function(node) {
if(this.nodeType === 'Stage') {
return true;
}
var parent = node.getParent(); var parent = node.getParent();
while(parent) { while(parent) {
if(parent._id === this._id) { if(parent._id === this._id) {

6
dist/kinetic-core.min.js vendored
View File

File diff suppressed because one or more lines are too long

4
src/Container.js
View File

@@ -198,10 +198,6 @@ Kinetic.Container.prototype = {
* @param {Kinetic.Node} node * @param {Kinetic.Node} node
*/ */
isAncestorOf: function(node) { isAncestorOf: function(node) {
if(this.nodeType === 'Stage') {
return true;
}
var parent = node.getParent(); var parent = node.getParent();
while(parent) { while(parent) {
if(parent._id === this._id) { if(parent._id === this._id) {