lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-09-19 02:37:59 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

changed dashArray to dash. started chipping away at the Shape docs

Browse Source
This commit is contained in:
Eric Rowell
2014-01-09 22:37:27 -08:00
parent 13b91d0db7
commit baf635c7f0
4 changed files with 141 additions and 169 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/unit/Shape-test.js
View File

@@ -317,7 +317,7 @@ suite('Shape', function() {
shadowColor: 'black',
shadowBlur: 10,
shadowOffset: {x:10, y:10},
dashArray: [10, 10],
dash: [10, 10],
scaleX: 3
});
layer.add(circle);
@@ -327,7 +327,7 @@ suite('Shape', function() {
assert.equal(circle.getFillEnabled(), true, 'fillEnabled should be true');
assert.equal(circle.getStrokeEnabled(), true, 'strokeEnabled should be true');
assert.equal(circle.getShadowEnabled(), true, 'shadowEnabled should be true');
assert.equal(circle.getDashArrayEnabled(), true, 'dashArrayEnabled should be true');
assert.equal(circle.dashEnabled(), true, 'dashEnabled should be true');
circle.strokeScaleEnabled(false);
assert.equal(circle.getStrokeScaleEnabled(), false);
@@ -347,13 +347,13 @@ suite('Shape', function() {
circle.shadowEnabled(false);
assert.equal(circle.getShadowEnabled(), false, 'shadowEnabled should be false');
circle.dashArrayEnabled(false);
assert.equal(circle.getDashArrayEnabled(), false, 'dashArrayEnabled should be false');
circle.dashEnabled(false);
assert.equal(circle.dashEnabled(), false, 'dashEnabled should be false');
// re-enable
circle.dashArrayEnabled(true);
assert.equal(circle.getDashArrayEnabled(), true, 'dashArrayEnabled should be true');
circle.dashEnabled(true);
assert.equal(circle.getDashEnabled(), true, 'dashEnabled should be true');
circle.shadowEnabled(true);
assert.equal(circle.getShadowEnabled(), true, 'shadowEnabled should be true');
@@ -509,8 +509,8 @@ suite('Shape', function() {
rect.hitFunc('function');
assert.equal(rect.hitFunc(), 'function');
rect.dashArray([1]);
assert.equal(rect.dashArray()[0], 1);
rect.dash([1]);
assert.equal(rect.dash()[0], 1);
// NOTE: skipping the rest because it would take hours to test all possible methods.
// This should hopefully be enough to test Factor overloaded methods

8
test/unit/shapes/Line-test.js
View File

@@ -94,7 +94,7 @@ suite('Line', function() {
lineCap: 'round',
lineJoin: 'round',
draggable: true,
dashArray: [30, 10, 0, 10, 10, 20],
dash: [30, 10, 0, 10, 10, 20],
shadowColor: '#aaa',
shadowBlur: 10,
shadowOffset: {x:20, y:20}
@@ -104,9 +104,9 @@ suite('Line', function() {
layer.add(line);
stage.add(layer);
assert.equal(line.getDashArray().length, 6);
line.setDashArray([10, 10]);
assert.equal(line.getDashArray().length, 2);
assert.equal(line.dash().length, 6);
line.dash([10, 10]);
assert.equal(line.dash().length, 2);
assert.equal(line.getPoints().length, 8);