lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-09-24 21:37:18 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make Node#isVisible() consistent with drawing behaviour

Browse Source 
Remove the "inherit" value from Node#visible(), and treat `true` similar to "inherit".

Fixes konvajs/konva#906
This commit is contained in:
Nathan Muir
2020-05-13 11:55:36 +12:00
parent 49218376e6
commit bf1b4a91e9
4 changed files with 16871 additions and 16913 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/unit/Node-test.js
View File

@@ -3202,35 +3202,35 @@ suite('Node', function () {
assert.equal(layer.isVisible(), false);
assert.equal(circle.isVisible(), false);
stage.setVisible('inherit');
stage.setVisible(true);
layer.setVisible(false);
assert.equal(stage.isVisible(), true);
assert.equal(layer.isVisible(), false);
assert.equal(circle.isVisible(), false);
layer.setVisible('inherit');
layer.setVisible(true);
circle.setVisible(false);
assert.equal(stage.isVisible(), true);
assert.equal(layer.isVisible(), true);
assert.equal(circle.isVisible(), false);
circle.setVisible('inherit');
circle.setVisible(true);
stage.setVisible(true);
assert.equal(stage.isVisible(), true);
assert.equal(layer.isVisible(), true);
assert.equal(circle.isVisible(), true);
stage.setVisible('inherit');
stage.setVisible(true);
layer.setVisible(true);
assert.equal(stage.isVisible(), true);
assert.equal(layer.isVisible(), true);
assert.equal(circle.isVisible(), true);
layer.setVisible('inherit');
layer.setVisible(true);
circle.setVisible(true);
assert.equal(stage.isVisible(), true);