lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-09-19 10:47:59 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

removed shape enablers and disables. They were reduandant methods and muddied up the API

Browse Source
This commit is contained in:
Eric Rowell
2014-01-05 21:03:11 -08:00
parent 2e97e20436
commit ceddf561fc
2 changed files with 9 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/unit/Shape-test.js
View File

@@ -351,7 +351,7 @@ suite('Shape', function() {
assert.equal(circle.getShadowEnabled(), true, 'shadowEnabled should be true');
assert.equal(circle.getDashArrayEnabled(), true, 'dashArrayEnabled should be true');
circle.disableStrokeScale();
circle.strokeScaleEnabled(false);
assert.equal(circle.getStrokeScaleEnabled(), false);
layer.draw();
@@ -359,31 +359,31 @@ suite('Shape', function() {
//console.log(trace);
assert.equal(trace, 'clearRect(0,0,578,200);save();save();shadowColor=black;shadowBlur=10;shadowOffsetX=10;shadowOffsetY=10;drawImage([object HTMLCanvasElement],0,0);restore();drawImage([object HTMLCanvasElement],0,0);restore();clearRect(0,0,578,200);save();save();shadowColor=black;shadowBlur=10;shadowOffsetX=10;shadowOffsetY=10;drawImage([object HTMLCanvasElement],0,0);restore();drawImage([object HTMLCanvasElement],0,0);restore();');
circle.disableFill();
circle.fillEnabled(false);
assert.equal(circle.getFillEnabled(), false, 'fillEnabled should be false');
circle.disableStroke();
circle.strokeEnabled(false);
assert.equal(circle.getStrokeEnabled(), false, 'strokeEnabled should be false');
circle.disableShadow();
circle.shadowEnabled(false);
assert.equal(circle.getShadowEnabled(), false, 'shadowEnabled should be false');
circle.disableDashArray();
circle.dashArrayEnabled(false);
assert.equal(circle.getDashArrayEnabled(), false, 'dashArrayEnabled should be false');
// re-enable
circle.enableDashArray();
circle.dashArrayEnabled(true);
assert.equal(circle.getDashArrayEnabled(), true, 'dashArrayEnabled should be true');
circle.enableShadow();
circle.shadowEnabled(true);
assert.equal(circle.getShadowEnabled(), true, 'shadowEnabled should be true');
circle.enableStroke();
circle.strokeEnabled(true);
assert.equal(circle.getStrokeEnabled(), true, 'strokeEnabled should be true');
circle.enableFill();
circle.fillEnabled(true);
assert.equal(circle.getFillEnabled(), true, 'fillEnabled should be true');
});