lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-09-19 02:37:59 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

added dynamic color component setters, and also added more unit tests

Browse Source
This commit is contained in:
Eric Rowell
2013-05-03 21:13:26 -07:00
parent 58b081ef12
commit e22f5c4bcf
4 changed files with 78 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/Node.js
View File

@@ -27,7 +27,11 @@
RGB = 'RGB',
R = 'r',
G = 'g',
B = 'b';
B = 'b',
UPPER_R = 'R',
UPPER_G = 'G',
UPPER_B = 'B',
HASH = '#';
/**
* Node constructor. Nodes are entities that can be transformed, layered,
@@ -1039,11 +1043,17 @@
this.addGetter(constructor, attr);
this.addSetter(constructor, attr);
// components
// component getters
this.addColorRGBGetter(constructor, attr);
this.addColorComponentGetter(constructor, attr, R);
this.addColorComponentGetter(constructor, attr, G);
this.addColorComponentGetter(constructor, attr, B);
// component setters
this.addColorRGBSetter(constructor, attr);
this.addColorComponentSetter(constructor, attr, R);
this.addColorComponentSetter(constructor, attr, G);
this.addColorComponentSetter(constructor, attr, B);
};
Kinetic.Node.addColorRGBGetter = function(constructor, attr) {
var method = GET + Kinetic.Type._capitalize(attr) + RGB;
@@ -1051,11 +1061,31 @@
return Kinetic.Type.getRGB(this.attrs[attr]);
};
};
Kinetic.Node.addColorRGBSetter = function(constructor, attr) {
var method = SET + Kinetic.Type._capitalize(attr) + RGB;
constructor.prototype[method] = function(obj) {
var r = obj && obj.r !== undefined ? obj.r | 0 : this.getAttr(attr + UPPER_R),
g = obj && obj.g !== undefined ? obj.g | 0 : this.getAttr(attr + UPPER_G),
b = obj && obj.b !== undefined ? obj.b | 0 : this.getAttr(attr + UPPER_B);
this.setAttr(attr, HASH + Kinetic.Type._rgbToHex(r, g, b));
};
};
Kinetic.Node.addColorComponentGetter = function(constructor, attr, c) {
var baseMethod = GET + Kinetic.Type._capitalize(attr),
method = baseMethod + Kinetic.Type._capitalize(c);
var prefix = GET + Kinetic.Type._capitalize(attr),
method = prefix + Kinetic.Type._capitalize(c);
constructor.prototype[method] = function() {
return this[baseMethod + RGB]()[c];
return this[prefix + RGB]()[c];
};
};
Kinetic.Node.addColorComponentSetter = function(constructor, attr, c) {
var prefix = SET + Kinetic.Type._capitalize(attr),
method = prefix + Kinetic.Type._capitalize(c);
constructor.prototype[method] = function(val) {
var obj = {};
obj[c] = val;
this[prefix + RGB](obj);
};
};
Kinetic.Node.addSetter = function(constructor, attr, isTransform) {

14
src/shapes/Image.js
View File

@@ -234,7 +234,6 @@
// add getters setters
Kinetic.Node.addGetterSetter(Kinetic.Image, 'image');
Kinetic.Node.addGetter(Kinetic.Image, 'crop');
/**
* set image
@@ -243,15 +242,18 @@
* @param {ImageObject} image
*/
/**
* get image
* @name getImage
* @methodOf Kinetic.Image.prototype
*/
Kinetic.Node.addGetter(Kinetic.Image, 'crop');
/**
* get crop
* @name getCrop
* @methodOf Kinetic.Image.prototype
*/
/**
* get image
* @name getImage
* @methodOf Kinetic.Image.prototype
*/
})();