lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-10-15 12:34:52 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactored attr event change logic a bit. added delete operator in a couple places to fix memory leaks. added better event unit tests.

Browse Source
This commit is contained in:
Eric Rowell
2012-06-09 10:53:47 -07:00
parent 12b61b3621
commit e64024d3bd
6 changed files with 96 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/Node.js
View File

@@ -98,14 +98,15 @@ Kinetic.Node.prototype = {
if(this.eventListeners[baseEvent][i].name === name) {
this.eventListeners[baseEvent].splice(i, 1);
if(this.eventListeners[baseEvent].length === 0) {
this.eventListeners[baseEvent] = undefined;
delete this.eventListeners[baseEvent];
break;
}
break;
i--;
}
}
}
else {
this.eventListeners[baseEvent] = undefined;
delete this.eventListeners[baseEvent];
}
}
},
@@ -180,15 +181,14 @@ Kinetic.Node.prototype = {
*/
case 'draggable':
that.draggable(c[key]);
that._fireChangeEvent(key);
break;
case 'listening':
that.listen(c[key]);
that._fireChangeEvent(key);
break;
case 'rotationDeg':
that._setAttr(obj, 'rotation', c[key] * Math.PI / 180);
that._fireChangeEvent('rotation');
// override key for change event
key = 'rotation';
break;
/*
* config objects
@@ -197,7 +197,6 @@ Kinetic.Node.prototype = {
var pos = go._getXY(val);
that._setAttr(obj[key], 'x', pos.x);
that._setAttr(obj[key], 'y', pos.y);
that._fireChangeEvent(key);
break;
/*
* includes:
@@ -208,17 +207,14 @@ Kinetic.Node.prototype = {
var pos = go._getXY(val);
that._setAttr(obj[key], 'x', pos.x);
that._setAttr(obj[key], 'y', pos.y);
that._fireChangeEvent(key);
break;
case 'scale':
var pos = go._getXY(val);
that._setAttr(obj[key], 'x', pos.x);
that._setAttr(obj[key], 'y', pos.y);
that._fireChangeEvent(key);
break;
case 'points':
that._setAttr(obj, key, go._getPoints(val));
that._fireChangeEvent(key);
break;
case 'crop':
var pos = go._getXY(val);
@@ -227,13 +223,13 @@ Kinetic.Node.prototype = {
that._setAttr(obj[key], 'y', pos.y);
that._setAttr(obj[key], 'width', size.width);
that._setAttr(obj[key], 'height', size.height);
that._fireChangeEvent(key);
break;
default:
that._setAttr(obj, key, c[key]);
that._fireChangeEvent(key);
break;
}
that._fireChangeEvent(key);
}
}
}

2
src/Stage.js
View File

@@ -939,7 +939,7 @@ else if(!isDragging && this.touchMove) {
}
}
if(nodes.length === 0) {
this.names[node.attrs.name] = undefined;
delete this.names[node.attrs.name];
}
}
}