lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-10-15 12:34:52 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

removed before event emitter for attr changes to improve performance. I don't think it's really needed

Browse Source
This commit is contained in:
Eric Rowell
2013-12-02 00:06:27 -08:00
parent 722ae82f21
commit f966758bce
4 changed files with 28 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/Node.js
View File

@@ -1128,7 +1128,7 @@
} }
}, },
_fireBeforeChangeEvent: function(attr, oldVal, newVal) { _fireBeforeChangeEvent: function(attr, oldVal, newVal) {
this._fire(BEFORE + Kinetic.Util._capitalize(attr) + CHANGE, { this._fire([BEFORE, Kinetic.Util._capitalize(attr), CHANGE].join(EMPTY_STRING), {
oldVal: oldVal, oldVal: oldVal,
newVal: newVal newVal: newVal
}); });
@@ -1171,7 +1171,8 @@
var oldVal; var oldVal;
if(val !== undefined) { if(val !== undefined) {
oldVal = this.attrs[key]; oldVal = this.attrs[key];
this._fireBeforeChangeEvent(key, oldVal, val); // NOTE: before events removed to improve performance
//this._fireBeforeChangeEvent(key, oldVal, val);
this.attrs[key] = val; this.attrs[key] = val;
this._fireChangeEvent(key, oldVal, val); this._fireChangeEvent(key, oldVal, val);
} }

2
test/performance/common/random-squares.js
View File

@@ -66,7 +66,7 @@
for (var i = 0; i < circles.length; i++) { for (var i = 0; i < circles.length; i++) {
var x = Math.random() * width; var x = Math.random() * width;
var y = Math.random() * height; var y = Math.random() * height;
circles[i].setPosition(x, y); circles[i].setPosition({x: x, y: y});
} }
lastTime = time; lastTime = time;

23
test/performance/random-squares-dev.html Normal file
View File

@@ -0,0 +1,23 @@
<!DOCTYPE HTML>
<html>
<head>
<style>
body {
margin: 0px;
padding: 0px;
}
canvas {
border: 1px solid #9C9898;
}
</style>
</head>
<body>
<div id="container"></div>
<script src="../../dist/kinetic-dev.js"></script>
<script src="http://code.jquery.com/jquery-1.10.1.min.js"></script>
<script src="lib/stats.js"></script>
<script src="common/random-squares.js"></script>
</body>
</html>

3
test/performance/random-squares-v4.7.4.html
View File

@@ -14,8 +14,7 @@
<body> <body>
<div id="container"></div> <div id="container"></div>
<!--<script src="http://d3lp1msu2r81bx.cloudfront.net/kjs/js/lib/kinetic-v4.7.4.js"></script>--> <script src="http://d3lp1msu2r81bx.cloudfront.net/kjs/js/lib/kinetic-v4.7.4.js"></script>
<script src="../../dist/kinetic-dev.js"></script>
<script src="http://code.jquery.com/jquery-1.10.1.min.js"></script> <script src="http://code.jquery.com/jquery-1.10.1.min.js"></script>
<script src="lib/stats.js"></script> <script src="lib/stats.js"></script>
<script src="common/random-squares.js"></script> <script src="common/random-squares.js"></script>