From 9cd05ffdcc44a9a151e3c3caded00fda2ad8d203 Mon Sep 17 00:00:00 2001 From: tyzhaoqi <> Date: Sun, 23 Jun 2013 17:56:53 +0200 Subject: [PATCH] Added missing break in switch/case That missing break is not just a memory leak: It results in incorrect call to mdb_unicode2ascii for binary data! I suspect that is what is causing segfault on some db as repported on https://github.com/brianb/mdbtools/issues/19 --- src/libmdb/data.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libmdb/data.c b/src/libmdb/data.c index c5c576e..98672d3 100644 --- a/src/libmdb/data.c +++ b/src/libmdb/data.c @@ -930,6 +930,7 @@ char *mdb_col_to_string(MdbHandle *mdb, void *buf, int start, int datatype, int text = g_malloc(size); memcpy((char*)buf+start, text, size); } + break; case MDB_TEXT: if (size<0) { text = g_strdup("");