lsm/mdbtools
1
0
Fork 0
mirror of https://github.com/mdbtools/mdbtools.git synced 2025-11-26 10:29:27 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't call exit() from libmdb.so

Browse Source 
Libraries should return an error code, not kill the caller.
Thanks lintian.
This commit is contained in:
Nirgal Vourgère
2012-01-16 02:58:46 +01:00
parent 4c7e9c2bd3
commit c37e82c356
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/libmdb/write.c
View File

@@ -554,8 +554,8 @@ mdb_insert_row(MdbTableDef *table, int num_fields, MdbField *fields)
} }
mdb_debug(MDB_DEBUG_WRITE, "writing page %d", pgnum); mdb_debug(MDB_DEBUG_WRITE, "writing page %d", pgnum);
if (!mdb_write_pg(mdb, pgnum)) { if (!mdb_write_pg(mdb, pgnum)) {
fprintf(stderr, "write failed! exiting...\n"); fprintf(stderr, "write failed!\n");
exit(1); return 0;
} }
mdb_update_indexes(table, num_fields, fields, pgnum, rownum); mdb_update_indexes(table, num_fields, fields, pgnum, rownum);
@@ -685,8 +685,14 @@ unsigned int num_fields;
} }
/* do it! */ /* do it! */
mdb_replace_row(table, table->cur_row-1, row_buffer, new_row_size); mdb_replace_row(table, table->cur_row-1, row_buffer, new_row_size);
return 0; return 0; /* FIXME */
} }
/* WARNING the return code is opposite to convention used elsewhere:
* returns 0 on success
* returns 1 on failure
* This might change on next ABI break.
*/
int int
mdb_replace_row(MdbTableDef *table, int row, void *new_row, int new_row_size) mdb_replace_row(MdbTableDef *table, int row, void *new_row, int new_row_size)
{ {
@@ -745,8 +751,8 @@ int i, pos;
} }
/* drum roll, please */ /* drum roll, please */
if (!mdb_write_pg(mdb, table->cur_phys_pg)) { if (!mdb_write_pg(mdb, table->cur_phys_pg)) {
fprintf(stderr, "write failed! exiting...\n"); fprintf(stderr, "write failed!\n");
exit(1); return 1;
} }
return 0; return 0;
} }