lsm/mdbtools
1
0
Fork 0
mirror of https://github.com/mdbtools/mdbtools.git synced 2025-06-28 15:39:02 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

SQLite does not support foreign keys via ALTER TABLE

Browse Source 
See #82. A complete solution would add the foreign keys to CREATE TABLE
but the goal here is to stop generating bad SQL.
This commit is contained in:
Evan Miller 2020-12-21 17:28:29 -05:00
parent f6884cdc01
commit ccd19c69fa
1 changed files with 6 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/libmdb/backend.c
View File

@ -656,8 +656,6 @@ mdb_get_relationships(MdbHandle *mdb, const gchar *dbnamespace, const char* tabl
backend = MDB_BACKEND_ORACLE; backend = MDB_BACKEND_ORACLE;
} else if (!strcmp(mdb->backend_name, "postgres")) { } else if (!strcmp(mdb->backend_name, "postgres")) {
backend = MDB_BACKEND_POSTGRES; backend = MDB_BACKEND_POSTGRES;
} else if (!strcmp(mdb->backend_name, "sqlite")) {
backend = MDB_BACKEND_SQLITE;
} else if (!mdb->relationships_table) { } else if (!mdb->relationships_table) {
return (char *) g_strconcat( return (char *) g_strconcat(
"-- relationships are not implemented for ", "-- relationships are not implemented for ",
@ -748,7 +746,6 @@ mdb_get_relationships(MdbHandle *mdb, const gchar *dbnamespace, const char* tabl
break; break;
case MDB_BACKEND_POSTGRES: case MDB_BACKEND_POSTGRES:
case MDB_BACKEND_SQLITE:
text = g_strconcat( text = g_strconcat(
"ALTER TABLE ", quoted_table_1, "ALTER TABLE ", quoted_table_1,
" ADD CONSTRAINT ", quoted_constraint_name, " ADD CONSTRAINT ", quoted_constraint_name,
@ -756,32 +753,16 @@ mdb_get_relationships(MdbHandle *mdb, const gchar *dbnamespace, const char* tabl
" REFERENCES ", quoted_table_2, "(", quoted_column_2, ")", " REFERENCES ", quoted_table_2, "(", quoted_column_2, ")",
(grbit & 0x00000100) ? " ON UPDATE CASCADE" : "", (grbit & 0x00000100) ? " ON UPDATE CASCADE" : "",
(grbit & 0x00001000) ? " ON DELETE CASCADE" : "", (grbit & 0x00001000) ? " ON DELETE CASCADE" : "",
/* On some databases (eg PostgreSQL) we also want to set
* the constraints to be optionally deferrable, to
* facilitate out of order bulk loading.
*/
" DEFERRABLE",
" INITIALLY IMMEDIATE",
";\n", NULL); ";\n", NULL);
break; break;
} }
/* On some databases (eg PostgreSQL) we also want to set
* the constraints to be optionally deferrable, to
* facilitate out of order bulk loading.
*/
switch (backend) {
case MDB_BACKEND_POSTGRES:
{
gchar *add_constraint;
add_constraint = text;
text = g_strconcat(add_constraint,
"ALTER TABLE ", quoted_table_1,
" ALTER CONSTRAINT ",
quoted_constraint_name,
" DEFERRABLE"
" INITIALLY IMMEDIATE;\n",
NULL);
g_free(add_constraint);
}
default:
break;
}
} }
g_free(quoted_table_1); g_free(quoted_table_1);
g_free(quoted_column_1); g_free(quoted_column_1);