Remove mdb_find_row and row_size warnings

These aren't helpful or actionable, and may not actually indicate any
kind of problem, so remove them.
This commit is contained in:
Evan Miller
2020-12-29 15:21:22 -05:00
parent 6db8ed13a6
commit d51a37a760

View File

@@ -299,7 +299,7 @@ int mdb_read_row(MdbTableDef *table, unsigned int row)
MdbColumn *col; MdbColumn *col;
unsigned int i; unsigned int i;
int row_start; int row_start;
size_t row_size; size_t row_size = 0;
int delflag, lookupflag; int delflag, lookupflag;
MdbField *fields; MdbField *fields;
int num_fields; int num_fields;
@@ -307,14 +307,14 @@ int mdb_read_row(MdbTableDef *table, unsigned int row)
if (table->num_cols == 0) if (table->num_cols == 0)
return 0; return 0;
if (mdb_find_row(mdb, row, &row_start, &row_size)) { if (mdb_find_row(mdb, row, &row_start, &row_size) == -1 || row_size == 0) {
fprintf(stderr, "warning: mdb_find_row failed.\n"); /* Emitting a warning here isn't especially helpful. The row metadata
* could be bogus for a number of reasons, so just skip to the next one
* without comment. */
// fprintf(stderr, "warning: mdb_find_row failed.\n");
// fprintf(stderr, "warning: row_size = 0.\n");
return 0; return 0;
} }
if (row_size == 0) {
fprintf(stderr, "warning: row_size = 0.\n");
return 0;
}
delflag = lookupflag = 0; delflag = lookupflag = 0;
if (row_start & 0x8000) lookupflag++; if (row_start & 0x8000) lookupflag++;