lsm/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2025-09-23 07:33:34 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "sort writables to be able to skew write probability to lesser ids (older volumes)"

Browse Source 
This reverts commit ce7394f3bf.
This commit is contained in:
Chris Lu
2013-01-17 00:15:13 -08:00
parent a502b78c3f
commit 50fafa3a2c
1 changed files with 5 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
weed-fs/src/pkg/topology/volume_layout.go
View File

@@ -5,15 +5,12 @@ import (
"fmt" "fmt"
"math/rand" "math/rand"
"pkg/storage" "pkg/storage"
"sort"
) )
type volumeIdList []storage.VolumeId
type VolumeLayout struct { type VolumeLayout struct {
repType storage.ReplicationType repType storage.ReplicationType
vid2location map[storage.VolumeId]*VolumeLocationList vid2location map[storage.VolumeId]*VolumeLocationList
writables volumeIdList // transient (sorted!) array of writable volume Ids writables []storage.VolumeId // transient array of writable volume id
pulse int64 pulse int64
volumeSizeLimit uint64 volumeSizeLimit uint64
} }
@@ -22,7 +19,7 @@ func NewVolumeLayout(repType storage.ReplicationType, volumeSizeLimit uint64, pu
return &VolumeLayout{ return &VolumeLayout{
repType: repType, repType: repType,
vid2location: make(map[storage.VolumeId]*VolumeLocationList), vid2location: make(map[storage.VolumeId]*VolumeLocationList),
writables: make(volumeIdList, 0, 4), writables: *new([]storage.VolumeId),
pulse: pulse, pulse: pulse,
volumeSizeLimit: volumeSizeLimit, volumeSizeLimit: volumeSizeLimit,
} }
@@ -36,16 +33,13 @@ func (vl *VolumeLayout) RegisterVolume(v *storage.VolumeInfo, dn *DataNode) {
if len(vl.vid2location[v.Id].list) == v.RepType.GetCopyCount() { if len(vl.vid2location[v.Id].list) == v.RepType.GetCopyCount() {
if vl.isWritable(v) { if vl.isWritable(v) {
vl.writables = append(vl.writables, v.Id) vl.writables = append(vl.writables, v.Id)
if len(vl.writables) > 1 {
vl.writables.Sort()
}
} }
} }
} }
} }
func (vl *VolumeLayout) isWritable(v *storage.VolumeInfo) bool { func (vl *VolumeLayout) isWritable(v *storage.VolumeInfo) bool{
return uint64(v.Size) < vl.volumeSizeLimit && v.Version == storage.CurrentVersion return uint64(v.Size) < vl.volumeSizeLimit && v.Version == storage.CurrentVersion
} }
func (vl *VolumeLayout) Lookup(vid storage.VolumeId) []*DataNode { func (vl *VolumeLayout) Lookup(vid storage.VolumeId) []*DataNode {
@@ -58,13 +52,7 @@ func (vl *VolumeLayout) PickForWrite(count int) (*storage.VolumeId, int, *Volume
fmt.Println("No more writable volumes!") fmt.Println("No more writable volumes!")
return nil, 0, nil, errors.New("No more writable volumes!") return nil, 0, nil, errors.New("No more writable volumes!")
} }
var vid storage.VolumeId vid := vl.writables[rand.Intn(len_writers)]
if len_writers == 1 {
vid = vl.writables[0]
} else {
// skew for lesser indices
vid = vl.writables[rand.Intn(len_writers+1)%len_writers]
}
locationList := vl.vid2location[vid] locationList := vl.vid2location[vid]
if locationList != nil { if locationList != nil {
return &vid, count, locationList, nil return &vid, count, locationList, nil
@@ -94,9 +82,6 @@ func (vl *VolumeLayout) setVolumeWritable(vid storage.VolumeId) bool {
} }
fmt.Println("Volume", vid, "becomes writable") fmt.Println("Volume", vid, "becomes writable")
vl.writables = append(vl.writables, vid) vl.writables = append(vl.writables, vid)
if len(vl.writables) > 1 {
vl.writables.Sort()
}
return true return true
} }
@@ -129,18 +114,3 @@ func (vl *VolumeLayout) ToMap() interface{} {
//m["locations"] = vl.vid2location //m["locations"] = vl.vid2location
return m return m
} }
func (vls volumeIdList) Len() int { return len(vls) }
func (vls volumeIdList) Less(i, j int) bool {
return vls[i] < vls[j]
}
func (vls volumeIdList) Swap(i, j int) {
vls[i], vls[j] = vls[j], vls[i]
}
// convienence sorting
func (vls volumeIdList) Sort() {
sort.Sort(vls)
}