lsm/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2025-11-24 16:53:14 +08:00
Code Issues Actions 17 Packages Projects Releases Wiki Activity

CRITICAL: Restore task conflict definitions to prevent data integrity issues

Browse Source 
- Restore conflicts between vacuum, balance, erasure_coding, and ec_vacuum tasks
- Prevent dangerous concurrent operations on same volumes/resources
- Add comprehensive task conflict matrix to avoid race conditions
- This addresses a serious safety regression where all conflicts were removed

Critical conflicts restored:
- vacuum ↔ balance, erasure_coding, ec_vacuum
- balance ↔ vacuum, erasure_coding, ec_vacuum
- erasure_coding ↔ vacuum, balance, ec_vacuum
- ec_vacuum ↔ vacuum, balance, erasure_coding
- replication ↔ vacuum, balance (destructive ops)
This commit is contained in:
chrislu
2025-08-10 17:56:13 -07:00
parent 04e3a68b61
commit 5c1e6e904d
1 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
weed/admin/topology/internal.go
View File

@@ -84,10 +84,24 @@ func (at *ActiveTopology) isDiskAvailable(disk *activeDisk, taskType TaskType) b
// areTaskTypesConflicting checks if two task types conflict
func (at *ActiveTopology) areTaskTypesConflicting(existing, new TaskType) bool {
// Define conflicting task types dynamically
// For now, assume no task types conflict (can be made configurable later)
// Define conflicting task types to prevent dangerous concurrent operations
// These conflicts prevent race conditions and data integrity issues
conflictMap := map[TaskType][]TaskType{
// No conflicts defined currently - this can be made configurable per task
// Vacuum conflicts with balance and erasure coding (and ec_vacuum)
TaskType("vacuum"): {TaskType("balance"), TaskType("erasure_coding"), TaskType("ec_vacuum")},
// Balance conflicts with vacuum and erasure coding operations
TaskType("balance"): {TaskType("vacuum"), TaskType("erasure_coding"), TaskType("ec_vacuum")},
// Erasure coding conflicts with vacuum and balance operations
TaskType("erasure_coding"): {TaskType("vacuum"), TaskType("balance"), TaskType("ec_vacuum")},
// EC vacuum conflicts with all other maintenance operations on same volume
TaskType("ec_vacuum"): {TaskType("vacuum"), TaskType("balance"), TaskType("erasure_coding")},
// Replication generally should not conflict with read-only operations
// but should conflict with destructive operations
TaskType("replication"): {TaskType("vacuum"), TaskType("balance")},
}
if conflicts, exists := conflictMap[existing]; exists {