lsm/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2025-11-08 05:56:13 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix date string parsing bug for the SQL Engine. (#7446)

Browse Source 
`SQLEngine.valueToTime()` is parsing dates always as UTC (via `time.Parse()`),
regardless of TZ assumptions for different date formats.
This commit is contained in:
Lisandro Pin
2025-11-06 21:07:29 +01:00
committed by GitHub
parent 084b377f87
commit 5fef4145a4
1 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
weed/query/engine/function_helpers.go
View File

@@ -102,22 +102,18 @@ func (e *SQLEngine) valueToTime(value *schema_pb.Value) (time.Time, error) {
case *schema_pb.Value_StringValue: case *schema_pb.Value_StringValue:
// Try to parse various date/time string formats // Try to parse various date/time string formats
dateFormats := []struct { dateFormats := []struct {
format string format string
useLocal bool tz *time.Location
}{ }{
{"2006-01-02 15:04:05", true}, // Local time assumed for non-timezone formats {"2006-01-02 15:04:05", time.Local}, // Local time assumed for non-timezone formats
{"2006-01-02T15:04:05Z", false}, // UTC format {"2006-01-02T15:04:05Z", time.UTC}, // UTC format
{"2006-01-02T15:04:05", true}, // Local time assumed {"2006-01-02T15:04:05", time.Local}, // Local time assumed
{"2006-01-02", true}, // Local time assumed for date only {"2006-01-02", time.Local}, // Local time assumed for date only
{"15:04:05", true}, // Local time assumed for time only {"15:04:05", time.Local}, // Local time assumed for time only
} }
for _, formatSpec := range dateFormats { for _, formatSpec := range dateFormats {
if t, err := time.Parse(formatSpec.format, v.StringValue); err == nil { if t, err := time.ParseInLocation(formatSpec.format, v.StringValue, formatSpec.tz); err == nil {
if formatSpec.useLocal {
// Convert to UTC for consistency if no timezone was specified
return time.Date(t.Year(), t.Month(), t.Day(), t.Hour(), t.Minute(), t.Second(), t.Nanosecond(), time.UTC), nil
}
return t, nil return t, nil
} }
} }